Update json output to use io.writer over string concatenation

8 years ago · 1ef31019d7
parent a953923650
commit 1ef31019d7
1 changed files with 2 additions and 3 deletions
--- a/cmd/helm/init.go
+++ b/cmd/helm/init.go
@ -201,9 +201,8 @@ func (i *initCmd) run() error {
 			if err != nil {
 				return err
 			}
-			jsons := string(jsonb)
-			jsons = "{\"apiVersion\":\"extensions/v1beta1\",\"kind\":\"Deployment\"," + jsons[1:]
-			fmt.Fprint(i.out, jsons)
+			io.WriteString(i.out, "{\"apiVersion\":\"extensions/v1beta1\",\"kind\":\"Deployment\",")
+			(io.Writer).Write(i.out, jsonb[1:])
 			return nil
 		case "yaml":
 			if err := writeYAMLManifest("extensions/v1beta1", "Deployment", body, true, false); err != nil {