fix(tiller): Fixes problem with `--wait` on headless Services

Headless services (with `clusterIP` set to `None`) were reporting
as not being ready because they didn't have an IP address. This adds
a logic check to ignore those services.
pull/2100/head
Taylor Thomas 9 years ago
parent 79e2fb83e3
commit 185fb4f43c

@ -520,7 +520,8 @@ func podsReady(pods []api.Pod) bool {
func servicesReady(svc []api.Service) bool { func servicesReady(svc []api.Service) bool {
for _, s := range svc { for _, s := range svc {
if !api.IsServiceIPSet(&s) { // Make sure the service is not explicitly set to "None" before checking the IP
if s.Spec.ClusterIP != api.ClusterIPNone && !api.IsServiceIPSet(&s) {
return false return false
} }
// This checks if the service has a LoadBalancer and that balancer has an Ingress defined // This checks if the service has a LoadBalancer and that balancer has an Ingress defined

Loading…
Cancel
Save