fix(tiller): correctly sort PodDisruptionBudget objects before pods that might use them (#4769)

Signed-off-by: Matt Tucker <ultimateboy@gmail.com>

pkg/tiller/kind_sorter.go

@@ -31,6 +31,7 @@ var InstallOrder SortOrder = []string{
 	"ResourceQuota",
 	"LimitRange",
 	"PodSecurityPolicy",
+	"PodDisruptionBudget",
 	"Secret",
 	"ConfigMap",
 	"StorageClass",
@@ -81,6 +82,7 @@ var UninstallOrder SortOrder = []string{
 	"StorageClass",
 	"ConfigMap",
 	"Secret",
+	"PodDisruptionBudget",
 	"PodSecurityPolicy",
 	"LimitRange",
 	"ResourceQuota",

pkg/tiller/kind_sorter_test.go

@@ -133,6 +133,10 @@ func TestKindSorter(t *testing.T) {
 			Name: "w",
 			Head: &util.SimpleHead{Kind: "APIService"},
 		},
+		{
+			Name: "z",
+			Head: &util.SimpleHead{Kind: "PodDisruptionBudget"},
+		},
 	}
 
 	for _, test := range []struct {
@@ -140,8 +144,8 @@ func TestKindSorter(t *testing.T) {
 		order       SortOrder
 		expected    string
 	}{
-		{"install", InstallOrder, "abc3de1fgh2ijklmnopqrstuvw!"},
+		{"install", InstallOrder, "abc3zde1fgh2ijklmnopqrstuvw!"},
-		{"uninstall", UninstallOrder, "wvmutsrqponlkji2hgf1ed3cba!"},
+		{"uninstall", UninstallOrder, "wvmutsrqponlkji2hgf1edz3cba!"},
 	} {
 		var buf bytes.Buffer
 		t.Run(test.description, func(t *testing.T) {