Refactor test run to separate method

This will allow us to parallelise it more easily

Signed-off-by: Frank Hamand <frankhamand@gmail.com>

pkg/releasetesting/test_suite.go

@@ -75,16 +75,28 @@ func (ts *TestSuite) Run(env *Environment) error {
 			return err
 		}
 
-		test.result.StartedAt = timeconv.Now()
+		if err := test.run(env); err != nil {
-		if err := env.streamRunning(test.result.Name); err != nil {
 			return err
 		}
-		test.result.Status = release.TestRun_RUNNING
+
+		ts.Results = append(ts.Results, test.result)
+	}
+
+	ts.CompletedAt = timeconv.Now()
+	return nil
+}
+
+func (t *test) run(env *Environment) error {
+	t.result.StartedAt = timeconv.Now()
+	if err := env.streamRunning(t.result.Name); err != nil {
+		return err
+	}
+	t.result.Status = release.TestRun_RUNNING
 
 	resourceCreated := true
-		if err := env.createTestPod(test); err != nil {
+	if err := env.createTestPod(t); err != nil {
 		resourceCreated = false
-			if streamErr := env.streamError(test.result.Info); streamErr != nil {
+		if streamErr := env.streamError(t.result.Info); streamErr != nil {
 			return err
 		}
 	}
@@ -102,20 +114,16 @@ func (ts *TestSuite) Run(env *Environment) error {
 	}
 
 	if resourceCreated && resourceCleanExit {
-			if err := test.assignTestResult(status); err != nil {
+		if err := t.assignTestResult(status); err != nil {
 			return err
 		}
 
-			if err := env.streamResult(test.result); err != nil {
+		if err := env.streamResult(t.result); err != nil {
 			return err
 		}
 	}
 
-		test.result.CompletedAt = timeconv.Now()
+	t.result.CompletedAt = timeconv.Now()
-		ts.Results = append(ts.Results, test.result)
-	}
-
-	ts.CompletedAt = timeconv.Now()
 	return nil
 }