Return error exit-code in case of error

pull/2400/head
Sushil Kumar 8 years ago
parent 24157e4aed
commit 084bbfa2ba

@ -20,6 +20,7 @@ import (
"fmt" "fmt"
"io" "io"
"os" "os"
"strings"
"k8s.io/helm/pkg/helm/helmpath" "k8s.io/helm/pkg/helm/helmpath"
"k8s.io/helm/pkg/plugin" "k8s.io/helm/pkg/plugin"
@ -64,17 +65,20 @@ func (pcmd *pluginRemoveCmd) run() error {
if err != nil { if err != nil {
return err return err
} }
var errorPlugins []string
for _, name := range pcmd.names { for _, name := range pcmd.names {
if found := findPlugin(plugins, name); found != nil { if found := findPlugin(plugins, name); found != nil {
if err := removePlugin(found, pcmd.home); err != nil { if err := removePlugin(found, pcmd.home); err != nil {
fmt.Fprintf(pcmd.out, "Failed to remove plugin %s, got error (%v)\n", name, err) errorPlugins = append(errorPlugins, fmt.Sprintf("Failed to remove plugin %s, got error (%v)", name, err))
} else { } else {
fmt.Fprintf(pcmd.out, "Removed plugin: %s\n", name) fmt.Fprintf(pcmd.out, "Removed plugin: %s\n", name)
} }
} else { } else {
fmt.Fprintf(pcmd.out, "Plugin: %s not found\n", name) errorPlugins = append(errorPlugins, fmt.Sprintf("Plugin: %s not found", name))
}
} }
if len(errorPlugins) > 0 {
return fmt.Errorf(strings.Join(errorPlugins, "\n"))
} }
return nil return nil
} }

Loading…
Cancel
Save