Merge pull request #2497 from tyrannasaurusbanks/master

Add check to stop helm 'waiting' for external services to become ready
pull/205/merge
Taylor Thomas 8 years ago committed by GitHub
commit 0525486bdc

@ -136,6 +136,11 @@ func podsReady(pods []v1.Pod) bool {
func servicesReady(svc []v1.Service) bool { func servicesReady(svc []v1.Service) bool {
for _, s := range svc { for _, s := range svc {
// ExternalName Services are external to cluster so helm shouldn't be checking to see if they're 'ready' (i.e. have an IP Set)
if s.Spec.Type == v1.ServiceTypeExternalName {
continue
}
// Make sure the service is not explicitly set to "None" before checking the IP // Make sure the service is not explicitly set to "None" before checking the IP
if s.Spec.ClusterIP != v1.ClusterIPNone && !v1.IsServiceIPSet(&s) { if s.Spec.ClusterIP != v1.ClusterIPNone && !v1.IsServiceIPSet(&s) {
return false return false

Loading…
Cancel
Save