Merge pull request #1433 from poopoothegorilla/fix/cmd-arg-length

fix(helm): add check for argument length for inspection subcommands
reviewable/pr1450/r1
Matt Butcher 8 years ago committed by GitHub
commit 03b855c812

@ -85,11 +85,14 @@ func newInspectCmd(c helm.Interface, out io.Writer) *cobra.Command {
} }
valuesSubCmd := &cobra.Command{ valuesSubCmd := &cobra.Command{
Use: "values", Use: "values [CHART]",
Short: "shows inspect values", Short: "shows inspect values",
Long: inspectValuesDesc, Long: inspectValuesDesc,
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
insp.output = valuesOnly insp.output = valuesOnly
if err := checkArgsLength(len(args), "chart name"); err != nil {
return err
}
cp, err := locateChartPath(args[0], insp.version, insp.verify, insp.keyring) cp, err := locateChartPath(args[0], insp.version, insp.verify, insp.keyring)
if err != nil { if err != nil {
return err return err
@ -100,11 +103,14 @@ func newInspectCmd(c helm.Interface, out io.Writer) *cobra.Command {
} }
chartSubCmd := &cobra.Command{ chartSubCmd := &cobra.Command{
Use: "chart", Use: "chart [CHART]",
Short: "shows inspect chart", Short: "shows inspect chart",
Long: inspectChartDesc, Long: inspectChartDesc,
RunE: func(cmd *cobra.Command, args []string) error { RunE: func(cmd *cobra.Command, args []string) error {
insp.output = chartOnly insp.output = chartOnly
if err := checkArgsLength(len(args), "chart name"); err != nil {
return err
}
cp, err := locateChartPath(args[0], insp.version, insp.verify, insp.keyring) cp, err := locateChartPath(args[0], insp.version, insp.verify, insp.keyring)
if err != nil { if err != nil {
return err return err

Loading…
Cancel
Save