fix(diagrams): Set a dummy filename to prevent raise error when both name and filename are not provided(#203)

pull/240/head
tessier 5 years ago
parent 8858d1b98a
commit 181503c509

@ -101,8 +101,9 @@ class Diagram:
:param edge_attr: Provide edge_attr dot config attributes. :param edge_attr: Provide edge_attr dot config attributes.
""" """
self.name = name self.name = name
if not name and not filename:
if not filename: filename = "diagrams_file"
elif not filename:
filename = "_".join(self.name.split()).lower() filename = "_".join(self.name.split()).lower()
self.filename = filename self.filename = filename
self.dot = Digraph(self.name, filename=self.filename) self.dot = Digraph(self.name, filename=self.filename)

@ -100,6 +100,13 @@ class DiagramTest(unittest.TestCase):
Node("node1") Node("node1")
self.assertTrue(os.path.exists(f"{self.name}.png")) self.assertTrue(os.path.exists(f"{self.name}.png"))
def test_empty_name(self):
"""Check that providing an empty name don't crash, but save in a diagrams_file.xxx file."""
self.name = 'diagrams_file'
with Diagram(show=False):
Node("node1")
self.assertTrue(os.path.exists(f"diagrams_file.png"))
class ClusterTest(unittest.TestCase): class ClusterTest(unittest.TestCase):
def setUp(self): def setUp(self):

Loading…
Cancel
Save