Refactoring operation name : rename

Refactoring object : makeSegments(String text)

Reason : List<QrSegment> result is too simple to express
meaning segments. So,rename result to segments
pull/90/head^2
jaemin7666 5 years ago
parent da0b9906e4
commit bc243c2543

@ -125,15 +125,15 @@ public final class QrSegment {
Objects.requireNonNull(text);
// Select the most efficient segment encoding automatically
List<QrSegment> result = new ArrayList<>();
List<QrSegment> segments = new ArrayList<>();
if (text.equals("")); // Leave result empty
else if (NUMERIC_REGEX.matcher(text).matches())
result.add(makeNumeric(text));
segments.add(makeNumeric(text));
else if (ALPHANUMERIC_REGEX.matcher(text).matches())
result.add(makeAlphanumeric(text));
segments.add(makeAlphanumeric(text));
else
result.add(makeBytes(text.getBytes(StandardCharsets.UTF_8)));
return result;
segments.add(makeBytes(text.getBytes(StandardCharsets.UTF_8)));
return segments;
}

Loading…
Cancel
Save