Refactoring

pull/146/head
M66B 6 years ago
parent 1882a5fa7d
commit d8587bdb8c

@ -784,54 +784,49 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
} }
} }
private void onMore(final ActionData data) { private void onJunk(final ActionData data) {
boolean inOutbox = EntityFolder.OUTBOX.equals(data.message.folderType); new DialogBuilderLifecycle(context, owner)
boolean show_headers = properties.showHeaders(data.message.id); .setMessage(R.string.title_ask_spam)
.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() {
@Override
public void onClick(DialogInterface dialog, int which) {
Bundle args = new Bundle();
args.putLong("id", data.message.id);
View anchor = bnvActions.findViewById(R.id.action_more); new SimpleTask<Void>() {
PopupMenu popupMenu = new PopupMenu(context, anchor); @Override
popupMenu.inflate(R.menu.menu_message); protected Void onLoad(Context context, Bundle args) {
popupMenu.getMenu().findItem(R.id.menu_forward).setVisible(data.message.content && !inOutbox); long id = args.getLong("id");
popupMenu.getMenu().findItem(R.id.menu_show_headers).setChecked(show_headers);
popupMenu.getMenu().findItem(R.id.menu_show_headers).setEnabled(data.message.uid != null);
popupMenu.getMenu().findItem(R.id.menu_show_html).setEnabled(data.message.content && Helper.classExists("android.webkit.WebView"));
popupMenu.getMenu().findItem(R.id.menu_flag).setChecked(data.message.uid != null && data.message.unflagged != 1);
popupMenu.getMenu().findItem(R.id.menu_reply_all).setVisible(data.message.content && !inOutbox);
popupMenu.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() { DB db = DB.getInstance(context);
@Override try {
public boolean onMenuItemClick(MenuItem target) { db.beginTransaction();
switch (target.getItemId()) {
case R.id.menu_junk: db.message().setMessageUiHide(id, true);
onJunk(data);
return true; EntityMessage message = db.message().getMessage(id);
case R.id.menu_forward: EntityFolder spam = db.folder().getFolderByType(message.account, EntityFolder.JUNK);
onForward(data); EntityOperation.queue(db, message, EntityOperation.MOVE, spam.id);
return true;
case R.id.menu_reply_all: db.setTransactionSuccessful();
onReplyAll(data); } finally {
return true; db.endTransaction();
case R.id.menu_show_headers: }
onShowHeaders(data);
return true; EntityOperation.process(context);
case R.id.menu_show_html:
onShowHtml(data); return null;
return true; }
case R.id.menu_flag:
onFlag(data); @Override
return true; protected void onException(Bundle args, Throwable ex) {
case R.id.menu_unseen: Helper.unexpectedError(context, ex);
onUnseen(data); }
return true; }.load(context, owner, args);
case R.id.menu_answer: }
onAnswer(data); })
return true; .setNegativeButton(android.R.string.cancel, null)
default: .show();
return false;
}
}
});
popupMenu.show();
} }
private void onForward(final ActionData data) { private void onForward(final ActionData data) {
@ -882,68 +877,49 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
.putExtra("reference", data.message.id)); .putExtra("reference", data.message.id));
} }
private void onShowHeaders(ActionData data) { private void onAnswer(final ActionData data) {
boolean show_headers = !properties.showHeaders(data.message.id); final DB db = DB.getInstance(context);
properties.setHeaders(data.message.id, show_headers); db.answer().liveAnswers().observe(owner, new Observer<List<EntityAnswer>>() {
if (show_headers) { @Override
grpHeaders.setVisibility(View.VISIBLE); public void onChanged(List<EntityAnswer> answers) {
pbHeaders.setVisibility(View.VISIBLE); final Collator collator = Collator.getInstance(Locale.getDefault());
collator.setStrength(Collator.SECONDARY); // Case insensitive, process accents etc
Bundle args = new Bundle();
args.putLong("id", data.message.id);
new SimpleTask<Void>() { Collections.sort(answers, new Comparator<EntityAnswer>() {
@Override @Override
protected Void onLoad(Context context, Bundle args) { public int compare(EntityAnswer a1, EntityAnswer a2) {
Long id = args.getLong("id"); return collator.compare(a1.name, a2.name);
DB db = DB.getInstance(context); }
EntityMessage message = db.message().getMessage(id); });
EntityOperation.queue(db, message, EntityOperation.HEADERS);
EntityOperation.process(context);
return null;
}
@Override View anchor = bnvActions.findViewById(R.id.action_more);
protected void onException(Bundle args, Throwable ex) { PopupMenu popupMenu = new PopupMenu(context, anchor);
Helper.unexpectedError(context, ex);
}
}.load(context, owner, args);
} else
notifyDataSetChanged();
}
private void onShowHtml(ActionData data) { int order = 0;
LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context); for (EntityAnswer answer : answers)
lbm.sendBroadcast( popupMenu.getMenu().add(Menu.NONE, answer.id.intValue(), order++, answer.name);
new Intent(ActivityView.ACTION_VIEW_FULL)
.putExtra("id", data.message.id)
.putExtra("from", MessageHelper.getFormattedAddresses(data.message.from, true)));
}
private void onFlag(ActionData data) { popupMenu.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {
Bundle args = new Bundle(); @Override
args.putLong("id", data.message.id); public boolean onMenuItemClick(MenuItem target) {
args.putBoolean("flagged", !data.message.ui_flagged); if (Helper.isPro(context))
Log.i(Helper.TAG, "Set message id=" + data.message.id + " flagged=" + !data.message.ui_flagged); context.startActivity(new Intent(context, ActivityCompose.class)
.putExtra("action", "reply")
.putExtra("reference", data.message.id)
.putExtra("answer", (long) target.getItemId()));
else {
LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context);
lbm.sendBroadcast(new Intent(ActivityView.ACTION_SHOW_PRO));
}
return true;
}
});
new SimpleTask<Void>() { popupMenu.show();
@Override
protected Void onLoad(Context context, Bundle args) throws Throwable {
long id = args.getLong("id");
boolean flagged = args.getBoolean("flagged");
DB db = DB.getInstance(context);
EntityMessage message = db.message().getMessage(id);
db.message().setMessageUiFlagged(message.id, flagged);
EntityOperation.queue(db, message, EntityOperation.FLAG, flagged);
EntityOperation.process(context);
return null;
}
@Override db.answer().liveAnswers().removeObservers(owner);
protected void onException(Bundle args, Throwable ex) {
Helper.unexpectedError(context, ex);
} }
}.load(context, owner, args); });
} }
private void onUnseen(final ActionData data) { private void onUnseen(final ActionData data) {
@ -981,94 +957,118 @@ public class AdapterMessage extends PagedListAdapter<TupleMessageEx, AdapterMess
}.load(context, owner, args); }.load(context, owner, args);
} }
private void onAnswer(final ActionData data) { private void onFlag(ActionData data) {
final DB db = DB.getInstance(context); Bundle args = new Bundle();
db.answer().liveAnswers().observe(owner, new Observer<List<EntityAnswer>>() { args.putLong("id", data.message.id);
@Override args.putBoolean("flagged", !data.message.ui_flagged);
public void onChanged(List<EntityAnswer> answers) { Log.i(Helper.TAG, "Set message id=" + data.message.id + " flagged=" + !data.message.ui_flagged);
final Collator collator = Collator.getInstance(Locale.getDefault());
collator.setStrength(Collator.SECONDARY); // Case insensitive, process accents etc
Collections.sort(answers, new Comparator<EntityAnswer>() {
@Override
public int compare(EntityAnswer a1, EntityAnswer a2) {
return collator.compare(a1.name, a2.name);
}
});
View anchor = bnvActions.findViewById(R.id.action_more);
PopupMenu popupMenu = new PopupMenu(context, anchor);
int order = 0;
for (EntityAnswer answer : answers)
popupMenu.getMenu().add(Menu.NONE, answer.id.intValue(), order++, answer.name);
popupMenu.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {
@Override
public boolean onMenuItemClick(MenuItem target) {
if (Helper.isPro(context))
context.startActivity(new Intent(context, ActivityCompose.class)
.putExtra("action", "reply")
.putExtra("reference", data.message.id)
.putExtra("answer", (long) target.getItemId()));
else {
LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context);
lbm.sendBroadcast(new Intent(ActivityView.ACTION_SHOW_PRO));
}
return true;
}
});
popupMenu.show(); new SimpleTask<Void>() {
@Override
protected Void onLoad(Context context, Bundle args) throws Throwable {
long id = args.getLong("id");
boolean flagged = args.getBoolean("flagged");
DB db = DB.getInstance(context);
EntityMessage message = db.message().getMessage(id);
db.message().setMessageUiFlagged(message.id, flagged);
EntityOperation.queue(db, message, EntityOperation.FLAG, flagged);
EntityOperation.process(context);
return null;
}
db.answer().liveAnswers().removeObservers(owner); @Override
protected void onException(Bundle args, Throwable ex) {
Helper.unexpectedError(context, ex);
} }
}); }.load(context, owner, args);
} }
private void onJunk(final ActionData data) { private void onShowHeaders(ActionData data) {
new DialogBuilderLifecycle(context, owner) boolean show_headers = !properties.showHeaders(data.message.id);
.setMessage(R.string.title_ask_spam) properties.setHeaders(data.message.id, show_headers);
.setPositiveButton(android.R.string.ok, new DialogInterface.OnClickListener() { if (show_headers) {
@Override grpHeaders.setVisibility(View.VISIBLE);
public void onClick(DialogInterface dialog, int which) { pbHeaders.setVisibility(View.VISIBLE);
Bundle args = new Bundle();
args.putLong("id", data.message.id);
new SimpleTask<Void>() {
@Override
protected Void onLoad(Context context, Bundle args) {
long id = args.getLong("id");
DB db = DB.getInstance(context); Bundle args = new Bundle();
try { args.putLong("id", data.message.id);
db.beginTransaction();
db.message().setMessageUiHide(id, true); new SimpleTask<Void>() {
@Override
protected Void onLoad(Context context, Bundle args) {
Long id = args.getLong("id");
DB db = DB.getInstance(context);
EntityMessage message = db.message().getMessage(id);
EntityOperation.queue(db, message, EntityOperation.HEADERS);
EntityOperation.process(context);
return null;
}
EntityMessage message = db.message().getMessage(id); @Override
EntityFolder spam = db.folder().getFolderByType(message.account, EntityFolder.JUNK); protected void onException(Bundle args, Throwable ex) {
EntityOperation.queue(db, message, EntityOperation.MOVE, spam.id); Helper.unexpectedError(context, ex);
}
}.load(context, owner, args);
} else
notifyDataSetChanged();
}
db.setTransactionSuccessful(); private void onShowHtml(ActionData data) {
} finally { LocalBroadcastManager lbm = LocalBroadcastManager.getInstance(context);
db.endTransaction(); lbm.sendBroadcast(
} new Intent(ActivityView.ACTION_VIEW_FULL)
.putExtra("id", data.message.id)
.putExtra("from", MessageHelper.getFormattedAddresses(data.message.from, true)));
}
EntityOperation.process(context); private void onMore(final ActionData data) {
boolean inOutbox = EntityFolder.OUTBOX.equals(data.message.folderType);
boolean show_headers = properties.showHeaders(data.message.id);
return null; View anchor = bnvActions.findViewById(R.id.action_more);
} PopupMenu popupMenu = new PopupMenu(context, anchor);
popupMenu.inflate(R.menu.menu_message);
popupMenu.getMenu().findItem(R.id.menu_forward).setVisible(data.message.content && !inOutbox);
popupMenu.getMenu().findItem(R.id.menu_show_headers).setChecked(show_headers);
popupMenu.getMenu().findItem(R.id.menu_show_headers).setEnabled(data.message.uid != null);
popupMenu.getMenu().findItem(R.id.menu_show_html).setEnabled(data.message.content && Helper.classExists("android.webkit.WebView"));
popupMenu.getMenu().findItem(R.id.menu_flag).setChecked(data.message.uid != null && data.message.unflagged != 1);
popupMenu.getMenu().findItem(R.id.menu_reply_all).setVisible(data.message.content && !inOutbox);
@Override popupMenu.setOnMenuItemClickListener(new PopupMenu.OnMenuItemClickListener() {
protected void onException(Bundle args, Throwable ex) { @Override
Helper.unexpectedError(context, ex); public boolean onMenuItemClick(MenuItem target) {
} switch (target.getItemId()) {
}.load(context, owner, args); case R.id.menu_junk:
} onJunk(data);
}) return true;
.setNegativeButton(android.R.string.cancel, null) case R.id.menu_forward:
.show(); onForward(data);
return true;
case R.id.menu_reply_all:
onReplyAll(data);
return true;
case R.id.menu_show_headers:
onShowHeaders(data);
return true;
case R.id.menu_show_html:
onShowHtml(data);
return true;
case R.id.menu_flag:
onFlag(data);
return true;
case R.id.menu_unseen:
onUnseen(data);
return true;
case R.id.menu_answer:
onAnswer(data);
return true;
default:
return false;
}
}
});
popupMenu.show();
} }
private void onDelete(final ActionData data) { private void onDelete(final ActionData data) {

@ -13,13 +13,8 @@
android:title="@string/title_reply_all" /> android:title="@string/title_reply_all" />
<item <item
android:id="@+id/menu_show_headers" android:id="@+id/menu_answer"
android:checkable="true" android:title="@string/title_answer_reply" />
android:title="@string/title_show_headers" />
<item
android:id="@+id/menu_show_html"
android:title="@string/title_show_html" />
<item <item
android:id="@+id/menu_unseen" android:id="@+id/menu_unseen"
@ -31,6 +26,11 @@
android:title="@string/title_flag" /> android:title="@string/title_flag" />
<item <item
android:id="@+id/menu_answer" android:id="@+id/menu_show_headers"
android:title="@string/title_answer_reply" /> android:checkable="true"
android:title="@string/title_show_headers" />
<item
android:id="@+id/menu_show_html"
android:title="@string/title_show_html" />
</menu> </menu>

Loading…
Cancel
Save