Small improvement

app/src/main/java/eu/faircode/email/BoundaryCallbackMessages.java

@@ -417,7 +417,7 @@ public class BoundaryCallbackMessages extends PagedList.BoundaryCallback<TupleMe
                                     account, browsable,
                                     ifolder, (IMAPMessage) isub[j],
                                     true,
-                                    rules);
+                                    rules, null);
                             found++;
                         }
                         db.message().setMessageFound(message.account, message.thread);

app/src/main/java/eu/faircode/email/Core.java

@@ -1198,7 +1198,7 @@ class Core {
                                 account, folder,
                                 ifolder, (IMAPMessage) isub[j],
                                 false,
-                                rules);
+                                rules, state);
                         ids[from + j] = message.id;
                     } catch (MessageRemovedException ex) {
                         Log.w(folder.name, ex);
@@ -1305,7 +1305,7 @@ class Core {
             EntityAccount account, EntityFolder folder,
             IMAPFolder ifolder, IMAPMessage imessage,
             boolean browsed,
-            List<EntityRule> rules) throws MessagingException, IOException {
+            List<EntityRule> rules, State state) throws MessagingException, IOException {
         long uid = ifolder.getUID(imessage);
 
         if (imessage.isExpunged()) {
@@ -1467,15 +1467,20 @@ class Core {
             if (message.received > account.created)
                 updateContactInfo(context, folder, message);
 
-            SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
+            // Download small messages inline
-            long maxSize = prefs.getInt("download", 0);
+            if (message.size != null) {
-            if (maxSize == 0)
+                long maxSize;
+                if (state == null || state.networkState.isUnmetered())
                     maxSize = MessageHelper.SMALL_MESSAGE_SIZE;
-            else
+                else {
-                maxSize = Math.min(maxSize, MessageHelper.SMALL_MESSAGE_SIZE);
+                    SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(context);
+                    int download = prefs.getInt("download", 0);
+                    maxSize = (download == 0
+                            ? MessageHelper.SMALL_MESSAGE_SIZE
+                            : Math.min(download, MessageHelper.SMALL_MESSAGE_SIZE));
+                }
 
-            // Download small messages inline
+                if (message.size < maxSize) {
-            if (message.size != null && message.size < maxSize) {
                     String body = parts.getHtml(context);
                     Helper.writeText(message.getFile(context), body);
                     db.message().setMessageContent(message.id,
@@ -1489,6 +1494,7 @@ class Core {
                     if (!TextUtils.isEmpty(body))
                         fixAttachments(context, message.id, body);
                 }
+            }
 
         } else {
             if (process) {

app/src/main/java/eu/faircode/email/ServiceSynchronize.java

@@ -832,7 +832,8 @@ public class ServiceSynchronize extends LifecycleService {
                                                         account, folder,
                                                         ifolder, (IMAPMessage) imessage,
                                                         false,
-                                                        db.rule().getEnabledRules(folder.id));
+                                                        db.rule().getEnabledRules(folder.id),
+                                                        state);
 
                                                 if (db.folder().getFolderDownload(folder.id))
                                                     Core.downloadMessage(ServiceSynchronize.this,
@@ -924,7 +925,8 @@ public class ServiceSynchronize extends LifecycleService {
                                                     account, folder,
                                                     ifolder, (IMAPMessage) e.getMessage(),
                                                     false,
-                                                    db.rule().getEnabledRules(folder.id));
+                                                    db.rule().getEnabledRules(folder.id),
+                                                    state);
 
                                             if (db.folder().getFolderDownload(folder.id))
                                                 Core.downloadMessage(ServiceSynchronize.this,