Release expression conditions

FAQ.md

@@ -2901,7 +2901,7 @@ to be able to match [unfolded headers](https://tools.ietf.org/html/rfc2822#secti
 
 **Expressions**
 
-Since version 1.2174 it is possible to use expression conditions, which is [experimental](#faq125) for now.
+Since version 1.2174 it is possible to use expression conditions.
 
 Please [see here](https://ezylang.github.io/EvalEx/references/references.html) about which constants, operators and functions are available.
 
@@ -4291,12 +4291,6 @@ Composing messages using [Markdown](https://en.wikipedia.org/wiki/Markdown) can
 
 <br />
 
-*Rule expression condition (1.2174+)*
-
-See [this FAQ](#faq71)
-
-<br />
-
 *Fast forward to (1.2226+)*
 
 Show (fast) *Forward to* in the answer menu, with addresses recently used for forwarding messages (if any).

app/src/main/java/eu/faircode/email/FragmentRule.java

@@ -191,7 +191,6 @@ public class FragmentRule extends FragmentBase {
     private ContentLoadingProgressBar pbWait;
 
     private Group grpReady;
-    private Group grpExpression;
     private Group grpAge;
     private Group grpSnooze;
     private Group grpFlag;
@@ -401,7 +400,6 @@ public class FragmentRule extends FragmentBase {
         pbWait = view.findViewById(R.id.pbWait);
 
         grpReady = view.findViewById(R.id.grpReady);
-        grpExpression = view.findViewById(R.id.grpExpression);
         grpAge = view.findViewById(R.id.grpAge);
         grpSnooze = view.findViewById(R.id.grpSnooze);
         grpFlag = view.findViewById(R.id.grpFlag);
@@ -946,7 +944,6 @@ public class FragmentRule extends FragmentBase {
         tvFolder.setText(null);
         bottom_navigation.setVisibility(View.GONE);
         grpReady.setVisibility(View.GONE);
-        grpExpression.setVisibility(View.GONE);
         grpAge.setVisibility(View.GONE);
         grpSnooze.setVisibility(View.GONE);
         grpFlag.setVisibility(View.GONE);
@@ -1532,10 +1529,6 @@ public class FragmentRule extends FragmentBase {
                         if (action != null)
                             showActionParameters(action.type);
                     }
-
-                    SharedPreferences prefs = PreferenceManager.getDefaultSharedPreferences(getContext());
-                    boolean experiments = prefs.getBoolean("experiments", false);
-                    grpExpression.setVisibility(experiments ? View.VISIBLE : View.GONE);
                 } catch (Throwable ex) {
                     Log.e(ex);
                 } finally {

app/src/main/res/layout/fragment_rule.xml

@@ -876,12 +876,6 @@
                     app:layout_constraintStart_toStartOf="parent"
                     app:layout_constraintTop_toBottomOf="@id/tvExpression" />
 
-                <androidx.constraintlayout.widget.Group
-                    android:id="@+id/grpExpression"
-                    android:layout_width="0dp"
-                    android:layout_height="0dp"
-                    app:constraint_referenced_ids="tvAndExpression,vSeparatorExpression,tvExpression,etExpression" />
-
                 <TextView
                     android:id="@+id/tvAction"
                     android:layout_width="wrap_content"

index.html

@@ -1583,7 +1583,7 @@ X-Google-Original-From: Somebody &lt;somebody+extra@example.org&gt;</code></pre>
 <p>Note that <a href="https://developer.android.com/reference/java/util/regex/Pattern#DOTALL">dot all mode</a> is enabled to be able to match <a href="https://tools.ietf.org/html/rfc2822#section-3.2.3">unfolded headers</a>.</p>
 <p><br /></p>
 <p><strong>Expressions</strong></p>
-<p>Since version 1.2174 it is possible to use expression conditions, which is <a href="#faq125">experimental</a> for now.</p>
+<p>Since version 1.2174 it is possible to use expression conditions.</p>
 <p>Please <a href="https://ezylang.github.io/EvalEx/references/references.html">see here</a> about which constants, operators and functions are available.</p>
 <p>The following extra variables are available:</p>
 <ul>
@@ -2237,9 +2237,6 @@ $NotDisplayed</code></pre>
 <p><em>Markdown (1.2061+)</em></p>
 <p>Composing messages using <a href="https://en.wikipedia.org/wiki/Markdown">Markdown</a> can be enabled via the three-dots overflow menu of the message editor.</p>
 <p><br /></p>
-<p><em>Rule expression condition (1.2174+)</em></p>
-<p>See <a href="#faq71">this FAQ</a></p>
-<p><br /></p>
 <p><em>Fast forward to (1.2226+)</em></p>
 <p>Show (fast) <em>Forward to</em> in the answer menu, with addresses recently used for forwarding messages (if any). You can show the answer menu by tapping on the answer button at the bottom right of an opened/expanded message.</p>
 <p><br /></p>