Simplification

app/src/main/java/eu/faircode/email/ActivityBase.java

@@ -84,7 +84,8 @@ abstract class ActivityBase extends AppCompatActivity implements SharedPreferenc
         if (!this.getClass().equals(ActivityMain.class)) {
             String theme = prefs.getString("theme", "light");
             int uiMode = getResources().getConfiguration().uiMode;
-            Log.i("UI mode=" + uiMode);
+            boolean night = (uiMode & Configuration.UI_MODE_NIGHT_YES) != 0;
+            Log.i("theme=" + theme + " UI mode=" + uiMode + " night=" + night);
 
             switch (theme) {
                 case "light":
@@ -143,28 +144,20 @@ abstract class ActivityBase extends AppCompatActivity implements SharedPreferenc
 
                 case "system":
                 case "blue_orange_system":
-                    if ((uiMode & Configuration.UI_MODE_NIGHT_YES) != 0)
+                    setTheme(night
-                        setTheme(R.style.AppThemeBlueOrangeDark);
+                            ? R.style.AppThemeBlueOrangeDark : R.style.AppThemeBlueOrangeLight);
-                    else
-                        setTheme(R.style.AppThemeBlueOrangeLight);
                     break;
                 case "yellow_purple_system":
-                    if ((uiMode & Configuration.UI_MODE_NIGHT_YES) != 0)
+                    setTheme(night
-                        setTheme(R.style.AppThemeYellowPurpleDark);
+                            ? R.style.AppThemeYellowPurpleDark : R.style.AppThemeYellowPurpleLight);
-                    else
-                        setTheme(R.style.AppThemeYellowPurpleLight);
                     break;
                 case "red_green_system":
-                    if ((uiMode & Configuration.UI_MODE_NIGHT_YES) != 0)
+                    setTheme(night
-                        setTheme(R.style.AppThemeRedGreenDark);
+                            ? R.style.AppThemeRedGreenDark : R.style.AppThemeRedGreenLight);
-                    else
-                        setTheme(R.style.AppThemeRedGreenLight);
                     break;
                 case "grey_system":
-                    if ((uiMode & Configuration.UI_MODE_NIGHT_YES) != 0)
+                    setTheme(night
-                        setTheme(R.style.AppThemeGreySteelBlueDark);
+                            ? R.style.AppThemeGreySteelBlueDark : R.style.AppThemeGreySteelBlueLight);
-                    else
-                        setTheme(R.style.AppThemeGreySteelBlueLight);
                     break;
             }