msb-public
/
FairEmail
mirror of https://github.com/M66B/FairEmail.git
1
0
Code Issues Projects Releases Wiki Activity

Use correct resent headers

Browse Source
pull/194/merge
M66B 3 years ago
parent 33859b0be8
commit 682a7ffca1
2 changed files with 58 additions and 68 deletions
Show Stats Download Patch File Download Diff File

8
app/src/main/java/eu/faircode/email/FragmentCompose.java
Unescape View File

@ -4597,7 +4597,9 @@ public class FragmentCompose extends FragmentBase {
ref.language, ref.language,
alt_fwd ? R.string.title_subject_forward_alt : R.string.title_subject_forward, alt_fwd ? R.string.title_subject_forward_alt : R.string.title_subject_forward,
subject); subject);
} else if ("resend".equals(action) || "editasnew".equals(action)) { } else if ("resend".equals(action)) {
data.draft.subject = ref.subject;
} else if ("editasnew".equals(action)) {
if (ref.from != null && ref.from.length == 1) { if (ref.from != null && ref.from.length == 1) {
String from = ((InternetAddress) ref.from[0]).getAddress(); String from = ((InternetAddress) ref.from[0]).getAddress();
for (EntityIdentity identity : data.identities) for (EntityIdentity identity : data.identities)
@ -4606,11 +4608,13 @@ public class FragmentCompose extends FragmentBase {
break; break;
} }
} }
data.draft.to = ref.to; data.draft.to = ref.to;
data.draft.cc = ref.cc; data.draft.cc = ref.cc;
data.draft.bcc = ref.bcc; data.draft.bcc = ref.bcc;
data.draft.subject = ref.subject; data.draft.subject = ref.subject;
if (ref.content && "editasnew".equals(action))
if (ref.content)
document = JsoupEx.parse(ref.getFile(context)); document = JsoupEx.parse(ref.getFile(context));
} else if ("list".equals(action)) { } else if ("list".equals(action)) {
data.draft.subject = ref.subject; data.draft.subject = ref.subject;

118
app/src/main/java/eu/faircode/email/MessageHelper.java
Unescape View File

@ -278,94 +278,76 @@ public class MessageHelper {
imessage.addHeader("In-Reply-To", message.inreplyto); imessage.addHeader("In-Reply-To", message.inreplyto);
imessage.addHeader(HEADER_CORRELATION_ID, message.msgid); imessage.addHeader(HEADER_CORRELATION_ID, message.msgid);
// Addresses MailDateFormat mdf = new MailDateFormat();
if (message.headers == null) { mdf.setTimeZone(hide_timezone ? TimeZone.getTimeZone("UTC") : TimeZone.getDefault());
if (message.from != null && message.from.length > 0) String date = mdf.format(new Date(message.sent == null ? message.received : message.sent));
imessage.setFrom(getFrom(message, identity)); imessage.setHeader("Date", date);
if (message.to != null && message.to.length > 0)
imessage.setRecipients(Message.RecipientType.TO, convertAddress(message.to, identity));
if (message.cc != null && message.cc.length > 0) Address us = null;
imessage.setRecipients(Message.RecipientType.CC, convertAddress(message.cc, identity)); if (message.from != null && message.from.length > 0) {
us = getFrom(message, identity);
imessage.setFrom(us);
}
if (message.bcc != null && message.bcc.length > 0) // Resend
imessage.setRecipients(Message.RecipientType.BCC, convertAddress(message.bcc, identity)); if (message.headers != null) {
// https://datatracker.ietf.org/doc/html/rfc2822#section-3.6.6
if (us != null)
imessage.addHeader("Resent-From", us.toString());
if (identity != null && identity.replyto != null) imessage.addHeader("Resent-Date", date);
imessage.setReplyTo(convertAddress(InternetAddress.parse(identity.replyto), identity));
MailDateFormat mdf = new MailDateFormat();
mdf.setTimeZone(hide_timezone ? TimeZone.getTimeZone("UTC") : TimeZone.getDefault());
if (message.sent != null)
imessage.setHeader("Date", mdf.format(new Date(message.sent)));
else
imessage.setHeader("Date", mdf.format(new Date(message.received)));
} else {
// https://datatracker.ietf.org/doc/html/rfc2822#section-3.6.6
ByteArrayInputStream bis = new ByteArrayInputStream(message.headers.getBytes()); ByteArrayInputStream bis = new ByteArrayInputStream(message.headers.getBytes());
Enumeration<Header> headers = new InternetHeaders(bis).getAllHeaders(); List<Header> headers = Collections.list(new InternetHeaders(bis).getAllHeaders());
while (headers.hasMoreElements()) { for (Header header : headers) {
Header header = headers.nextElement();
String name = header.getName(); String name = header.getName();
String value = header.getValue(); String value = header.getValue();
if (name == null || value == null) if (name == null || value == null)
continue; continue;
switch (name) { switch (name.toLowerCase(Locale.ROOT)) {
case "From": case "from":
// Override default header
imessage.setFrom(value); imessage.setFrom(value);
break; break;
case "To": case "date":
imessage.setRecipients(Message.RecipientType.TO, value); // Override default header
break; imessage.setHeader("Date", value);
case "Cc":
imessage.setRecipients(Message.RecipientType.CC, value);
break; break;
case "Bcc":
imessage.setRecipients(Message.RecipientType.BCC, value); case "to":
imessage.addHeader("Resent-To", value);
break; break;
case "Reply-To": case "cc":
imessage.setReplyTo(InternetAddress.parse(value)); imessage.addHeader("Resent-Cc", value);
break; break;
case "Date": case "bcc":
imessage.setHeader("Date", value); imessage.addHeader("Resent-Bcc", value);
break; break;
default: // Resent-Sender
if (name.startsWith("Resent-")) // Resent-Message-ID
imessage.addHeader(name, value);
} }
} }
if (message.from != null && message.from.length > 0) for (Header header : headers) {
imessage.addHeader("Resent-From", getFrom(message, identity).toString()); String name = header.getName();
String value = header.getValue();
if (message.to != null && message.to.length > 0) if (name == null || value == null)
for (Address a : convertAddress(message.to, identity)) continue;
imessage.addHeader("Resent-To", a.toString()); if (name.toLowerCase(Locale.ROOT).startsWith("resent-"))
imessage.addHeader(name, value);
if (message.cc != null && message.cc.length > 0) }
for (Address a : convertAddress(message.cc, identity)) }
imessage.addHeader("Resent-Cc", a.toString());
if (message.bcc != null && message.bcc.length > 0)
for (Address a : convertAddress(message.bcc, identity))
imessage.addHeader("Resent-Bcc", a.toString());
if (identity != null && identity.replyto != null) // Addresses
for (Address a : convertAddress(InternetAddress.parse(identity.replyto), identity)) if (message.to != null && message.to.length > 0)
imessage.addHeader("Resent-Reply-To", a.toString()); imessage.setRecipients(Message.RecipientType.TO, convertAddress(message.to, identity));
MailDateFormat mdf = new MailDateFormat(); if (message.cc != null && message.cc.length > 0)
mdf.setTimeZone(hide_timezone ? TimeZone.getTimeZone("UTC") : TimeZone.getDefault()); imessage.setRecipients(Message.RecipientType.CC, convertAddress(message.cc, identity));
if (message.sent != null)
imessage.addHeader("Resent-Date", mdf.format(new Date(message.sent)));
else
imessage.addHeader("Resent-Date", mdf.format(new Date(message.received)));
// Resent-Sender if (message.bcc != null && message.bcc.length > 0)
// Resent-Message-ID imessage.setRecipients(Message.RecipientType.BCC, convertAddress(message.bcc, identity));
}
if (message.subject != null) { if (message.subject != null) {
int maxlen = MAX_HEADER_LENGTH - "Subject: ".length(); int maxlen = MAX_HEADER_LENGTH - "Subject: ".length();
@ -376,6 +358,10 @@ public class MessageHelper {
// Send message // Send message
if (identity != null) { if (identity != null) {
// Add reply to
if (message.headers == null && identity.replyto != null)
imessage.setReplyTo(convertAddress(InternetAddress.parse(identity.replyto), identity));
// Add extra cc // Add extra cc
if (identity.cc != null) if (identity.cc != null)
addAddress(identity.cc, Message.RecipientType.CC, imessage, identity); addAddress(identity.cc, Message.RecipientType.CC, imessage, identity);

Write Preview
Loading…
Cancel
Save