Improved options search

app/src/main/java/eu/faircode/email/FragmentOptions.java

@@ -348,49 +348,51 @@ public class FragmentOptions extends FragmentBase {
             }
 
             private void suggest(String query) {
-                if (data == null &&
+                Bundle args = new Bundle();
-                        query != null && query.length() > 0)
+                args.putString("query", query);
-                    new SimpleTask<SuggestData>() {
-                        @Override
-                        protected SuggestData onExecute(Context context, Bundle args) {
-                            return getSuggestData(context);
-                        }
 
-                        @Override
+                new SimpleTask<SuggestData>() {
-                        protected void onExecuted(Bundle args, SuggestData result) {
+                    @Override
-                            data = result;
+                    protected SuggestData onExecute(Context context, Bundle args) {
-                            _suggest(query);
+                        if (TextUtils.isEmpty(args.getString("query")))
-                        }
+                            return data;
 
-                        @Override
+                        return (data == null ? getSuggestData(context) : data);
-                        protected void onException(Bundle args, Throwable ex) {
+                    }
-                            Log.w(ex);
-                            try {
-                                // Fallback to UI thread (Android 5.1.1)
-                                data = getSuggestData(getContext());
-                                _suggest(query);
-                            } catch (Throwable exex) {
-                                Log.unexpectedError(getParentFragmentManager(), exex);
-                            }
-                        }
 
-                        private SuggestData getSuggestData(Context context) {
+                    @Override
-                            SuggestData data = new SuggestData();
+                    protected void onExecuted(Bundle args, SuggestData result) {
-                            data.titles = new String[TAB_PAGES.length];
+                        data = result;
-                            data.views = new View[TAB_PAGES.length];
+                        _suggest(args.getString("query"));
+                    }
 
-                            LayoutInflater inflater = LayoutInflater.from(context);
+                    @Override
-                            for (int tab = 0; tab < TAB_PAGES.length; tab++) {
+                    protected void onException(Bundle args, Throwable ex) {
-                                data.titles[tab] = context.getString(PAGE_TITLES[tab]);
+                        Log.w(ex);
-                                data.views[tab] = inflater.inflate(TAB_PAGES[tab], null);
+                        try {
-                            }
+                            // Fallback to UI thread (Android 5.1.1)
+                            data = getSuggestData(getContext());
+                            _suggest(args.getString("query"));
+                        } catch (Throwable exex) {
+                            Log.unexpectedError(getParentFragmentManager(), exex);
+                        }
+                    }
 
-                            return data;
+                    private SuggestData getSuggestData(Context context) {
+                        SuggestData data = new SuggestData();
+                        data.titles = new String[TAB_PAGES.length];
+                        data.views = new View[TAB_PAGES.length];
+
+                        LayoutInflater inflater = LayoutInflater.from(context);
+                        for (int tab = 0; tab < TAB_PAGES.length; tab++) {
+                            data.titles[tab] = context.getString(PAGE_TITLES[tab]);
+                            data.views[tab] = inflater.inflate(TAB_PAGES[tab], null);
                         }
-                    }.setExecutor(executor)
+
-                            .execute(FragmentOptions.this, new Bundle(), "option:suggest");
+                        return data;
-                else
+                    }
-                    _suggest(query);
+                }.setExecutor(executor)
+                        .execute(FragmentOptions.this, args, "option:suggest");
             }
 
             private void _suggest(String query) {