fix: prevent manage system assignment from manage groups permission

pull/5698/head
NGPixel 3 years ago committed by Nicolas Giard
parent 7715dc6f5e
commit e5cbf6b943

@ -167,6 +167,14 @@ module.exports = {
throw new gql.GraphQLError('You are not authorized to manage this group or assign these permissions.')
}
// Check assigned permissions for manage:groups
if (
WIKI.auth.checkExclusiveAccess(req.user, ['manage:groups'], ['manage:system']) &&
args.permissions.some(p => _.last(p.split(':')) === 'system')
) {
throw new gql.GraphQLError('You are not authorized to manage this group or assign the manage:system permissions.')
}
// Update group
await WIKI.models.groups.query().patch({
name: args.name,

Loading…
Cancel
Save