From 462896b1055003a581c9364bce367e520e96d142 Mon Sep 17 00:00:00 2001 From: Craig Reyenga Date: Mon, 18 Aug 2025 12:46:27 -0400 Subject: [PATCH] Fix: No user-agent cause 500 (#3611) --- server/controllers/auth.js | 3 +-- server/controllers/common.js | 2 +- 2 files changed, 2 insertions(+), 3 deletions(-) diff --git a/server/controllers/auth.js b/server/controllers/auth.js index 9d691087..524d3f03 100644 --- a/server/controllers/auth.js +++ b/server/controllers/auth.js @@ -94,8 +94,7 @@ router.all('/login/:strategy/callback', async (req, res, next) => { */ router.post('/login', bruteforce.prevent, async (req, res, next) => { _.set(res.locals, 'pageMeta.title', 'Login') - - if (req.query.legacy || req.get('user-agent').indexOf('Trident') >= 0) { + if (req.query.legacy || (req.get('user-agent') && req.get('user-agent').indexOf('Trident') >= 0)) { try { const authResult = await WIKI.models.users.login({ strategy: req.body.strategy, diff --git a/server/controllers/common.js b/server/controllers/common.js index 55cc4d33..8fb93dfb 100644 --- a/server/controllers/common.js +++ b/server/controllers/common.js @@ -507,7 +507,7 @@ router.get('/*', async (req, res, next) => { injectCode.body = `${injectCode.body}\n${page.extra.js}` } - if (req.query.legacy || req.get('user-agent').indexOf('Trident') >= 0) { + if (req.query.legacy || (req.get('user-agent') && req.get('user-agent').indexOf('Trident') >= 0)) { // -> Convert page TOC if (_.isString(page.toc)) { page.toc = JSON.parse(page.toc)