From 2d06a1d9df4d1e38c28c3c03ba21361a69b7f19a Mon Sep 17 00:00:00 2001 From: NGPixel Date: Sat, 22 Feb 2020 20:21:26 -0500 Subject: [PATCH] fix: set open external link in new tab as an option --- server/modules/rendering/html-core/definition.yml | 6 ++++++ server/modules/rendering/html-core/renderer.js | 4 +++- 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/server/modules/rendering/html-core/definition.yml b/server/modules/rendering/html-core/definition.yml index f8f5f3f0..c11da260 100644 --- a/server/modules/rendering/html-core/definition.yml +++ b/server/modules/rendering/html-core/definition.yml @@ -12,3 +12,9 @@ props: title: Treat relative links as root absolute hint: For example, a link to foo/bar on page xyz will render as /foo/bar instead of /xyz/foo/bar. order: 1 + openExternalLinkNewTab: + type: Boolean + default: false + title: Open external links in a new tab + hint: External links will have a _blank target attribute added automatically. + order: 2 diff --git a/server/modules/rendering/html-core/renderer.js b/server/modules/rendering/html-core/renderer.js index d0ce78d8..98f4562e 100644 --- a/server/modules/rendering/html-core/renderer.js +++ b/server/modules/rendering/html-core/renderer.js @@ -113,7 +113,9 @@ module.exports = { } } else { $(elm).addClass(`is-external-link`) - $(elm).attr('target', '_blank') + if (this.config.openExternalLinkNewTab) { + $(elm).attr('target', '_blank') + } } // -> Update element