From ef703cf9c7b137350538fef1233084582d7292ee Mon Sep 17 00:00:00 2001
From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Date: Sun, 13 Oct 2024 10:03:59 +0530
Subject: [PATCH] Revert "fix(theme): bind missing no icon prop in the menu
 link component (#4260)"

This reverts commit d4712c17c5e39e396d3522398a4897119739c0a7.
---
 src/client/theme-default/components/VPMenuLink.vue         | 6 +++---
 src/client/theme-default/components/VPNavBarMenuLink.vue   | 7 ++++---
 .../theme-default/components/VPNavScreenMenuGroupLink.vue  | 6 +++---
 .../theme-default/components/VPNavScreenMenuLink.vue       | 1 -
 4 files changed, 10 insertions(+), 10 deletions(-)

diff --git a/src/client/theme-default/components/VPMenuLink.vue b/src/client/theme-default/components/VPMenuLink.vue
index 5d860338..52b4fac3 100644
--- a/src/client/theme-default/components/VPMenuLink.vue
+++ b/src/client/theme-default/components/VPMenuLink.vue
@@ -18,9 +18,9 @@ const { page } = useData()
       :href="item.link"
       :target="item.target"
       :rel="item.rel"
-      :no-icon="item.noIcon"
-      v-html="item.text"
-    />
+    >
+      {{ item.text }}
+    </VPLink>
   </div>
 </template>
 
diff --git a/src/client/theme-default/components/VPNavBarMenuLink.vue b/src/client/theme-default/components/VPNavBarMenuLink.vue
index 01e6ae75..e5c166a0 100644
--- a/src/client/theme-default/components/VPNavBarMenuLink.vue
+++ b/src/client/theme-default/components/VPNavBarMenuLink.vue
@@ -22,12 +22,13 @@ const { page } = useData()
       )
     }"
     :href="item.link"
+    :noIcon="item.noIcon"
     :target="item.target"
     :rel="item.rel"
-    :no-icon="item.noIcon"
     tabindex="0"
-    v-html="item.text"
-  />
+  >
+    <span v-html="item.text"></span>
+  </VPLink>
 </template>
 
 <style scoped>
diff --git a/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue b/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue
index af9f2728..e84a9770 100644
--- a/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue
+++ b/src/client/theme-default/components/VPNavScreenMenuGroupLink.vue
@@ -16,10 +16,10 @@ const closeScreen = inject('close-screen') as () => void
     :href="item.link"
     :target="item.target"
     :rel="item.rel"
-    :no-icon="item.noIcon"
     @click="closeScreen"
-    v-html="item.text"
-  />
+  >
+    {{ item.text }}
+  </VPLink>
 </template>
 
 <style scoped>
diff --git a/src/client/theme-default/components/VPNavScreenMenuLink.vue b/src/client/theme-default/components/VPNavScreenMenuLink.vue
index cd60aaef..e3d54cb1 100644
--- a/src/client/theme-default/components/VPNavScreenMenuLink.vue
+++ b/src/client/theme-default/components/VPNavScreenMenuLink.vue
@@ -16,7 +16,6 @@ const closeScreen = inject('close-screen') as () => void
     :href="item.link"
     :target="item.target"
     :rel="item.rel"
-    :no-icon="item.noIcon"
     @click="closeScreen"
     v-html="item.text"
   />