From dc98a2b9ac7562a19c4747def161d3986f4ca3e1 Mon Sep 17 00:00:00 2001 From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> Date: Thu, 30 Jul 2026 03:12:45 +0530 Subject: [PATCH] refactor(markdown): drop parameter defaults from createMarkdownToVueRenderFn It is internal and its only caller passes every argument; apply the fallbacks at the call site instead of hiding them in the signature after the required siteConfig parameter. Co-Authored-By: Claude Fable 5 --- src/node/markdownToVue.ts | 8 ++++---- src/node/plugin.ts | 6 +++--- 2 files changed, 7 insertions(+), 7 deletions(-) diff --git a/src/node/markdownToVue.ts b/src/node/markdownToVue.ts index b67bb475..f26f31d4 100644 --- a/src/node/markdownToVue.ts +++ b/src/node/markdownToVue.ts @@ -87,10 +87,10 @@ function getResolutionCache(siteConfig: SiteConfig) { export async function createMarkdownToVueRenderFn( srcDir: string, - options: MarkdownOptions = {}, - base = '/', - includeLastUpdatedData = false, - cleanUrls = false, + options: MarkdownOptions, + base: string, + includeLastUpdatedData: boolean, + cleanUrls: boolean, siteConfig: SiteConfig ) { const md = await createMarkdownRenderer( diff --git a/src/node/plugin.ts b/src/node/plugin.ts index 93aa29cf..c97b9494 100644 --- a/src/node/plugin.ts +++ b/src/node/plugin.ts @@ -126,10 +126,10 @@ export async function createVitePressPlugin( if (lastUpdated) await cacheAllGitTimestamps(srcDir) markdownToVue = await createMarkdownToVueRenderFn( srcDir, - markdown, + markdown ?? {}, config.base, - lastUpdated, - cleanUrls, + lastUpdated ?? false, + cleanUrls ?? false, siteConfig ) },