From d3df17bc7b02caadc07d62136143a976a1684ff2 Mon Sep 17 00:00:00 2001
From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Date: Mon, 27 Jun 2022 15:56:44 +0530
Subject: [PATCH] fix: remove explicit noopener from external links
---
docs/guide/markdown.md | 2 +-
src/client/theme-default/components/VPButton.vue | 2 +-
src/client/theme-default/components/VPLink.vue | 2 +-
src/client/theme-default/components/VPSocialLink.vue | 2 +-
src/node/markdown/markdown.ts | 2 +-
src/node/markdownToVue.ts | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/docs/guide/markdown.md b/docs/guide/markdown.md
index 39716fef..1abf0c17 100644
--- a/docs/guide/markdown.md
+++ b/docs/guide/markdown.md
@@ -46,7 +46,7 @@ Pages and internal links get generated with the `.html` suffix by default.
### External Links
-Outbound links automatically get `target="_blank" rel="noopener noreferrer"`:
+Outbound links automatically get `target="_blank" rel="noreferrer"`:
- [vuejs.org](https://vuejs.org)
- [VitePress on GitHub](https://github.com/vuejs/vitepress)
diff --git a/src/client/theme-default/components/VPButton.vue b/src/client/theme-default/components/VPButton.vue
index e1d3408a..0154b4cd 100644
--- a/src/client/theme-default/components/VPButton.vue
+++ b/src/client/theme-default/components/VPButton.vue
@@ -33,7 +33,7 @@ const component = computed(() => {
:class="classes"
:href="href ? withBase(href) : undefined"
:target="isExternal ? '_blank' : undefined"
- :rel="isExternal ? 'noopener noreferrer' : undefined"
+ :rel="isExternal ? 'noreferrer' : undefined"
>
{{ text }}
diff --git a/src/client/theme-default/components/VPLink.vue b/src/client/theme-default/components/VPLink.vue
index bf29e4b5..02b0f6e5 100644
--- a/src/client/theme-default/components/VPLink.vue
+++ b/src/client/theme-default/components/VPLink.vue
@@ -18,7 +18,7 @@ const isExternal = computed(() => props.href && /^[a-z]+:/i.test(props.href))
:class="{ link: href }"
:href="href ? normalizeLink(href) : undefined"
:target="isExternal ? '_blank' : undefined"
- :rel="isExternal ? 'noopener noreferrer' : undefined"
+ :rel="isExternal ? 'noreferrer' : undefined"
>
diff --git a/src/client/theme-default/components/VPSocialLink.vue b/src/client/theme-default/components/VPSocialLink.vue
index 92d3fb12..53a6153c 100644
--- a/src/client/theme-default/components/VPSocialLink.vue
+++ b/src/client/theme-default/components/VPSocialLink.vue
@@ -32,7 +32,7 @@ const icons = {
:href="link"
:title="icon"
target="_blank"
- rel="noopener noreferrer"
+ rel="noreferrer"
>
{{ icon }}
diff --git a/src/node/markdown/markdown.ts b/src/node/markdown/markdown.ts
index 77276c62..7582f47f 100644
--- a/src/node/markdown/markdown.ts
+++ b/src/node/markdown/markdown.ts
@@ -78,7 +78,7 @@ export const createMarkdownRenderer = async (
linkPlugin,
{
target: '_blank',
- rel: 'noopener noreferrer',
+ rel: 'noreferrer',
...options.externalLinks
},
base
diff --git a/src/node/markdownToVue.ts b/src/node/markdownToVue.ts
index 049bd8d8..93fdf9db 100644
--- a/src/node/markdownToVue.ts
+++ b/src/node/markdownToVue.ts
@@ -100,7 +100,7 @@ export async function createMarkdownToVueRenderFn(
`\n(!) Found dead link ${c.cyan(url)} in file ${c.white(
c.dim(file)
)}\nIf it is intended, you can use:\n ${c.cyan(
- `${url}`
+ `${url}`
)}`
)
)