From 72950337bc31fd2f8879d6a2f219018a18b29727 Mon Sep 17 00:00:00 2001
From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Date: Fri, 22 Jul 2022 15:26:47 +0530
Subject: [PATCH] fix: don't add base to external urls while preloading (#1045)

---
 src/node/build/render.ts | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/src/node/build/render.ts b/src/node/build/render.ts
index c38af2a3..0886fbe3 100644
--- a/src/node/build/render.ts
+++ b/src/node/build/render.ts
@@ -10,7 +10,8 @@ import {
   PageData,
   createTitle,
   notFoundPageData,
-  mergeHead
+  mergeHead,
+  EXTERNAL_URL_RE
 } from '../shared'
 import { slash } from '../utils/slash'
 import { SiteConfig, resolveSiteDataByRoute } from '../config'
@@ -104,13 +105,17 @@ export async function renderPage(
 
   const preloadLinksString = preloadLinks
     .map((file) => {
-      return `<link rel="modulepreload" href="${siteData.base}${file}">`
+      return `<link rel="modulepreload" href="${
+        EXTERNAL_URL_RE.test(file) ? '' : siteData.base // don't add base to external urls
+      }${file}">`
     })
     .join('\n    ')
 
   const prefetchLinkString = prefetchLinks
     .map((file) => {
-      return `<link rel="prefetch" href="${siteData.base}${file}">`
+      return `<link rel="prefetch" href="${
+        EXTERNAL_URL_RE.test(file) ? '' : siteData.base // don't add base to external urls
+      }${file}">`
     })
     .join('\n    ')