From 6b5e7704a01500d87a3702f7b27f95a4bdcfa10d Mon Sep 17 00:00:00 2001
From: TowyTowy <85077986+TowyTowy@users.noreply.github.com>
Date: Wed, 8 Jul 2026 20:25:44 +0200
Subject: [PATCH] fix(theme): pass target and rel to prev/next page links
 (#5297)

Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
---
 .../theme-default/support/sidebar.test.ts     | 43 ++++++++++++++++++-
 .../theme-default/components/VPDocFooter.vue  |  4 ++
 .../theme-default/composables/prev-next.ts    | 24 +++++++++--
 src/client/theme-default/support/sidebar.ts   |  6 ++-
 4 files changed, 71 insertions(+), 6 deletions(-)

diff --git a/__tests__/unit/client/theme-default/support/sidebar.test.ts b/__tests__/unit/client/theme-default/support/sidebar.test.ts
index 91e8085bb..7232757c2 100644
--- a/__tests__/unit/client/theme-default/support/sidebar.test.ts
+++ b/__tests__/unit/client/theme-default/support/sidebar.test.ts
@@ -1,4 +1,8 @@
-import { getSidebar, hasActiveLink } from 'client/theme-default/support/sidebar'
+import {
+  getFlatSideBarLinks,
+  getSidebar,
+  hasActiveLink
+} from 'client/theme-default/support/sidebar'
 
 describe('client/theme-default/support/sidebar', () => {
   describe('getSidebar', () => {
@@ -137,6 +141,43 @@ describe('client/theme-default/support/sidebar', () => {
     })
   })
 
+  describe('getFlatSideBarLinks', () => {
+    test('flattens nested items and preserves link metadata', () => {
+      const sidebar = [
+        {
+          text: 'Group',
+          items: [
+            { text: 'Intro', link: '/intro' },
+            {
+              text: 'External',
+              link: 'https://example.com/',
+              target: '_self',
+              rel: 'noopener',
+              docFooterText: 'Go external'
+            }
+          ]
+        }
+      ]
+
+      expect(getFlatSideBarLinks(sidebar)).toStrictEqual([
+        {
+          text: 'Intro',
+          link: '/intro',
+          docFooterText: undefined,
+          rel: undefined,
+          target: undefined
+        },
+        {
+          text: 'External',
+          link: 'https://example.com/',
+          docFooterText: 'Go external',
+          rel: 'noopener',
+          target: '_self'
+        }
+      ])
+    })
+  })
+
   describe('hasActiveLink', () => {
     test('checks `SidebarItem`', () => {
       const item = {
diff --git a/src/client/theme-default/components/VPDocFooter.vue b/src/client/theme-default/components/VPDocFooter.vue
index a05ca71a1..45c6e32aa 100644
--- a/src/client/theme-default/components/VPDocFooter.vue
+++ b/src/client/theme-default/components/VPDocFooter.vue
@@ -53,6 +53,8 @@ const showFooter = computed(
           v-if="control.prev?.link"
           class="pager-link prev"
           :href="control.prev.link"
+          :target="control.prev.target"
+          :rel="control.prev.rel"
         >
           <span
             class="desc"
@@ -66,6 +68,8 @@ const showFooter = computed(
           v-if="control.next?.link"
           class="pager-link next"
           :href="control.next.link"
+          :target="control.next.target"
+          :rel="control.next.rel"
         >
           <span
             class="desc"
diff --git a/src/client/theme-default/composables/prev-next.ts b/src/client/theme-default/composables/prev-next.ts
index 494242a6e..d04db4357 100644
--- a/src/client/theme-default/composables/prev-next.ts
+++ b/src/client/theme-default/composables/prev-next.ts
@@ -40,7 +40,15 @@ export function usePrevNext() {
             link:
               (typeof frontmatter.value.prev === 'object'
                 ? frontmatter.value.prev.link
-                : undefined) ?? candidates[index - 1]?.link
+                : undefined) ?? candidates[index - 1]?.link,
+            target:
+              (typeof frontmatter.value.prev === 'object'
+                ? frontmatter.value.prev.target
+                : undefined) ?? candidates[index - 1]?.target,
+            rel:
+              (typeof frontmatter.value.prev === 'object'
+                ? frontmatter.value.prev.rel
+                : undefined) ?? candidates[index - 1]?.rel
           },
       next: hideNext
         ? undefined
@@ -56,11 +64,19 @@ export function usePrevNext() {
             link:
               (typeof frontmatter.value.next === 'object'
                 ? frontmatter.value.next.link
-                : undefined) ?? candidates[index + 1]?.link
+                : undefined) ?? candidates[index + 1]?.link,
+            target:
+              (typeof frontmatter.value.next === 'object'
+                ? frontmatter.value.next.target
+                : undefined) ?? candidates[index + 1]?.target,
+            rel:
+              (typeof frontmatter.value.next === 'object'
+                ? frontmatter.value.next.rel
+                : undefined) ?? candidates[index + 1]?.rel
           }
     } as {
-      prev?: { text?: string; link?: string }
-      next?: { text?: string; link?: string }
+      prev?: { text?: string; link?: string; target?: string; rel?: string }
+      next?: { text?: string; link?: string; target?: string; rel?: string }
     }
   })
 }
diff --git a/src/client/theme-default/support/sidebar.ts b/src/client/theme-default/support/sidebar.ts
index 34dcfcf5e..3660a6746 100644
--- a/src/client/theme-default/support/sidebar.ts
+++ b/src/client/theme-default/support/sidebar.ts
@@ -6,6 +6,8 @@ export interface SidebarLink {
   text: string
   link: string
   docFooterText?: string
+  rel?: string
+  target?: string
 }
 
 type SidebarItem = DefaultTheme.SidebarItem
@@ -75,7 +77,9 @@ export function getFlatSideBarLinks(sidebar: SidebarItem[]): SidebarLink[] {
         links.push({
           text: item.text,
           link: item.link,
-          docFooterText: item.docFooterText
+          docFooterText: item.docFooterText,
+          rel: item.rel,
+          target: item.target
         })
       }