From 5bf835b5074e9567852d552bfb5115c6456026e8 Mon Sep 17 00:00:00 2001 From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> Date: Sun, 10 Aug 2025 19:57:36 +0530 Subject: [PATCH] fix(types): externalize markdown-it types ref: https://github.com/boyum/markdown-it-image-size/issues/888#issuecomment-3172653892 --- package.json | 2 +- pnpm-lock.yaml | 6 +++--- rollup.config.ts | 3 +-- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/package.json b/package.json index 1aa389c5..620c6834 100644 --- a/package.json +++ b/package.json @@ -101,6 +101,7 @@ "@shikijs/core": "^3.9.2", "@shikijs/transformers": "^3.9.2", "@shikijs/types": "^3.9.2", + "@types/markdown-it": "^14.1.2", "@vitejs/plugin-vue": "^6.0.1", "@vue/devtools-api": "^8.0.0", "@vue/shared": "^3.5.18", @@ -134,7 +135,6 @@ "@types/fs-extra": "^11.0.4", "@types/lodash.template": "^4.5.3", "@types/mark.js": "^8.11.12", - "@types/markdown-it": "^14.1.2", "@types/markdown-it-attrs": "^4.1.3", "@types/markdown-it-container": "^2.0.10", "@types/markdown-it-emoji": "^3.0.1", diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml index 684e2568..4a95d328 100644 --- a/pnpm-lock.yaml +++ b/pnpm-lock.yaml @@ -38,6 +38,9 @@ importers: '@shikijs/types': specifier: ^3.9.2 version: 3.9.2 + '@types/markdown-it': + specifier: ^14.1.2 + version: 14.1.2 '@vitejs/plugin-vue': specifier: ^6.0.1 version: 6.0.1(rolldown-vite@7.1.0(@types/node@24.2.1)(esbuild@0.25.8)(jiti@1.21.7)(yaml@2.8.1))(vue@3.5.18(typescript@5.9.2)) @@ -132,9 +135,6 @@ importers: '@types/mark.js': specifier: ^8.11.12 version: 8.11.12 - '@types/markdown-it': - specifier: ^14.1.2 - version: 14.1.2 '@types/markdown-it-attrs': specifier: ^4.1.3 version: 4.1.3 diff --git a/rollup.config.ts b/rollup.config.ts index 2425f34f..7f02b1b8 100644 --- a/rollup.config.ts +++ b/rollup.config.ts @@ -56,8 +56,7 @@ const esmBuild: RollupOptions = { const typesExternal = [ ...external, /\/vitepress\/(?!(dist|node_modules|vitepress)\/).*\.d\.ts$/, - 'source-map-js', - 'fast-glob' + /^markdown-it(?:\/|$)/ ] const dtsNode = dts({