From 1e9a7ac6c478c57d7336e2d7b0392f23659080d3 Mon Sep 17 00:00:00 2001
From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com>
Date: Fri, 8 Jul 2022 15:03:59 +0530
Subject: [PATCH] fix: treat all URI schemes as external (#945) (#946)

---
 src/client/theme-default/components/VPButton.vue | 3 ++-
 src/client/theme-default/components/VPLink.vue   | 3 ++-
 src/client/theme-default/support/utils.ts        | 4 ++--
 src/shared/shared.ts                             | 2 +-
 src/shared/tsconfig.json                         | 2 +-
 5 files changed, 8 insertions(+), 6 deletions(-)

diff --git a/src/client/theme-default/components/VPButton.vue b/src/client/theme-default/components/VPButton.vue
index 0f818d9a..714f3e0c 100644
--- a/src/client/theme-default/components/VPButton.vue
+++ b/src/client/theme-default/components/VPButton.vue
@@ -1,6 +1,7 @@
 <script setup lang="ts">
 import { computed } from 'vue'
 import { normalizeLink } from '../support/utils'
+import { EXTERNAL_URL_RE } from '../../shared'
 
 const props = defineProps<{
   tag?: string
@@ -15,7 +16,7 @@ const classes = computed(() => [
   props.theme ?? 'brand'
 ])
 
-const isExternal = computed(() => props.href && /^[a-z]+:/i.test(props.href))
+const isExternal = computed(() => props.href && EXTERNAL_URL_RE.test(props.href))
 
 const component = computed(() => {
   if (props.tag) {
diff --git a/src/client/theme-default/components/VPLink.vue b/src/client/theme-default/components/VPLink.vue
index bf29e4b5..3984f811 100644
--- a/src/client/theme-default/components/VPLink.vue
+++ b/src/client/theme-default/components/VPLink.vue
@@ -2,13 +2,14 @@
 import { computed } from 'vue'
 import { normalizeLink } from '../support/utils'
 import VPIconExternalLink from './icons/VPIconExternalLink.vue'
+import { EXTERNAL_URL_RE } from '../../shared'
 
 const props = defineProps<{
   href?: string
   noIcon?: boolean
 }>()
 
-const isExternal = computed(() => props.href && /^[a-z]+:/i.test(props.href))
+const isExternal = computed(() => props.href && EXTERNAL_URL_RE.test(props.href))
 </script>
 
 <template>
diff --git a/src/client/theme-default/support/utils.ts b/src/client/theme-default/support/utils.ts
index be2a39c8..5c31e6f0 100644
--- a/src/client/theme-default/support/utils.ts
+++ b/src/client/theme-default/support/utils.ts
@@ -1,15 +1,15 @@
 import { ref } from 'vue'
 import { withBase } from 'vitepress'
+import { EXTERNAL_URL_RE } from '../../shared'
 
 export const HASH_RE = /#.*$/
 export const EXT_RE = /(index)?\.(md|html)$/
-export const OUTBOUND_RE = /^[a-z]+:/i
 
 const inBrowser = typeof window !== 'undefined'
 const hashRef = ref(inBrowser ? location.hash : '')
 
 export function isExternal(path: string): boolean {
-  return OUTBOUND_RE.test(path)
+  return EXTERNAL_URL_RE.test(path)
 }
 
 export function throttleAndDebounce(fn: () => void, delay: number): () => void {
diff --git a/src/shared/shared.ts b/src/shared/shared.ts
index 7db6114e..959d470c 100644
--- a/src/shared/shared.ts
+++ b/src/shared/shared.ts
@@ -10,7 +10,7 @@ export type {
   PageDataPayload
 } from '../../types/shared'
 
-export const EXTERNAL_URL_RE = /^https?:/i
+export const EXTERNAL_URL_RE = /^[a-z]+:/i
 export const APPEARANCE_KEY = 'vitepress-theme-appearance'
 
 // @ts-ignore
diff --git a/src/shared/tsconfig.json b/src/shared/tsconfig.json
index 72027ca4..7a50c068 100644
--- a/src/shared/tsconfig.json
+++ b/src/shared/tsconfig.json
@@ -1,5 +1,5 @@
 {
-  "extends": "../tsconfig.json",
+  "extends": "../../tsconfig.json",
   "compilerOptions": {
     "baseUrl": ".",
     "lib": ["ESNext", "DOM"]