From 0c0232ae5a654641cb7039a729d8bc1c2a3de243 Mon Sep 17 00:00:00 2001
From: Kia Ishii <kia.king.08@gmail.com>
Date: Mon, 30 May 2022 14:44:24 +0900
Subject: [PATCH] fix: show title regardless of logo condition

---
 docs/config/theme-configs.md                          | 2 +-
 src/client/theme-default/components/VPNavBarTitle.vue | 5 ++---
 types/default-theme.d.ts                              | 3 ++-
 3 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/docs/config/theme-configs.md b/docs/config/theme-configs.md
index 58491c79..f7df77f9 100644
--- a/docs/config/theme-configs.md
+++ b/docs/config/theme-configs.md
@@ -37,7 +37,7 @@ export default {
 
 - Type: `string | false`
 
-You can customize this item to replace the default site title (`title` in app config) in nav. When you set `logo`, you can set it to `false` to hide the title.
+You can customize this item to replace the default site title (`title` in app config) in nav. When set to `false`, title in nav will be disabled. Useful when you have `logo` that already contains the site title text.
 
 ```ts
 export default {
diff --git a/src/client/theme-default/components/VPNavBarTitle.vue b/src/client/theme-default/components/VPNavBarTitle.vue
index 46c5593e..c09c06dc 100644
--- a/src/client/theme-default/components/VPNavBarTitle.vue
+++ b/src/client/theme-default/components/VPNavBarTitle.vue
@@ -9,11 +9,10 @@ const { hasSidebar } = useSidebar()
 <template>
   <div class="VPNavBarTitle" :class="{ 'has-sidebar': hasSidebar }">
     <a class="title" href="/">
-      <img v-if="theme.logo" class="logo" :src="theme.logo" :alt="site.title">
+      <img v-if="theme.logo" class="logo" :src="theme.logo">
       <template v-if="theme.siteTitle">{{ theme.siteTitle }}</template>
-      <template v-else-if="theme.siteTitle || !theme.logo">{{ site.title }}</template>
+      <template v-else-if="theme.siteTitle === undefined">{{ site.title }}</template>
     </a>
-
   </div>
 </template>
 
diff --git a/types/default-theme.d.ts b/types/default-theme.d.ts
index 0bf9a48a..2a3dbedc 100644
--- a/types/default-theme.d.ts
+++ b/types/default-theme.d.ts
@@ -8,7 +8,8 @@ export namespace DefaultTheme {
     logo?: string
 
     /**
-     * Custom site title in navbar
+     * Custom site title in navbar. If the value is undefined,
+     * `config.title` will be used.
      */
     siteTitle?: string | false