From d5cdf7ec52814297c9b2db2f3ec511dc46ab2ce4 Mon Sep 17 00:00:00 2001 From: Terence Ho <> Date: Wed, 12 Oct 2022 10:31:33 +0800 Subject: [PATCH] [app/portal][fix] Fix rel and typos --- .../src/components/global/ProductNavigation.tsx | 12 +++++++++--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/apps/portal/src/components/global/ProductNavigation.tsx b/apps/portal/src/components/global/ProductNavigation.tsx index a051d422..74e6dada 100644 --- a/apps/portal/src/components/global/ProductNavigation.tsx +++ b/apps/portal/src/components/global/ProductNavigation.tsx @@ -60,8 +60,12 @@ export default function ProductNavigation({ items, title, titleHref }: Props) { 'block px-4 py-2 text-sm text-slate-700', )} href={child.href} - rel={item.target ? 'noopener noreferrer' : ''} - target={item.target}> + rel={ + !child.href.startsWith('/') + ? 'noopener noreferrer' + : undefined + } + target={child.target}> {child.name} )} @@ -79,7 +83,9 @@ export default function ProductNavigation({ items, title, titleHref }: Props) { isActive ? 'border-b-primary-500' : 'border-b-transparent', )} href={item.href} - rel={item.target ? 'noopener noreferrer' : ''} + rel={ + !item.href.startsWith('/') ? 'noopener noreferrer' : undefined + } target={item.target}> {item.name} {item.target ? (