From 81746fa047d7f37f49d70e9c98ef3dc790a58a07 Mon Sep 17 00:00:00 2001
From: wlren <weilinwork99@gmail.com>
Date: Sun, 9 Oct 2022 00:33:03 +0800
Subject: [PATCH] [questions][chore] refactor and add in todo

---
 .../questions/card/QuestionCard.tsx           |  8 ++--
 .../questions/ui-patch/RadioGroup.tsx         | 44 +++++++++----------
 apps/portal/src/pages/questions/index.tsx     |  2 +-
 3 files changed, 26 insertions(+), 28 deletions(-)

diff --git a/apps/portal/src/components/questions/card/QuestionCard.tsx b/apps/portal/src/components/questions/card/QuestionCard.tsx
index 6b5c3ede..4572567d 100644
--- a/apps/portal/src/components/questions/card/QuestionCard.tsx
+++ b/apps/portal/src/components/questions/card/QuestionCard.tsx
@@ -43,15 +43,15 @@ export type QuestionCardProps = ActionButtonProps &
   UpvoteProps & {
     content: string;
     location: string;
+    receivedCount: number;
     role: string;
-    similarCount: number;
     timestamp: string;
   };
 
 export default function QuestionCard({
   answerCount,
   content,
-  similarCount,
+  receivedCount,
   showVoteButtons,
   showUserStatistics,
   showActionButton,
@@ -63,7 +63,7 @@ export default function QuestionCard({
   location,
 }: QuestionCardProps) {
   return (
-    <article className="flex gap-4 rounded-md border border-slate-300 p-4 bg-white">
+    <article className="flex gap-4 rounded-md border border-slate-300 bg-white p-4">
       {showVoteButtons && (
         <div className="flex flex-col items-center">
           <Button
@@ -110,7 +110,7 @@ export default function QuestionCard({
             <Button
               addonPosition="start"
               icon={EyeIcon}
-              label={`${similarCount} received this`}
+              label={`${receivedCount} received this`}
               size="sm"
               variant="tertiary"
             />
diff --git a/apps/portal/src/components/questions/ui-patch/RadioGroup.tsx b/apps/portal/src/components/questions/ui-patch/RadioGroup.tsx
index 58aa028c..4b6692c4 100644
--- a/apps/portal/src/components/questions/ui-patch/RadioGroup.tsx
+++ b/apps/portal/src/components/questions/ui-patch/RadioGroup.tsx
@@ -11,28 +11,26 @@ export type RadioData = {
 
 export default function RadioGroup({ radioData, onChange }: RadioProps) {
   return (
-    <fieldset
-      onChange={(event: React.FormEvent<HTMLFieldSetElement>) => {
-        const target = event.target as HTMLInputElement;
-        onChange(target.value);
-      }}>
-      <div className="mx-1 space-y-2">
-        {radioData.map((radio) => (
-          <div key={radio.value} className="flex items-center">
-            <input
-              checked={radio.checked}
-              className="text-primary-600 focus:ring-primary-500 h-4 w-4 border-gray-300"
-              type="radio"
-              value={radio.value}
-            />
-            <label
-              className="ml-3 min-w-0 flex-1 text-gray-700"
-              htmlFor={radio.value}>
-              {radio.label}
-            </label>
-          </div>
-        ))}
-      </div>
-    </fieldset>
+    <div className="mx-1 space-y-1">
+      {radioData.map((radio) => (
+        <div key={radio.value} className="flex items-center">
+          <input
+            checked={radio.checked}
+            className="text-primary-600 focus:ring-primary-500 h-4 w-4 border-gray-300"
+            type="radio"
+            value={radio.value}
+            onChange={(event) => {
+              const target = event.target as HTMLInputElement;
+              onChange(target.value);
+            }}
+          />
+          <label
+            className="ml-3 min-w-0 flex-1 text-gray-700"
+            htmlFor={radio.value}>
+            {radio.label}
+          </label>
+        </div>
+      ))}
+    </div>
   );
 }
diff --git a/apps/portal/src/pages/questions/index.tsx b/apps/portal/src/pages/questions/index.tsx
index f6dbef87..c4102a7d 100644
--- a/apps/portal/src/pages/questions/index.tsx
+++ b/apps/portal/src/pages/questions/index.tsx
@@ -222,8 +222,8 @@ export default function QuestionsHomePage() {
                   answerCount={0}
                   content="Given an array of integers nums and an integer target, return indices of the two numbers such that they add up. Given an array of integers nums and an integer target, return indices of the two numbers such that they add up. Given an array of integers nums and"
                   location="Menlo Park, CA"
+                  receivedCount={0}
                   role="Senior Engineering Manager"
-                  similarCount={0}
                   timestamp="Last month"
                   upvoteCount={0}
                 />