From 42825e7eb9f5e09e31b70056b45fc49011017b1d Mon Sep 17 00:00:00 2001 From: Terence Ho <> Date: Wed, 5 Oct 2022 22:07:58 +0800 Subject: [PATCH] [resumes][refactor] Refactor comments form --- .../resumes/comments/CommentsForm.tsx | 51 ++++++++++++++----- .../components/resumes/comments/constants.ts | 5 -- 2 files changed, 39 insertions(+), 17 deletions(-) diff --git a/apps/portal/src/components/resumes/comments/CommentsForm.tsx b/apps/portal/src/components/resumes/comments/CommentsForm.tsx index 7541dfb4..b80af421 100644 --- a/apps/portal/src/components/resumes/comments/CommentsForm.tsx +++ b/apps/portal/src/components/resumes/comments/CommentsForm.tsx @@ -57,18 +57,45 @@ export default function CommentsForm({ onSubmit={onFormSubmit}> {/* TODO: Convert TextInput to TextArea */}
- {COMMENTS_SECTIONS.map(({ label, value, placeholder }) => { - return ( - - ); - })} + + + + + + + + +
diff --git a/apps/portal/src/components/resumes/comments/constants.ts b/apps/portal/src/components/resumes/comments/constants.ts index ebbe89d9..f516bf05 100644 --- a/apps/portal/src/components/resumes/comments/constants.ts +++ b/apps/portal/src/components/resumes/comments/constants.ts @@ -2,27 +2,22 @@ export const COMMENTS_SECTIONS = [ { label: 'General', - placeholder: 'General comments about the resume', value: 'general', }, { label: 'Education', - placeholder: 'Comments about the Education section', value: 'education', }, { label: 'Experience', - placeholder: 'Comments about the Experience section', value: 'experience', }, { label: 'Projects', - placeholder: 'Comments about the Projects section', value: 'projects', }, { label: 'Skills', - placeholder: 'Comments about the Skills section', value: 'skills', }, ];