From 2feec859819c0ffad1d6b76cdf6f4e6ae8791d9e Mon Sep 17 00:00:00 2001
From: Jeff Sieu <jeffsy00@gmail.com>
Date: Sat, 8 Oct 2022 20:51:37 +0800
Subject: [PATCH] [question][chore] add constants.ts

---
 .../components/questions/LandingComponent.tsx | 51 +++--------------
 .../questions/filter/FilterSection.tsx        |  2 +
 apps/portal/src/pages/questions/index.tsx     | 57 ++-----------------
 apps/portal/src/utils/questions/constants.ts  | 50 ++++++++++++++++
 4 files changed, 67 insertions(+), 93 deletions(-)
 create mode 100644 apps/portal/src/utils/questions/constants.ts

diff --git a/apps/portal/src/components/questions/LandingComponent.tsx b/apps/portal/src/components/questions/LandingComponent.tsx
index 211d3ece..bfff29fd 100644
--- a/apps/portal/src/components/questions/LandingComponent.tsx
+++ b/apps/portal/src/components/questions/LandingComponent.tsx
@@ -3,6 +3,12 @@ import { Button, Select } from '@tih/ui';
 
 import NavBar from '~/components/questions/NavBar';
 
+import {
+  COMPANIES,
+  LOCATIONS,
+  QUESTION_TYPES,
+} from '~/utils/questions/constants';
+
 export type LandingQueryData = {
   company: string;
   location: string;
@@ -53,20 +59,7 @@ export default function LandingComponent({
             <Select
               isLabelHidden={true}
               label="Type"
-              options={[
-                {
-                  label: 'Coding',
-                  value: 'coding',
-                },
-                {
-                  label: 'Behavioral',
-                  value: 'behavioral',
-                },
-                {
-                  label: 'System Design',
-                  value: 'system design',
-                },
-              ]}
+              options={QUESTION_TYPES}
               value={landingQueryData.questionType}
               onChange={handleChangeType}
             />
@@ -75,20 +68,7 @@ export default function LandingComponent({
           <Select
             isLabelHidden={true}
             label="Company"
-            options={[
-              {
-                label: 'Google',
-                value: 'google',
-              },
-              {
-                label: 'Meta',
-                value: 'meta',
-              },
-              {
-                label: 'Amazon',
-                value: 'amazon',
-              },
-            ]}
+            options={COMPANIES}
             value={landingQueryData.company}
             onChange={handleChangeCompany}
           />
@@ -96,20 +76,7 @@ export default function LandingComponent({
           <Select
             isLabelHidden={true}
             label="Location"
-            options={[
-              {
-                label: 'Singapore',
-                value: 'singapore',
-              },
-              {
-                label: 'California',
-                value: 'california',
-              },
-              {
-                label: 'Menlo Park',
-                value: 'menlo park',
-              },
-            ]}
+            options={LOCATIONS}
             value={landingQueryData.location}
             onChange={handleChangeLocation}
           />
diff --git a/apps/portal/src/components/questions/filter/FilterSection.tsx b/apps/portal/src/components/questions/filter/FilterSection.tsx
index 5954e669..da3b8c5f 100644
--- a/apps/portal/src/components/questions/filter/FilterSection.tsx
+++ b/apps/portal/src/components/questions/filter/FilterSection.tsx
@@ -9,6 +9,8 @@ export type FilterOptions = {
   value: string;
 };
 
+export type FilterChoices = Array<Omit<FilterOptions, 'checked'>>;
+
 export type FilterSectionProps = {
   label: string;
   onOptionChange: (optionValue: string, checked: boolean) => void;
diff --git a/apps/portal/src/pages/questions/index.tsx b/apps/portal/src/pages/questions/index.tsx
index c93afa9b..92e53c74 100644
--- a/apps/portal/src/pages/questions/index.tsx
+++ b/apps/portal/src/pages/questions/index.tsx
@@ -3,62 +3,17 @@ import { useEffect, useMemo, useState } from 'react';
 
 import QuestionOverviewCard from '~/components/questions/card/QuestionOverviewCard';
 import ContributeQuestionCard from '~/components/questions/ContributeQuestionCard';
-import type { FilterOptions } from '~/components/questions/filter/FilterSection';
 import FilterSection from '~/components/questions/filter/FilterSection';
 import type { LandingQueryData } from '~/components/questions/LandingComponent';
 import LandingComponent from '~/components/questions/LandingComponent';
 import QuestionSearchBar from '~/components/questions/QuestionSearchBar';
 
-type FilterChoices = Array<Omit<FilterOptions, 'checked'>>;
-
-const COMPANIES: FilterChoices = [
-  {
-    label: 'Google',
-    value: 'google',
-  },
-  {
-    label: 'Meta',
-    value: 'meta',
-  },
-];
-
-// Code, design, behavioral
-const QUESTION_TYPES: FilterChoices = [
-  {
-    label: 'Coding',
-    value: 'coding',
-  },
-  {
-    label: 'Design',
-    value: 'design',
-  },
-  {
-    label: 'Behavioral',
-    value: 'behavioral',
-  },
-];
-
-const QUESTION_AGES: FilterChoices = [
-  {
-    label: 'Last month',
-    value: 'last-month',
-  },
-  {
-    label: 'Last 6 months',
-    value: 'last-6-months',
-  },
-  {
-    label: 'Last year',
-    value: 'last-year',
-  },
-];
-
-const LOCATIONS: FilterChoices = [
-  {
-    label: 'Singapore',
-    value: 'singapore',
-  },
-];
+import {
+  COMPANIES,
+  LOCATIONS,
+  QUESTION_AGES,
+  QUESTION_TYPES,
+} from '~/utils/questions/constants';
 
 export default function QuestionsHomePage() {
   const router = useRouter();
diff --git a/apps/portal/src/utils/questions/constants.ts b/apps/portal/src/utils/questions/constants.ts
new file mode 100644
index 00000000..b5c4a23d
--- /dev/null
+++ b/apps/portal/src/utils/questions/constants.ts
@@ -0,0 +1,50 @@
+import type { FilterChoices } from '~/components/questions/filter/FilterSection';
+
+export const COMPANIES: FilterChoices = [
+  {
+    label: 'Google',
+    value: 'google',
+  },
+  {
+    label: 'Meta',
+    value: 'meta',
+  },
+];
+
+// Code, design, behavioral
+export const QUESTION_TYPES: FilterChoices = [
+  {
+    label: 'Coding',
+    value: 'coding',
+  },
+  {
+    label: 'Design',
+    value: 'design',
+  },
+  {
+    label: 'Behavioral',
+    value: 'behavioral',
+  },
+];
+
+export const QUESTION_AGES: FilterChoices = [
+  {
+    label: 'Last month',
+    value: 'last-month',
+  },
+  {
+    label: 'Last 6 months',
+    value: 'last-6-months',
+  },
+  {
+    label: 'Last year',
+    value: 'last-year',
+  },
+];
+
+export const LOCATIONS: FilterChoices = [
+  {
+    label: 'Singapore',
+    value: 'singapore',
+  },
+];