From 2680f7fec679d75efbace486ed0c3bab5a4fc30b Mon Sep 17 00:00:00 2001
From: wlren <weilinwork99@gmail.com>
Date: Mon, 10 Oct 2022 01:31:37 +0800
Subject: [PATCH] [questions][ui] clean up old href

---
 .../questions/card/FullQuestionCard.tsx       | 22 +++++++++----------
 apps/portal/src/utils/questions/withHref.tsx  |  2 +-
 2 files changed, 11 insertions(+), 13 deletions(-)

diff --git a/apps/portal/src/components/questions/card/FullQuestionCard.tsx b/apps/portal/src/components/questions/card/FullQuestionCard.tsx
index 936c6416..f0dc1e4f 100644
--- a/apps/portal/src/components/questions/card/FullQuestionCard.tsx
+++ b/apps/portal/src/components/questions/card/FullQuestionCard.tsx
@@ -15,7 +15,6 @@ type UpvoteProps =
 export type FullQuestionCardProps = UpvoteProps & {
   company: string;
   content: string;
-  href?: string;
   location: string;
   receivedCount: number;
   role: string;
@@ -30,10 +29,9 @@ export default function FullQuestionCard({
   timestamp,
   role,
   location,
-  href,
 }: FullQuestionCardProps) {
   const altText = company + ' logo';
-  const mainCard = (
+  return (
     <article className="flex gap-4 rounded-md border border-slate-300 bg-white p-4">
       {showVoteButtons && <VotingButtons upvoteCount={upvoteCount} />}
       <div className="flex flex-col gap-2">
@@ -56,13 +54,13 @@ export default function FullQuestionCard({
     </article>
   );
 
-  return href ? (
-    <a
-      className="ring-primary-500 rounded-md hover:bg-slate-50 focus:ring-2 focus-visible:outline-none active:bg-slate-100"
-      href={href}>
-      {mainCard}
-    </a>
-  ) : (
-    mainCard
-  );
+  // Return href ? (
+  //   <a
+  //     className="ring-primary-500 rounded-md hover:bg-slate-50 focus:ring-2 focus-visible:outline-none active:bg-slate-100"
+  //     href={href}>
+  //     {mainCard}
+  //   </a>
+  // ) : (
+  //   mainCard
+  // );
 }
diff --git a/apps/portal/src/utils/questions/withHref.tsx b/apps/portal/src/utils/questions/withHref.tsx
index 7fb98976..681f7122 100644
--- a/apps/portal/src/utils/questions/withHref.tsx
+++ b/apps/portal/src/utils/questions/withHref.tsx
@@ -10,7 +10,7 @@ const withHref = <Props extends Record<string, unknown>>(
 
     return (
       <a
-        className="ring-primary-500 rounded-md hover:bg-slate-50 focus:ring-2 focus-visible:outline-none active:bg-slate-100"
+        className="ring-primary-500 rounded-md focus:ring-2 focus-visible:outline-none active:bg-slate-100"
         href={href}>
         <Component {...(others as unknown as Props)} />
       </a>