From 23bd215ea846fc16d6654daced10c9eebbab1d78 Mon Sep 17 00:00:00 2001
From: wlren <weilinwork99@gmail.com>
Date: Sat, 8 Oct 2022 17:15:10 +0800
Subject: [PATCH] [questions][ui] refactor bottom contribute bar

---
 .../questions/ContributeQuestionForm.tsx      | 36 ++++++++++++++++---
 .../questions/ContributeQuestionModal.tsx     | 29 +--------------
 2 files changed, 33 insertions(+), 32 deletions(-)

diff --git a/apps/portal/src/components/questions/ContributeQuestionForm.tsx b/apps/portal/src/components/questions/ContributeQuestionForm.tsx
index 3e1a0108..a35e1335 100644
--- a/apps/portal/src/components/questions/ContributeQuestionForm.tsx
+++ b/apps/portal/src/components/questions/ContributeQuestionForm.tsx
@@ -1,5 +1,5 @@
 import type { ChangeEvent } from 'react';
-import { useCallback } from 'react';
+import { useCallback, useState } from 'react';
 import { useForm } from 'react-hook-form';
 import {
   BuildingOffice2Icon,
@@ -7,7 +7,9 @@ import {
   QuestionMarkCircleIcon,
   UserIcon,
 } from '@heroicons/react/24/outline';
-import { HorizontalDivider, TextArea, TextInput } from '@tih/ui';
+import { Button, HorizontalDivider, TextArea, TextInput } from '@tih/ui';
+
+import Checkbox from './ui-patch/Checkbox';
 
 export type ContributeQuestionData = {
   company: string;
@@ -19,15 +21,20 @@ export type ContributeQuestionData = {
 };
 
 export type ContributeQuestionFormProps = {
+  onDiscard: () => void;
   onSubmit: (data: ContributeQuestionData) => void;
 };
 
 export default function ContributeQuestionForm({
   onSubmit,
+  onDiscard,
 }: ContributeQuestionFormProps) {
   const { register: formRegister, handleSubmit } =
     useForm<ContributeQuestionData>();
-
+  const [canSubmit, setCanSubmit] = useState<boolean>(false);
+  const handleCheckSimilarQuestions = (checked: boolean) => {
+    setCanSubmit(checked);
+  };
   const register = useCallback(
     (...args: Parameters<typeof formRegister>) => {
       const { onChange, ...rest } = formRegister(...args);
@@ -98,7 +105,28 @@ export default function ContributeQuestionForm({
             {...register('position')}
           />
         </div>
-        {/* <Button label="Contribute" type="submit" variant="primary" /> */}
+      </div>
+      <div className="bg-primary-50 px-4 py-3 sm:flex sm:flex-row sm:justify-between sm:px-6">
+        <div className="mb-1 flex">
+          <Checkbox
+            checked={canSubmit}
+            label="I have checked that my question is new"
+            onChange={handleCheckSimilarQuestions}></Checkbox>
+        </div>
+        <div className=" flex gap-x-2">
+          <button
+            className="inline-flex w-full justify-center rounded-md border border-gray-300 bg-white px-4 py-2 text-base font-medium text-gray-700 shadow-sm hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm"
+            type="button"
+            onClick={onDiscard}>
+            Discard
+          </button>
+          <Button
+            className="bg-primary-600 hover:bg-primary-700 focus:ring-primary-500 inline-flex w-full justify-center rounded-md border border-transparent px-4 py-2 text-base font-medium text-white shadow-sm focus:outline-none focus:ring-2 focus:ring-offset-2 disabled:bg-gray-400 sm:ml-3 sm:w-auto sm:text-sm"
+            disabled={!canSubmit}
+            label="Contribute"
+            type="submit"
+            variant="primary"></Button>
+        </div>
       </div>
     </form>
   );
diff --git a/apps/portal/src/components/questions/ContributeQuestionModal.tsx b/apps/portal/src/components/questions/ContributeQuestionModal.tsx
index 09971788..8240fb71 100644
--- a/apps/portal/src/components/questions/ContributeQuestionModal.tsx
+++ b/apps/portal/src/components/questions/ContributeQuestionModal.tsx
@@ -4,7 +4,6 @@ import { Dialog, Transition } from '@headlessui/react';
 
 import ContributeQuestionForm from './ContributeQuestionForm';
 import DiscardDraftModal from './DiscardDraftModal';
-import Checkbox from './ui-patch/Checkbox';
 
 export type ContributeQuestionModalProps = {
   contributeState: boolean;
@@ -15,11 +14,7 @@ export default function ContributeQuestionModal({
   contributeState,
   setContributeState,
 }: ContributeQuestionModalProps) {
-  const [canSubmit, setCanSubmit] = useState<boolean>(false);
   const [isDiscardOpen, setIsDiscardOpen] = useState<boolean>(false);
-  const handleCheckSimilarQuestions = (checked: boolean) => {
-    setCanSubmit(checked);
-  };
 
   const handleDiscardDraft = () => {
     // eslint-disable-next-line no-console
@@ -70,6 +65,7 @@ export default function ContributeQuestionModal({
                         </Dialog.Title>
                         <div className="mt-2">
                           <ContributeQuestionForm
+                            onDiscard={() => setIsDiscardOpen(true)}
                             onSubmit={(data) => {
                               // eslint-disable-next-line no-console
                               console.log(data);
@@ -79,29 +75,6 @@ export default function ContributeQuestionModal({
                       </div>
                     </div>
                   </div>
-                  <div className="bg-primary-50 px-4 py-3 sm:flex sm:flex-row sm:justify-between sm:px-6">
-                    <div className="mb-1 flex">
-                      <Checkbox
-                        checked={canSubmit}
-                        label="I have checked that my question is new"
-                        onChange={handleCheckSimilarQuestions}></Checkbox>
-                    </div>
-                    <div className=" flex gap-x-2">
-                      <button
-                        className="inline-flex w-full justify-center rounded-md border border-gray-300 bg-white px-4 py-2 text-base font-medium text-gray-700 shadow-sm hover:bg-gray-50 focus:outline-none focus:ring-2 focus:ring-indigo-500 focus:ring-offset-2 sm:mt-0 sm:ml-3 sm:w-auto sm:text-sm"
-                        type="button"
-                        onClick={() => setIsDiscardOpen(true)}>
-                        Discard
-                      </button>
-                      <button
-                        className="bg-primary-600 hover:bg-primary-700 focus:ring-primary-500 inline-flex w-full justify-center rounded-md border border-transparent px-4 py-2 text-base font-medium text-white shadow-sm focus:outline-none focus:ring-2 focus:ring-offset-2 disabled:bg-gray-400 sm:ml-3 sm:w-auto sm:text-sm"
-                        disabled={!canSubmit}
-                        type="button"
-                        onClick={() => setContributeState(false)}>
-                        Contribute
-                      </button>
-                    </div>
-                  </div>
                 </Dialog.Panel>
               </Transition.Child>
             </div>