From 00bad17f360d5cbb5a5364d2839513d073ff7b1b Mon Sep 17 00:00:00 2001 From: Keane Chan Date: Sun, 23 Oct 2022 16:27:34 +0800 Subject: [PATCH] [resumes][refactor] clean up submit form --- .../submit-form/SubmissionGuidelines.tsx | 11 +- apps/portal/src/pages/resumes/submit.tsx | 104 +++++++++--------- 2 files changed, 57 insertions(+), 58 deletions(-) diff --git a/apps/portal/src/components/resumes/submit-form/SubmissionGuidelines.tsx b/apps/portal/src/components/resumes/submit-form/SubmissionGuidelines.tsx index 9220adb7..96249537 100644 --- a/apps/portal/src/components/resumes/submit-form/SubmissionGuidelines.tsx +++ b/apps/portal/src/components/resumes/submit-form/SubmissionGuidelines.tsx @@ -1,22 +1,21 @@ export default function SubmissionGuidelines() { return ( -
+

Submission Guidelines

- Before you submit, please review and acknolwedge our + Before you submit, please review and acknowledge our submission guidelines stated below.

• - Ensure that you do not divulge any of your - personal particulars. + Ensure that you do not divulge any of your{' '} + personal particulars.

• - Ensure that you do not divulge any + Ensure that you do not divulge any{' '} - {' '} company's proprietary and confidential information . diff --git a/apps/portal/src/pages/resumes/submit.tsx b/apps/portal/src/pages/resumes/submit.tsx index 2a04ca4e..06915a00 100644 --- a/apps/portal/src/pages/resumes/submit.tsx +++ b/apps/portal/src/pages/resumes/submit.tsx @@ -46,6 +46,8 @@ type IFormInput = { title: string; }; +type InputKeys = keyof IFormInput; + type InitFormDetails = { additionalInfo?: string; experience: string; @@ -218,6 +220,10 @@ export default function SubmitResumeForm({ } }, [errors?.file, invalidFileUploadError]); + const onValueChange = (section: InputKeys, value: string) => { + setValue(section, value.trim(), { shouldTouch: false }); + }; + return ( <> @@ -269,7 +275,7 @@ export default function SubmitResumeForm({ required={true} onChange={(val) => setValue('title', val)} /> -

+
- -
-

- PDF up to {FILE_SIZE_LIMIT_MB}MB +

+
+ {resumeFile == null ? ( + + ) : ( +

+ {resumeFile.name}

+ )} +
+
+

+ PDF up to {FILE_SIZE_LIMIT_MB}MB +

- {fileUploadError && ( -

{fileUploadError}

- )}
- + {fileUploadError && ( +

{fileUploadError}

+ )} +
)} {/* Additional Info Section */}