History

Rohit Nair P 4879f9da99 fix: improve duplicate module import error message (#18016 ) ## Description While investigating the compiler analysis phase for errors or missing lines, I located an explicit `TODO fix the message here` comment in the source code (`packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js`). ### Triggering Code ```svelte <script module> import { foo } from './somewhere.js'; </script> <script> let foo = 'conflict'; // Triggers the duplicate module import error </script> ``` ## The Bug When a component author creates a local `let` declaration in the instance `<script>` block that shadows a variable imported in the `<script module>` block, the compiler emits a `declaration_duplicate_module_import` error. However, the error message text was misleading. It stated: ```diff - Cannot declare a variable with the same name as an import inside `<script module>` + Cannot declare a variable with the same name as an import from `<script module>` ``` This incorrectly implies that the duplicate declaration itself is happening inside the module script block, rather than colliding with an import from that block. ## Changes Made \| Action \| Target (File / Function) \| Description \| \| :--- \| :--- \| :--- \| \| Template Fix \| `packages/svelte/messages/compile-errors/script.md` \| Changed "inside" to "from" to accurately reflect the nature of the shadow collision. \| \| Regenerated Errors \| `packages/svelte/src/compiler/errors.js` \| Ran `pnpm generate` to apply the updated markdown template into the dictionary list. \| \| Removed TODO \| `ensure_no_module_import_conflict` function \| Removed the original `// TODO fix the message here` notation from the validator. \| \| Test Adjustments \| `illegal-variable-declaration/errors.json` \| Updated the validator test suite snapshots to assert against the correct error message format. \| ## Validation Results * The error correctly throws when a user replicates this component structure. * Vitest suite `tests/validator/test.ts` successfully asserts the new, clearer message. --- ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` # THANK YOU		7 months ago
..
README.md	chore: setup changesets (#8668 )	3 years ago
config.json	chore: enter changeset prerelease mode	3 years ago
eight-trees-occur.md	fix: correctly handle bindings on the server (#18009 )	7 months ago
four-beers-like.md	fix: prevent hydration error on async `{@html ...}` (#17999 )	7 months ago
lucky-animals-take.md	fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` (#18015 )	7 months ago
quiet-cats-purr.md	fix: improve duplicate module import error message (#18016 )	7 months ago
yellow-hairs-laugh.md	fix: reschedule new effects in prior batches (#18021 )	7 months ago

README.md

Changesets

Hello and welcome! This folder has been automatically generated by @changesets/cli, a build tool that works with multi-package repos, or single-package repos to help you version and publish your code. You can find the full documentation for it in our repository

We have a quick list of common questions to get you started engaging with this project in our documentation