196d7e41b1
chore: simplify add_locations ( #11757 )
...
* chore: simplify add_locations
* tiny tweak
1 year ago
3dfa343ea2
Version Packages (next) ( #11753 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
7dacf2c4d4
fix: use svg methods for updating svg attributes too ( #11755 )
...
Closes #11746
we were using the svg methods for every child of svg but not for svg itself
1 year ago
d15fd9556f
chore: better invalid attribute message ( #11754 )
...
* simplify code
* replace error code and message
* update message, update tests
1 year ago
8459098c05
chore: simplify effect.dom stuff ( #11752 )
1 year ago
5765752d78
fix: throw on invalid attribute expressions ( #11736 )
...
In runes mode only to prevent a breaking change solely from upgrading to Svelte 5
Closes #11734
1 year ago
ba429fd2f1
fix: don't use console.trace inside dev warnings ( #11744 )
...
Chrome does include a trace for warnings, Firefox does not, but the vast majority of devs uses Chromium-based browsers for dev, so this reduces noise
1 year ago
e73b133b66
fix: don't warn on link without href if aria-disabled ( #11737 )
...
Also don't warn on a tag without a href attribute and link role
fixes #11733
1 year ago
50cc8a4848
chore: more non-essential changes from #11690 ( #11750 )
1 year ago
329c10eb6c
chore: update noscript test ( #11749 )
1 year ago
b87fd61729
chore: DRY out namespace template code ( #11748 )
...
* chore: DRY out namespace template code
* Update packages/svelte/src/internal/client/dom/template.js
1 year ago
152961a649
Version Packages (next) ( #11745 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
fe51cde1fa
breaking: event handlers + bindings now yield effect updates ( #11706 )
...
* breaking: delegated event handlers now yield effect updates
* tweak
* refactor
* refactor
* yield binding change events
* handle input event bindings
* more bindings
* more bindings
* more tests
* more tests
* address feedback
* address feedback
1 year ago
3498df842b
Version Packages (next) ( #11743 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
a074734ba7
fix: ensure we clear down each block opening anchors from document ( #11740 )
...
* fix: ensure we clear down each block opening anchors from document
* fix: ensure we clear down each block opening anchors from document
1 year ago
401c8b23be
chore: simplify internal DOM operations ( #11741 )
...
* chore: simplify internal DOM operations
* chore: simplify internal DOM operations
* chore: simplify internal DOM operations
1 year ago
44115840bd
chore: cleanup more tests ( #11738 )
...
remove awaits in favor of flushSync
1 year ago
4f9096a5a8
chore: delegate input event ( #11732 )
...
We didn't delegate the input event back when we were also delegating `on:x` events, because it messes up the event/bindings/actions order. Since we're only doing that for `onx` event attributes now that reason is obsolete and we can start delegating it.
1 year ago
c3489eb5de
Version Packages (next) ( #11714 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
4a3f7ac257
fix: improved checked/value handling ( #11726 )
...
* fix: improved checked/value handling
* tweak
1 year ago
77f91459b6
fix: update value like attributes in a separate template_effect ( #11720 )
...
* fix: update value like attributes in a separate template_effect
* chore: remove unnecessary commented code
* chore: add test for spread values
1 year ago
c21f019a4b
chore: speedup hydration around input and select values ( #11717 )
...
* chore: speedup hydration around input and select values
* use idle tasks to do the work
---------
Co-authored-by: Dominic Gannaway <dg@domgan.com>
1 year ago
d590cd8bea
fix: ignore value attribute on select during SSR ( #11724 )
...
The value attribute on select elements does nothing - it does not influence the initial value (in SSR that's the job of the `selected` attribute on an option element), updating it does not influence the current value either. Instead of rendering it out and then removing it on hydration (which is costly because the mutation causes work) we just don't render it in SSR.
No test/changeset because no change in behavior.
1 year ago
6d2f1a48b4
fix: allow comments after last selector in css ( #11723 )
...
Fixes #11721
1 year ago
0128df33da
fix: don't add scoping modifier to nesting selectors ( #11713 )
1 year ago
09addad9ae
fix: improve handling of unowned derived signal ( #11712 )
1 year ago
fba6b5676b
Version Packages (next) ( #11663 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
f48001ac63
fix: check for invalid bindings on window and document ( #11676 )
...
Fixes #11673
1 year ago
b788b72862
fix: migrate derivations without semicolons ( #11704 )
...
Closes #11689
1 year ago
02520aea48
better tooltips in playground ( #11705 )
...
* better tooltips in playground
* update some tests that a drive-by fix broke
1 year ago
a5fd28a14b
fix: inline pointer events now correctly work in Chrome ( #11695 )
...
* fix: inline pointer events now correctly work in Chrome
* fix more
1 year ago
e6f8e95199
chore: tidy up tests to use flushSync ( #11703 )
1 year ago
43d2f750b6
Revert "chore: consistent nextSibling usage ( #11694 )" ( #11696 )
...
This reverts commit f3dbfc91d6
1 year ago
f3dbfc91d6
chore: consistent nextSibling usage ( #11694 )
...
* chore: consistent nextSibling usage
* cleanup
1 year ago
1784026843
fix: don't require commas between warnings in legacy mode ( #11669 )
...
also add commas in migration
closes #11666
1 year ago
c70533a5a7
fix: more efficient spread attributes in SSR output ( #11660 )
...
* fix: more efficient spread attributes in SSR output
* more tweaks
1 year ago
62e2647c8a
Version Packages (next) ( #11656 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
c29b74669d
feat: migrate `<svelte:element this="div">` ( #11659 )
1 year ago
110a5a852f
fix: robustify `bind:scrollX/Y` binding ( #11655 )
...
- we were scrolling to the given value, which we shouldn't for accessibility reasons (Svelte 4 didn't do it either)
- we need to notify of the value 0 if there's no scroll (https://github.com/sveltejs/svelte/issues/11623#issuecomment-2113495573 )
1 year ago
d288735fa8
breaking: disallow string literal values in `<svelte:element this="...">` ( #11454 )
...
* breaking: disallow string literal values in `<svelte:element this="...">`
* note breaking change
* Update sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
* prettier
* make invalid `<svelte:element this>` a warning instead of an error (#11641 )
* make it a warning instead of an error
* format
---------
Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>
1 year ago
ade6b6e480
chore: add css regression test ( #11658 )
...
closes #9207
1 year ago
c2f75dc7ba
fix: use coarse-grained updates for derived expressions in legacy mode ( #11652 )
...
fixes #11648
Also deduplicates the code a bit
1 year ago
54083fb9cc
fix: replay load and error events on load during hydration ( #11642 )
...
* fix: replay load and error events on load during hydration
* oops
* fix replacement logic
* make less evasive
* address feedback
* address feedback
* address feedback
* Update packages/svelte/src/internal/client/dom/elements/events.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* address feedback
* Update packages/svelte/src/internal/client/dom/elements/attributes.js
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* Update packages/svelte/src/internal/client/dom/elements/attributes.js
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* address more feedback
* address more feedback
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
7b9fad4b0e
chore: remove `handle_compile_error` ( #11639 )
...
We don't need the awkward handle_compile_error stuff any more, because the relevant information now lives in state.js
1 year ago
2ebb277be7
feat: more information when hydration fails ( #11649 )
...
In the case of an invalid child element, we already get information about the parent and the child, but in other cases where a mismatch could occur you're pretty much on your own.
This adds a bit more context to hydration_mismatch warnings — 'The error occurred near ...'
1 year ago
019b26b775
Version Packages (next) ( #11645 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
dc9b0d08c1
feat: add rootDir option and set __svelte_meta.file like in svelte4 ( #11627 )
...
* feat: add rootDir option and set __svelte_meta.file like in svelte4
* Update packages/svelte/src/compiler/validate-options.js
* update tests
* centralise logic
* fix
* note to self
* Apply suggestions from code review
* lint
* one dollar towards the windows backslash bugfix foundation please
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
c131e6f494
Revert "chore: ensure we use event system code paths throughout" ( #11644 )
...
* Revert "chore: ensure we use event system code paths throughout (#11640 )"
This reverts commit c00d8245ee
1 year ago
3bf68b4765
fix: make messages more consistent ( #11643 )
1 year ago
053159bf0b
fix: avoid state_referenced_locally warning within type annotations ( #11638 )
...
* fix: avoid state_referenced_locally warning within type annotations
* better fix
* prettier
* better fix
* fix
* fix
* fix
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
c00d8245ee
chore: ensure we use event system code paths throughout ( #11640 )
1 year ago
ec25208ba4
Version Packages (next) ( #11617 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
4365562228
fix: deduplicate children prop from default slot ( #10800 )
...
* feat: provide isSnippet type, deduplicate children prop from default slot
fixes #10790
part of #9774
* fix ce bug
* remove isSnippet type, adjust test
* fix types
* revert unrelated changes
* remove changeset
* enhance test
* fix
* fix
* fix
* fix, different approach without needing symbol
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
cac8630de6
chore: use CustomEvent constructor instead of deprecated createEvent method ( #11629 )
...
* chore: use CustomEvent constructor instead of deprecated createEvent method
* while we're here...
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
4bedd0e4fb
feat: error on imports to `svelte/internal/*` ( #11632 )
...
* feat: error on imports to `svelte/internal/*`
closes #11622
* regenerate
* also error on svelte/internal
1 year ago
4f8bba2f80
fix: cleanup array prototype monkeypatching ( #11634 )
...
* fix: cleanup array prototype monkeypatching
* Update packages/svelte/src/internal/client/dev/equality.js
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
e5e7ec2404
fix: better handle img loading attribute ( #11635 )
...
* fix: better handle img loading attribute
* better fix
* switch to symbol
1 year ago
6f28e41b6d
chore: tidy up scrolling code logic ( #11630 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
1 year ago
87a420f64d
feat: error when snippet shadows a prop ( #11631 )
...
Closes #11603
1 year ago
573b9f1d74
fix: adjust unknown code warning offset ( #11621 )
...
They were the wrong way around
fixes #11612
1 year ago
7ef686f8ee
feat: provide $state warnings for accidental equality ( #11610 )
...
* feat: provide $state warnings for accidental equality
* tune
* tune
* tune
* adjust test
* fix treeshaking
* fix bugs
* fix bugs
* refactor
* revert test changes
* tune
* tune
* tune
* tune
* fix up
* fix
* remove if(DEV) stuff
* use console.trace, like we do for ownership warnings
* tweak
* tweak message, simplify logic
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
f488a6e84a
feat: add $state.is rune ( #11613 )
...
* feat: add $state.is rune
* fix type
* tweak docs
* may as well update the test case to match the docs
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
1087e6fb54
chore: improve SSR invalid element error message ( #11585 )
...
* chore: improve SSR invalid element error message
* move push_element and pop_element into new dev.js file
* pass location info, remove unnecessary if (DEV) block
* use full filename, basename is not very helpful. also, current_component is guaranteed to not be null
* current_element is guaranteed to not be null in pop_element
* tweaks
* remove message prefix - redundant when filenames are included
* add line/column
* make message more concise
* reduce indirection
* only print message once
* update test
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
e97bc79f02
Version Packages (next) ( #11608 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
fd437024f5
fix: add missing `modernAst` in `validate_component_options` ( #11542 )
1 year ago
faced066bd
feat: migrate warnings ( #11607 )
...
Also contains a changeset for the previous work because we forgot that. Also added more code mappings.
1 year ago
2bc39b1de2
chore: better ignore code handling ( #11606 )
...
Instead of hacking an ignores array onto each node (and possibly degrading perf a bit because the object shape is mutated) we keep track of ignores in a stack. The new approach also avoids the indirection the old one had to do because the new approach looks upwards (checking if parent is a fragment) instead of iterating the children (checking for comments in them).
As a bonus unknown code warnings are now in order (line-column-wise) with the other warnings. Also fixes #11482 because text nodes of all shapes are ok
1 year ago
ac7709f65c
chore: dedupe `getLocator` calls ( #11600 )
...
...by introducing global compiler state that is reset between iterations
1 year ago
5cb432b7bd
feat: warn on unknown warning codes in runes mode ( #11549 )
...
Related to #11414
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
5e9428a65d
Version Packages (next) ( #11580 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
b964a4ce1d
fix: improve ff handling of lazy images ( #11593 )
...
* fix: improve ff handling of lazy images
* tune
* tune
* tune
* tune
* tune
1 year ago
b212b17385
fix: skip deriveds for props with known safe calls ( #11595 )
1 year ago
d408d20cdd
fix: replicate Svelte 4 props update detection in legacy mode ( #11577 )
...
* fix: replicate Svelte 4 props update detection in legacy mode
fixes #11448 by wrapping props in deriveds
* fix test
* Update packages/svelte/src/compiler/phases/3-transform/client/utils.js
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* dedicated flag
* prettier
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
a0bdac8cd7
fix: correctly handle falsy values of style directives in SSR mode ( #11583 )
...
fixes #11044
1 year ago
dc16668773
chore: improve runtime overhead of creating comment templates ( #11591 )
...
* chore: improve runtime overhead of creating comment templates
* Update packages/svelte/src/internal/client/dom/template.js
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
* changeset
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
81517a506c
fix: allow for non optional chain call expression in render ( #11578 )
1 year ago
61238d0fd3
Version Packages (next) ( #11564 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
9c680f1030
chore: optimise effects ( #11569 )
...
* optimise effects
* tweak
* don't allocate array unnecessarily
* filter_flags appears to be unnecessary?
* lint
* tweak
* simplify (#11570 )
* changeset
1 year ago
5497b3d0bc
fix: ensure all effect cleanup functions are untracked ( #11567 )
...
* fix: ensure all effect cleanup functions are untracked
* add test
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
f6e87772cb
Revert "fix: ensure Svelte action destroy effects are untracked ( #11562 )" ( #11568 )
...
This reverts commit e49f1f7f11
1 year ago
e49f1f7f11
fix: ensure Svelte action destroy effects are untracked ( #11562 )
...
* fix: unesure Svelte action destroy effects are untracked
* fix: unesure Svelte action destroy effects are untracked
1 year ago
816335f906
Version Packages (next) ( #11561 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
643bbf2be2
Better process effects ( #11560 )
...
* fix: improve internal mechanism for handling process_effects
1 year ago
4cadd07676
Version Packages (next) ( #11559 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
a3702e8171
fix: adjust heuristics for effect_update_depth_exceeded ( #11558 )
...
* fix: adjust heuristics for effect_update_depth_exceeded
* fix: adjust heuristics for effect_update_depth_exceeded
* fix: further adjust heuristics for effect_update_depth_exceeded
1 year ago
18f61a575f
Version Packages (next) ( #11554 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
43ad72b1ce
fix: adjust heuristics for effect_update_depth_exceeded ( #11557 )
...
* fix: adjust heuristics for effect_update_depth_exceeded
* fix: adjust heuristics for effect_update_depth_exceeded
1 year ago
597715ff98
fix: improved $inspect handling of reactive Map/Set/Date ( #11553 )
1 year ago
7e9b109de6
Version Packages (next) ( #11541 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
c450cdb7a7
fix: better support for lazy img elements ( #11545 )
...
* fix: better support for lazy img elements
* tune
* fix
1 year ago
fcc72ae2f3
feat: provide better error messages in DEV ( #11526 )
...
* feat: provide better error messages in DEV
* fix stuff
* fix stuff
* fix tests
* fix
* assert.include results in better errors on mismatches
* remove indentation
* tweak
* rename
* fix issues
* more fixes
* more fixes
* neaten up stack trace
* Update packages/svelte/src/internal/client/reactivity/effects.js
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* Update packages/svelte/src/internal/client/runtime.js
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* address feedback
* lint
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
641e411cf1
fix: ensure spread events are always added ( #11535 )
...
In edge cases it may happen that set_attributes is re-run before the effect is executed. In that case the render effect which initiates this re-run will destroy the inner effect and it will never run. But because next and prev may have the same keys, the event would not get added again and it would get lost. We prevent this by using a root effect.
The added test case doesn't fail for some reason without this fix, but it does fail when you test it out manually, so I still added it.
Found through https://github.com/sveltejs/svelte/issues/10359#issuecomment-2101167524
1 year ago
31f8fea22d
fix: don't warn on writes to `$state` ( #11540 )
...
fixes #10905
1 year ago
65223363e9
fix: handle falsy prop aliases correctly ( #11539 )
...
fixes #10854
1 year ago
4ea8a5e36b
chore: add derived effect ownership tests ( #11538 )
...
* chore: add derived effect ownership tests
* chore: add derived effect ownership tests
1 year ago
f219c795f4
fix: check for falsy values in spread ( #11388 )
...
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
f70c0370be
chore: deduplicate code ( #11534 )
1 year ago
59f4feb4d8
Version Packages (next) ( #11518 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
8742823e39
fix: make `$effect.active()` true when updating deriveds ( #11500 )
...
* fix: make `$effect.active()` true when updating deriveds
* WIP
* this seems to work?
* prevent effects being created in unowned deriveds
* update test
* fix issue
---------
Co-authored-by: Dominic Gannaway <dg@domgan.com>
1 year ago
30caaef2e5
fix: improve behaviour of unowned derived signals ( #11521 )
1 year ago
70419daf5f
fix: use snippet as parent element of snippets childrens in validator ( #11463 )
...
* fix: use snippet as parent element of snippets childrens in validator
* Update packages/svelte/src/compiler/phases/2-analyze/validation.js
* Update .changeset/wet-pears-remain.md
---------
Co-authored-by: Rich Harris <hello@rich-harris.dev>
1 year ago
4fb4365567
Version Packages (next) ( #11503 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
b1b2dddc3b
feat: add support for svelte inspector (alternative approach) ( #11514 )
...
* mostly working
* fix
* fix
* handle dynamic elements too
* add __svelte_meta to prototype
* changeset
* cheeky fix
1 year ago
3c756cf14c
chore: use clear_text_content in more areas ( #11512 )
1 year ago
f543856cc3
fix: skip AST analysis of TypeScript AST nodes ( #11513 )
...
* fix: skip AST analysis of TypeScript AST nodes
* fix: skip AST analysis of TypeScript AST nodes
* lint
1 year ago
28f3755e40
fix: use acceptExports to support partial hmr ( #11453 )
...
* fix: use acceptExports to support partial hmr
* fix: add condition to only use acceptExports when it is available
* fix: update test snapshot
* fix: format
1 year ago
0cf6d56ffe
fix: increment and decrement edge case ( #11506 )
...
* fix: increment and decrement edge case
* fix/simplify test
* simplify
* Apply suggestions from code review
* golf
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Rich Harris <hello@rich-harris.dev>
1 year ago
8318b3d142
Version Packages (next) ( #11474 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
dca8861c5a
feat: better error for `bind:this` legacy API usage ( #11498 )
1 year ago
85d680582b
Fix: bind:scroll resets scroll state ( #11469 )
...
* Fixed: bind:scroll resets scroll state
* failing test
* bail if value is undefined
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
6bd6f0971b
fix: ensure derived is detected as dirty correctly ( #11496 )
...
Deriveds where under certain conditions not detected as dirty correctly. The reason is that a transitive check_dirtiness call could update the flag of a derived, even if the condition doesn't ulimately result to true. That's why the check for "is now dirty" needs to be moved out of the inner if block.
Fixes #11481
This may also fix a yet undetected overfiring bug in the "is unowned" case because the previous inner "is now dirty?" check didn't take unowned into account.
1 year ago
d86b05279f
fix: prevent false positive ownership warning ( #11490 )
...
fixes #11483
We need to keep track of the component function similar to how we keep track of the component context, so that effects etc have the correct one associated
1 year ago
3e1f82b8c4
fix: additional check for component on destroy ( #11488 )
...
fixes #10454
1 year ago
fa3e98e8c6
fix: allow to access private fields after `this` reassignment ( #11487 )
...
Fixes #11480
Fixes #11476
1 year ago
0d5a32d5f7
typo
1 year ago
34079a0ec5
fix: restore value after attribute removal during hydration ( #11465 )
...
Fix #11457
1 year ago
272ffc5520
Version Packages (next) ( #11440 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
c0e91a7490
Version Packages (next) ( #11433 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
9c1a5063b9
fix: adjust order of `derived` function definition overloads ( #11426 )
...
Turns out the order is crucial for not getting a type error
fixes #11415
1 year ago
9c5a9d8e20
fix: mark function properties on runes as deprecated for better intellisense ( #11439 )
...
Ensures that IDEs will order the to the bottom so that the rune variants are on top, better visible
closes #11437
1 year ago
6e5ab2e678
fix: prevent ownership validation from infering with component context ( #11438 )
...
Ownership validation had a false positive when rendering a component as slotted content of another component. To fix this, #11401 did set the current component context to the context the snippet was declared in, not to the context it is rendered in. This was flawed because it means that component context was altered in a way that setContext/getContext failed because the parent chain was incorrect. This fixes that by introducing a separate global (dev time only) which tracks the component function the ownership needs.
fixes #11429
1 year ago
dfb30aaddd
fix: only warn about non-reactive state in runes mode ( #11434 )
...
Fixes #11269
1 year ago
1f9ad03287
fix: ensure $inspect untracks inspected object ( #11432 )
1 year ago
fcdad4c166
Version Packages (next) ( #11410 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
b4968584df
fix: improve html escaping of element attributes ( #11411 )
...
escape `<` because there's an edge case scenario where a script inside an attribute of a noscript is parsed differently
1 year ago
a038d49f78
fix: rework bindable types strategy ( #11420 )
...
Instead of using types that declare whether or not a type is bindable directly as part of the property, we're introducing a new for-types-only field to `SvelteComponent`: `$$bindings`, which is typed as the keys of the properties that are bindable (string by default, i.e. everything's bindable; for backwards compat). language-tools can then produce code that assigns to this property which results in an error we can display if the binding is invalid
closes #11356
1 year ago
17b2f6215d
fix: `event.currentTarget` always being equal to `event.target` ( #11419 )
...
fixes #11328
1 year ago
edefc846c3
fix: set correct component context when rendering snippets ( #11401 )
...
fixes #11399
1 year ago
f64d16931d
fix: detect style shorthands as stateful variables in legacy mode ( #11421 )
...
Fixes #11417
1 year ago
0f4f3d7df0
fix: improve unowned derived signal behaviour ( #11408 )
1 year ago
4d051962f3
chore: tidy up ( #11404 )
1 year ago
9e1e1b45e8
Version Packages (next) ( #11396 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
8be6fdde54
feat: MathML support ( #11387 )
...
* feat: MathML support
- Add support for MathML namespace
- Auto-infer MathML namespace
* tweak
* DRY out
* note to self
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
1 year ago
fe56c7fd2e
Version Packages (next) ( #11393 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
7a66927ca8
fix: bump esrap ( #11392 )
1 year ago
e7d1e4a8bc
Version Packages (next) ( #11384 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
e01776401d
fix: ensure no data loss occurs when using reactive Set methods ( #11385 )
1 year ago
2754e4eb39
fix: handle reassignment of `$$props` and `$$restProps` ( #11348 )
...
* fix: handle reassignment of `$$props` and `$$restProps`
Some libraries assign to properties of `$$props` and `$$restProps`. These were previously resulting in an error but are now handled properly
https://github.com/sveltejs/svelte/issues/10359#issuecomment-2080067464
* $$props is coarse grained on updates, so we can simplify this
* fix
* fix comment
1 year ago
5e0845fe3e
fix: disallow sequence expressions in `@const` tags ( #11357 )
...
* fix: disallow sequence expressions in `@const` tags
closes #11349
* allow parenthesized sequence expression
1 year ago
b3c2d979c6
Version Packages (next) ( #11381 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
0397fcb614
fix: require whitespace after `@const` tag ( #11379 )
1 year ago
eb7e32c168
fix: collect all necessary setters of html elements ( #11371 )
...
When spreading attributes, the setters of the element are checked. If they contain the key in question, it's set via that setter. For certain setters on certain elements this didn't work because the element prototype was not HTMLElement, rather a descendant of that (for example HTMLDivElement), which meant that only the setters of the descendant, not the superclass were taken into account. This fixes that by walking up the prototype chain until we find the Element prototype.
fixes #11179
1 year ago
cd2506535f
feat: leave view transition pseudo selectors untouched ( #11375 )
...
* feat: leave view transition pseudo selectors untouched
view transition pseude selectors are global-like, i.e. they shouldn't be scoped or treated as unused.
In the process of adding support for this, is_root and is_host were consolidated into is_global_like because their usage locations didn't need any differentiation between them (same for the new view transition treatment)
closes #9127
* regenerate types
1 year ago
de315d84eb
fix: ensure reactions are kept dirty when marking them again ( #11364 )
...
previously a reaction could be marked as DIRTY and subsequently as MAYBE_DIRTY before running, resulting in false negatives. Ensure that DIRTY flag can never be lowered to MAYBE_DIRTY
fixes #11363
1 year ago
7a3ee6d059
Version Packages (next) ( #11335 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
1 year ago
4479b8c6f3
fix: allow `bind:this` on `<select>` with dynamic `multiple` attribute ( #11378 )
...
fixes #11377
1 year ago
500b2065e0
fix: apply modifiers to bubbled events ( #11369 )
...
fixes #11365
1 year ago
8b1a26904a
chore: add css regression test ( #11373 )
...
at rules are now left alone and you can have nested css in them which is scoped correctly. This just adds a test so we don't regress in the future
closes #9267
1 year ago
2d2508a2cd
feat: allow for literal property definition with state on classes ( #11326 )
...
closes #11316
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
c7bdef595b
fix: store from props hoist wrong param ( #11367 )
...
Fixes #11355
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
1 year ago
Rich Harris
github-actions[bot]
Paolo Ricciuti
Dominic Gannaway
Simon H
Dominik G
Mathias
adiGuba
Mateusz Kadlubowski
Fabio Rotondo
Vladislav Logvin
Philipp Pracht
Hunter Johnston
Luke Warlow
Jeremiasz Major