svelte

Commit Graph

Author	SHA1	Message	Date
Nathan Shively-Sanders	55367b387a	Update for TS7 I am testing Typescript 7's JS support, which I've largely rewritten during the switch to Go. That means Javascript code will need to change much more than Typescript code. Fortunately, most of the changes are for the better: Javascript semantics are now nearly identical to Typescript semantics. It's much stricter and no longer has some persistent bugs that arose from shady JS handling I wrote years ago. This PR changes Svelte so that it compiles both with TS5.* and TS7, which means that occasionally there are duplicative or non-obvious changes. I'll annotate the interesting changes to explain why I made them. Because TS7 is quite a way off, I don't know whether you'll want to take this PR. Most of the changes are for the better, because they're due to stricter TS-aligned checking. But some are neutral and there is the previously mentioned duplication in a few places.	2 months ago
Rich Harris	1deb31082a	fix: abort and reschedule `$effect.pre` when necessary (#16335 ) * unskip failing test * fix * tidy up * skip_no_async * add comment	2 months ago
Simon H	aabd333d89	fix: ensure subscriptions are picked up correctly by deriveds (#16466 ) Increment the version to ensure any dependent deriveds are marked dirty when the subscription is picked up again later. If we didn't do this then the comparison of write versions would determine that the derived has a later version than the subscriber, and it would not be re-run. Fixes #16311 Fixes #15888	2 months ago
Rich Harris	d3a01bd5a7	fix: always mark reactions of deriveds (#16457 ) * tweak * fix * test * changeset	2 months ago
Rich Harris	5033c8e965	fix: tag stores for `$inspect.trace()` (#16452 )	2 months ago
ComputerGuy	e1e7a75d71	fix: allow async destructured deriveds (#16444 ) * fix: allow async destructured deriveds * add test * tweak * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
ComputerGuy	ad0b58ee96	fix: move ownership validation into async component body (#16449 ) * fix: move ownership validation into async component body * add test --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
ComputerGuy	63cbe2108a	fix: disallow `export { foo as default }` in `<script module>` (#16447 ) * fix: disallow `export { foo as default }` in `<script module>` * add test * fix test	2 months ago
Simon H	27c90dfa83	fix: don't reexecute derived with no dependencies on teardown (#16438 ) The prior logic was wrong because it reexecuted when something was clean, but we want to when it's not. The remaining fix was to also check the reactions: If an effect is destroyed and it was the last reaction of a derived then the derived is set to `MAYBE_DIRTY`. We therefore also need to check if the derived still has anyone listening to it, and only then reexecute it. Fixes #16363	2 months ago
Elliott Johnson	f5db130e2d	chore: Switch `payload.out` to an array (#16428 ) * chore: Switch `payload.out` to an array * Apply suggestions from code review * changeset	2 months ago
Paolo Ricciuti	c2da1ebb85	fix: keep effect in the graph if it has an abort controller (#16430 )	2 months ago
Paolo Ricciuti	bdf6adb411	fix: delegate functions with shadowed variables if declared locally (#16417 )	2 months ago
Ray Thurn Void	9e1e7139fb	fix: robustify reset calls in error boundaries (#16171 ) Fixes #16134 * Add a warning when the misuse of `reset` in an `error:boundary` causes an error to be thrown when flushing the boundary content * Prevent uncaught errors to make test fails when they are expected and are fired during template effects flush * reset should just be a noop after the first call * correctly handle errors inside boundary during reset * handle errors in the correct boundary --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Rich Harris	a67b5862f1	fix: more informative error when effects run in an infinite loop (#16405 ) * update effect_update_depth_exceeded docs * log update locations * remove dev_effect_stack stuff, it's not very helpful * tidy up * test * fix test * changeset * fix	2 months ago
Rich Harris	09c9a3c165	fix: silence `$inspect` errors when the effect is about to be destroyed (#16391 ) * fix: silence `$inspect` errors when the effect is about to be destroyed * changeset	2 months ago
Simon H	ee1ef6083a	fix: ensure compiler state is reset before compilation (#16396 ) #16268 introduced a slight regression where the state is not reset completely upon compilation. It did reset warnings but not other state, which meant if file A succeeds but file B fails in the parsing state (before the state was reset for real) it would get wrong filename info. This fixes it by setting the filename at the very beginning.	2 months ago
7nik	6cf3a19342	fix: better handle $inspect on array mutations (#16389 ) * fix: better handle $inspect on array mutations * increase stack trace limit, revert test change * second changeset --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
ComputerGuy	8e73fd4b03	fix: don't log `await_reactivity_loss` warning when signal is read in `untrack` (#16385 ) * fix: don't log `await_reactivity_loss` warning when signal is read in `untrack` * add test * fix	2 months ago
Rich Harris	e01bd97bef	fix: update `$effect.pending()` immediately after a batch is removed (#16382 ) * WIP sync effect pending updates * fix * changeset * fix * add test * inline * unused	2 months ago
Rich Harris	9134caca24	fix: only skip updating bound `<input>` if the input was the source of the change (#16373 ) * fix: only skip updating bound `<input>` if the input was the source of the change * import Batch as type, not value	2 months ago
Rich Harris	96ff125fcf	chore: fix error boundary test (#16368 )	2 months ago
Rich Harris	be0818552d	chore: squelch hydration warning in test suite (#16336 )	2 months ago
Ahmad S.	63b5ebf36e	fix: silence a11y warning for inert elements (#16339 ) * fix: silence a11y warning for inert elements * changeset * handle `inert=""` * oops --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Rich Harris	0672e48223	feat: allow `await` in components (#15844 ) * tidy * tidy * yes it can, apparently * tidy up * unused * complete merge * WIP * simplify * debugging help * WIP * unused * partial merge * WIP * fix * add test * rename * fix * unused * oops * chore: merge main into async branch (#16197) * chore: merge main into async branch * adjust test * fix: make effects depend on state created inside them (#16198) * make effects depend on state created inside them * fix, add github action * disable test in async mode * make batch.#deferred private * fix settled when awaits occur inside pending boundary * tweak * change behaviour of `tick()` to be requestAnimationFrame-based * get rid of a bunch of Promise.resolve chains * more * more * fix test * disallow `flushSync()` inside effects * regenerate * handle errors in block expressions * make validate_each_keys async-aware * for unowned deriveds, throw errors lazily * rename ASYNC_ERROR -> ERROR_VALUE, and avoid conflicts with other flags now that it's used with deriveds as well as sources * invoke boundary directly * local effect pending * update test * fix * fix * fix weird bug in tests * delete old changeset that somehow got left over here * Update .changeset/eleven-weeks-dance.md * update error details * unused * simplify * tweak * tweak * tweak * tweak * tidy up * handle errors in async block expressions * tweak * groundwork for async attribute_effect * dry out * fix async directives * tidy up * initialize option values before initing select values * simplify init_select * simplify * tweak * tidy up * tweak * on second thoughts just simplify it here * tidy * handle awaits in `<slot>` * unused * tidy up * tidy up * dry out * dry out * Revert "dry out" This reverts commit `25855163bf`. * dry out * dry out * use let for block-scoped stuff * dry out * dry out * tidy up * only wrap awaits in `$.save` when necessary * oops * remove TODO comment (just checked) * oops, leftover * simplify * unused * remove logging * tweak * unused * unused * remove logging * partial fix * fix * remove unused EFFECT_HAS_DERIVED * Update packages/svelte/src/reactivity/create-subscriber.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/index-client.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/runtime.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * unused * Update packages/svelte/src/internal/client/reactivity/sources.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier * unused * fix flags * tweak * tweak * unused * fix * no idea what a 'boundary micro task' is or why it was deemed necessary but evidently it isn't * remove queue_boundary_micro_task * oops * note * tidy up * remove TODO * make method private * simplify * flesh out await_reactivity_loss warning * tweak * update test * fix * null out from_async_derived in more places * tidy up test * failing test * unused * fix test * fix * simplify. no idea what the async_mode_flag stuff is about, but it appears unnecessary * add async_derived_orphan error * regenerate * flesh out await_outside_boundary message * add some JSDoc * only update `$effect.pending()` if someone is listening, since it causes a double flush and makes debugging harder * tweak logic to make it clearer why and when we commit a batch * add a couple of comments * false -> 0 * add comment * unused * silence warning * add effect_pending_outside_reaction error * Update packages/svelte/src/compiler/types/index.d.ts Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * suspend batch, not boundary * rename from_async_derived -> current_async_derived * tweak * remove TODO - this method is only called when pending snippet exists * use error boundary for test - vitest does some weird error swallowing afaict * flush less often * restore -> activate * remove TODO * move batch-related code into batch.js * make flush_queued_root_effects a method of batch * make process_effects a method of batch * make stuff private * unused * regenerate * update test * more JSDoc * add more JSDoc * branch and block effects do not also need to be render effects * tidy up * simplify * unused * move code where it belongs * remove, for now * fix * only apply error adjustments when error escapes boundaries * remove EFFECT_IS_UPDATING * is_dirty is a better name than check_dirtiness * duplicates are rare and harmless * apparently we no longer need the merging logic? we can simplify and fix stuff by removing it * tidy * don't commit stale batches * add skipped failing test * partial merge * WIP * WIP * WIP * tweak * tidy up * dont update derived status when time-travelling * tidy up * tidy up * tag async deriveds * tweak * bail out of secondary flushes * re-run blocks on subsequent flushes * add test * fix * add tests, one failing * fix * flesh out await_waterfall message * tidy up * dry out * unused * tweak * tidy up * TODO * tweak * tidy up * remove TODO * unused export * add optimisation back * revert unneeded changes * revert * update some tests * more * more * move some code * rename * WIP * unset context synchronously * remove unused argument * Apply suggestions from code review Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * add comment * add comment * use queue_micro_task in createSubscriber * Update packages/svelte/src/compiler/phases/3-transform/client/visitors/AwaitExpression.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	2 months ago
Rich Harris	a23599a196	fix: don't show adjusted error messages in boundaries (#16360 )	2 months ago
Ahmad S.	96c1a10042	fix: silence autofocus a11y warning inside `<dialog>` (#16341 )	2 months ago
Paolo Ricciuti	c9098bcaa0	fix: use `state` instead of `source` in reactive classes (#16239 ) * fix: use `state` instead of `source` in reactive classes * fix: use `active_reaction` as indication to use `source` or `state` * fix: cleanup `#initial_reaction` on `teardown` to free memory * fix: use `#source` in `set` too * unused * chore: use WeakRef * use update_version instead of WeakRef in SvelteSet/SvelteMap (#16324) * tidy up * tweak comment to remove active_reaction reference --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 months ago
Rich Harris	140462374a	fix: re-evaluate derived props during teardown (#16278 ) * Store deriveds old value before updating them for consistency with directly assigned sources when reading in teardown functions * Add tests for derived old values in teardown functions * Add tests for props old values in onDestroy hooks to prevent regressions * Add changeset * Update comment * remove extraneous tests - these pass with or without the src change * revert * WIP * simplify props * simplify * tweak * reorder a bit * simplify * unused * more * more * tweak * also appears to be unnecessary * changeset * fix * Update .changeset/light-rivers-jump.md * easier debugging * fix * WIP * fix --------- Co-authored-by: raythurnvoid <53383860+raythurnvoid@users.noreply.github.com>	2 months ago
Rich Harris	cf2ff5e8dc	fix: abort and reschedule effect processing after state change in user effect (#16280 ) * fix: abort and reschedule effect processing after state change in user effect * failing test * skip for now	2 months ago
Paolo Ricciuti	834cd91b36	fix: account for mounting when `select_option` in `attribute_effect` (#16309 )	2 months ago
7nik	c3348aea06	fix: do not proxify the value assigned to a derived (#16302 )	2 months ago
Simon H	32882a956b	feat: add parent hierarchy to `__svelte_meta` objects at dev time (#16255 ) * feat: add parent hierarchy to `__svelte_meta` objects at dev time This adds a `parent` property to the `__svelte_meta` properties that are added to elements at dev time. This property represents the closest non-element parent the element is related to. For example for `{#if ...}<div>foo</div>{/if}` the `parent` of the div would be the line/column of the if block. The parent is recursive and goes upwards (through component boundaries) until the root component is reached, which has no parent. part of #11389 * oops * Apply suggestions from code review Co-authored-by: Rich Harris <rich.harris@vercel.com> * tweak * original component tag * make render appear in tree, keep tree in sync when rerenders occur --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 months ago
Simon H	2f68131e9a	fix: revert props legacy mode regression (#16279 ) #16270 removed a condition which seemed to keep passing the corresponding test, but it actually introduced a regression since the PROPS_IS_UPDATED is always set when accessors should be created, which is the case by default in legacy mode tests. Setting accessors to false in the test reveals the regression, so this reverts that part of the refactoring	3 months ago
Rich Harris	b673145659	feat: add `getAbortSignal()` (#16266 ) * WIP getAbortSignal * add test * regenerate * add error code * changeset * regenerate * try this * { stale: true } * fix test * lint * abort synchronously in SSR * make STALE_REACTION a `StaleReactionError extends Error` * make non-optional * Update packages/svelte/src/internal/server/abort-signal.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> --------- Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	3 months ago
Rich Harris	e896c55b6c	chore: bump esrap (#16240 ) * chore: bump esrap * regenerate	3 months ago
Simon H	7019894fd9	fix: ensure unowned deriveds can add themselves as reactions while connected (#16249 ) an unowned derived should still add itself as a reaction while it is properly connected, which means it can be cleaned up correctly - and this connection is indicated by it having reactions. Fixes #15829 and potentially #15853	3 months ago
Rich Harris	da2feafe67	chore: silence some pesky logs (#16241 )	3 months ago
Paolo Ricciuti	922bee9a6d	fix: use fine grained for template if the component is not explicitly in legacy mode (#16232 ) * fix: use fine grained for template if the component is not explicitly in legacy mode * chore: add comment Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix: add `LabeledStatement` to `instance.ast` check * fix: spread `keys` * fix: snapshots * fix: use `compileOption.runes` if defined + add other tests --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 months ago
Fedor Nezhivoi	2af7ba2156	fix: lift unsafe_state_mutation constraints for SvelteSet and SvelteMap created inside the derived (#16221 ) Co-authored-by: Fedor Nezhivoi <f.nezhivoi@corp.vk.com>	3 months ago
Paolo Ricciuti	c4b32c2bff	fix: untrack `$inspect.with` and add check for unsafe mutation (#16209 ) Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 months ago
7nik	4db4ee5330	chore: rid of nodeType magic numbers (#16208 ) * chore: rid of nodeType magic numbers * lint --------- Co-authored-by: 7nik <kifiranet@gmail.com>	3 months ago
7nik	659198a95c	fix: address css class matching regression (#16204 ) * fix: address css class matching regression * address feedback --------- Co-authored-by: 7nik <kifiranet@gmail.com>	3 months ago
7nik	2b20a2d16b	fix: match class and style directives against attribute selector (#16179 ) Co-authored-by: 7nik <kifiranet@gmail.com>	3 months ago
Ray Thurn Void	de90fc8dce	Test array sort in effect to prevent regressions of this use-case (#16175 )	3 months ago
floriskn	579d0e6636	fix: ensure undefined attributes are removed during hydration (#16178 ) * fix: ensure undefined attributes are removed during hydration Attributes that are `undefined` on the client should be removed during hydration, even if their value hasn't changed compared to `prev_value`. * Create plenty-wasps-sleep.md * added test * Update .changeset/plenty-wasps-sleep.md --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>	3 months ago
Simon H	a5f500e7c0	fix: keep spread non-delegated event handlers up to date (#16180 ) * fix: keep spread non-delegated event handlers up to date #15961 introduced a regression where non-delegated events that were spread and updated were not getting updated. This fixes that by ensuring prev is actually updated to the most recent value * fix	3 months ago
7nik	838f881550	fix: avoid shadowing a variable in dynamic components (#16185 ) * fix: avoid shadowing a variable in dynamic components * split component name and intermediate name --------- Co-authored-by: 7nik <kifiranet@gmail.com>	3 months ago
Simon H	061ab31d23	fix: ensure sources within nested effects still register correctly (#16193 ) * fix: ensure sources within nested effects still register correctly When an effect creates another effect and a proxy property is read that wasn't before, the proxy will have logic where it creates the new signal in its original reaction context. But it did not have logic to correctly handle the `reaction_sources` array which prevents effects/deriveds rerunning when state created inside themselves is read and then changed inside them: Since `reaction_sources` wasn't take the reaction context into account, false positives could occur where nested effects would not register the sources as dependencies. Fixes #15870 * oops forgot to push this	3 months ago
Rich Harris	b224c3fb4b	fix: coarse reactivity, alternative approach (#16100 ) Make sure we track statically visible dependencies and untrack indirect dependencies Fixes #14351 --------- Co-authored-by: 7nik <kifiranet@gmail.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 months ago
Paolo Ricciuti	7e588857c2	fix: don't set state withing `with_parent` in proxy (#16176 ) Closes #16164 We can't set everywhere within with_parent otherwise if it's the first time we are reading a derived it could look like we are setting state in a derived (which you are not).	3 months ago

1 2 3 4 5 ...

1316 Commits (f8bf2826ab8b1c443363fb90d22613713501b396)