2221 Commits (f4b94e57a349b22d012fa27563fae520463ec1de)

Author	SHA1	Message	Date
Rich Harris	c08ecba1b7	feat: forking (#17004) ... * chore: run boundary async effects in the context of the current batch * WIP * reinstate kludge * fix test * WIP * WIP * WIP * remove kludge * restore batch_values after commit * make private * tidy up * fix tests * update test * reset #dirty_effects and #maybe_dirty_effects * add test * WIP * add test, fix block resolution * bring async-effect-after-await test from defer-effects-in-pending-boundary branch * avoid reawakening committed batches * changeset * cheat * better API * regenerate * slightly better approach * lint * revert this whatever it is * add test * Update feature description for fork API * error if missing experimental flag * rename inspect effects to eager effects, run them in prod * regenerate * Apply suggestions from code review Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * tidy up * add some minimal prose. probably don't need to go super deep here as it's not really meant for non-framework authors * bit more detail * add a fork_timing error, regenerate * unused * add note * add fork_discarded error * require users to discard forks * add docs * regenerate * tweak docs * fix leak * fix * preload on focusin as well * missed a spot * reduce nesting --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 days ago
github-actions[bot]	4a214f786f	Version Packages (#17019) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Rich Harris	f45d9cfe2d	fix: better optimization of await expressions (#17025)	3 days ago
Rich Harris	2e1dd489f6	fix: coordinate mount of snippets with await expressions (#17021) ... * fix: coordinate mount of snippets with await expressions * try this * deduplicate --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	3 days ago
Rich Harris	523c85bd3d	merge	4 days ago
Rich Harris	4e847cfd14	merge main	4 days ago
Rich Harris	0b477871e8	fix: coordinate mount of snippets with await expressions	4 days ago
Simon H	bd697c12c6	fix: flush pending changes after rendering `failed` snippet (#16995) ... fixes #16730	4 days ago
Simon H	cd3a11edff	fix: take into account static blocks when determining transition locality (#17018) ... The "is this a transparent effect we can ignore" logic for determining whether or not to play a local transition didn't account for pruned block effects. This fix marks the child branch as transparent if the block effect was, and during traversal then checks if the branch is the child of a block - if not that means it's the child of a pruned block effect. fixes #16826	4 days ago
github-actions[bot]	86aedaecf9	Version Packages (#17009) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 days ago
Simon H	16117d9b69	perf: skip repeatedly traversing the same derived (#17016) ... * perf: skip repeatedly traversing the same derived We introduce a new flag which marks a derived during the mark_reaction phase and lift it during the execution phase. * fix This introduces a new flag which marks a derived as visited during the mark_reaction phase and lifts it during the dirty-check/execution phase (both are necessary because not all deriveds are necessarily executed, but they're always checked). We could've used a Set on mark_reactions which would've been simpler to reason about, alas it was performing consistenly worse on the kairo_mux_unowned / kairo_mux_owned benchmarks (it kinda makes sense generally, creating and filling a set is more expensive than juggling flags). Closes #16658, which showcases are particularly gnarly signal graph where many deriveds point to the same deriveds, where we would be traversing the same reactions over and over if we didn't do this. I also added a similar measure (this time a set/map is unavoidable/makes more sense) for mark_effects, hopefully this helps for #16990	4 days ago
Rich Harris	851da4b629	chore: exclude vite optimized deps from stack traces (#17008)	5 days ago
github-actions[bot]	3009a0208f	Version Packages (#16992) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	5 days ago
Rich Harris	7e40186a5f	fix: run batch until complete (#16971) ... at present we only call batch.increment() when something async happens if we're not inside a pending boundary, but that's incorrect — it means that a batch is committed before everything resolves. When work inside a pending boundary does resolve, the batch becomes a zombie. At the same time, we don't handle effects inside pending boundaries correctly. They should be deferred until the boundary (and all its parents) are ready. This PR attempts to fix that — during traversal, when we exit a pending boundary, any effects that were collected get deferred until the next flush. We also distinguish between batch.#pending (any ongoing async work) and batch.#blocking_pending (any async work that should prevent effects outside pending boundaries from being flushed).	5 days ago
Rich Harris	4b32d6d8b3	fix: make `$inspect` logs come from the callsite (#17001) ... * fix: make `$inspect` logs come from the callsite * default to showing stack trace * reuse id * DRY out, improve server-side inspect * update docs * ugh * fix the dang tests * ugh windows is there no punch bowl you won't poop in? * argh * how about this * alright finally	5 days ago
Simon H	a57868ebce	fix: don't preserve reactivity context across function boundaries (#17002) ... Fixes #16809 We gotta take into account function boundaries when determining whether or not we're inside a derived (or const).	6 days ago
David	f549478dd0	fix: guard contents updated before the guard itself (#16930) ... Fixes #16850, fixes #16775, fixes #16795, fixes #16982 #16631 introduced a bug that results in the effects within guards being evaluated before the guards themselves. This fix makes sure to iterate the block effects in the correct order (top down) --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	7 days ago
github-actions[bot]	7d9ea8ea99	Version Packages (#16984) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Rich Harris	b8627e511d	chore: centralise branch management (#16977) ... * WIP * WIP * WIP * WIP * WIP * fix hydration * simplify * all tests passing * key blocks * snippets * fix * tidy up * WIP await * tidy up * fix * neaten up * unused * tweak * elements * changeset * fix * preserve newer batches * add comment * add comment * no longer necessary apparently? * move legacy logic to key block	1 week ago
ComputerGuy	9a488d6b25	fix: place `let:` declarations before `{@const}` declarations (#16985) ... * fix: place `let:` declarations before `{@const}` declarations * lint * fix	1 week ago
Rich Harris	c8ef540985	fix: improve `each_key_without_as` error (#16983)	1 week ago
github-actions[bot]	bd2d3db6d0	Version Packages (#16970) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Rich Harris	53f2693b3b	feat: `$state.eager(value)` (#16849) ... * WIP implement `$effect.pending(...)` * feat: `$state.eager(value)` (#16926) * runtime-first approach * revert these * type safety, lint * fix: better input cursor restoration for `bind:value` (#16925) If cursor was at end and new input is longer, move cursor to new end No test because not possible to reproduce using our test setup. Follow-up to #14649, helps with #16577 * Version Packages (#16920) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * docs: await no longer need pending (#16900) * docs: link to custom renderer issue in Svelte Native discussion (#16896) * fix code block (#16937) Updated code block syntax from Svelte to JavaScript for clarity. * fix: unset context on stale promises (#16935) * fix: unset context on stale promises When a stale promise is rejected in `async_derived`, and the promise eventually resolves, `d.resolve` will be noop and `d.promise.then(handler, ...)` will never run. That in turns means any restored context (via `(await save(..))()`) will never be unset. We have to handle this case and unset the context to prevent errors such as false-positive state mutation errors * fix: unset context on stale promises (slightly different approach) (#16936) * slightly different approach to #16935 * move unset_context call * get rid of logs --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> * fix: svg `radialGradient` `fr` attribute missing in types (#16943) * fix(svg radialGradient): fr attribute missing in types * chore: add changeset * Version Packages (#16940) * Version Packages * Update packages/svelte/CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> * chore: simplify `batch.apply()` (#16945) * chore: simplify `batch.apply()` * belt and braces * note to self * unused * fix: don't rerun async effects unnecessarily (#16944) Since #16866, when an async effect runs multiple times, we rebase older batches and rerun those effects. This can have unintended consequences: In a case where an async effect only depends on a single source, and that single source was updated in a later batch, we know that we don't need to / should not rerun the older batch. This PR makes it so: We collect all the sources of older batches that are not part of the current batch that just committed, and then only mark those async effects as dirty which depend on one of those other sources. Fixes the bug I noticed while working on #16935 * fix: ensure map iteration order is correct (#16947) quick follow-up to #16944 Resetting a map entry does not change its position in the map when iterating. We need to make sure that reset makes that batch jump "to the front" for the "reject all stale batches" logic below. Edge case for which I can't come up with a test case but it _is_ a possibility. * feat: add `createContext` utility for type-safe context (#16948) * feat: add `createContext` utility for type-safe context * regenerate * Version Packages (#16946) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> * chore: Remove annoying sync-async warning (#16949) * fix * use `$state.eager(value)` instead of `$effect.pending(value)` --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyunbin Seo <47051820+hyunbinseo@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Hannes Rüger <hannes@hannesrueger.de> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * decouple from boundaries * use queue_micro_task * add test * fix * changeset * revert * tidy up * update docs * Update packages/svelte/src/internal/client/reactivity/batch.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * minor tweak --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Hyunbin Seo <47051820+hyunbinseo@users.noreply.github.com> Co-authored-by: Ben McCann <322311+benmccann@users.noreply.github.com> Co-authored-by: Hannes Rüger <hannes@hannesrueger.de> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	1 week ago
Rich Harris	ee093e4c86	fix: preserve `<select>` state while focused (#16958)	1 week ago
Rich Harris	9b5fb3f430	fix: error if `each` block has `key` but no `as` clause (#16966)	1 week ago
Rich Harris	7d977fad88	chore: run boundary async effects in the context of the current batch (#16968)	2 weeks ago
github-actions[bot]	a54186242a	Version Packages (#16967) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Paolo Ricciuti	8691391c08	fix: add hydration markers in `pending` branch of SSR boundary (#16965)	2 weeks ago
github-actions[bot]	94fc836e3a	Version Packages (#16950) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Elliott Johnson	9cdd76e3a3	chore: Remove annoying sync-async warning (#16949)	2 weeks ago
github-actions[bot]	005895d994	Version Packages (#16946) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Rich Harris	f3c55e8e6c	feat: add `createContext` utility for type-safe context (#16948) ... * feat: add `createContext` utility for type-safe context * regenerate	2 weeks ago
Simon H	28765f846e	fix: don't rerun async effects unnecessarily (#16944) ... Since #16866, when an async effect runs multiple times, we rebase older batches and rerun those effects. This can have unintended consequences: In a case where an async effect only depends on a single source, and that single source was updated in a later batch, we know that we don't need to / should not rerun the older batch. This PR makes it so: We collect all the sources of older batches that are not part of the current batch that just committed, and then only mark those async effects as dirty which depend on one of those other sources. Fixes the bug I noticed while working on #16935	2 weeks ago
Rich Harris	a7c958a2a5	chore: simplify `batch.apply()` (#16945) ... * chore: simplify `batch.apply()` * belt and braces * note to self	2 weeks ago
github-actions[bot]	2a951391dc	Version Packages (#16940) ... * Version Packages * Update packages/svelte/CHANGELOG.md --------- Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
Hannes Rüger	e8330ee7bf	fix: svg `radialGradient` `fr` attribute missing in types (#16943) ... * fix(svg radialGradient): fr attribute missing in types * chore: add changeset	2 weeks ago
Simon H	23e2bb3b89	fix: unset context on stale promises (#16935) ... * fix: unset context on stale promises When a stale promise is rejected in `async_derived`, and the promise eventually resolves, `d.resolve` will be noop and `d.promise.then(handler, ...)` will never run. That in turns means any restored context (via `(await save(..))()`) will never be unset. We have to handle this case and unset the context to prevent errors such as false-positive state mutation errors * fix: unset context on stale promises (slightly different approach) (#16936) * slightly different approach to #16935 * move unset_context call * get rid of logs --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
github-actions[bot]	420468a041	Version Packages (#16920) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	5d9b4c66ca	fix: better input cursor restoration for `bind:value` (#16925) ... If cursor was at end and new input is longer, move cursor to new end No test because not possible to reproduce using our test setup. Follow-up to #14649, helps with #16577	2 weeks ago
7nik	93012e1e6f	fix: track the user's getter of `bind:this` (#16916)	3 weeks ago
Paolo Ricciuti	297afd0578	fix: generate correct code for `each` blocks with async body (#16923) ... * fix: generate correct code for `each` blocks with async body * fix: else branch of `each` block * chore: add expected html	3 weeks ago
Paolo Ricciuti	7f8e60fd8a	fix: generate correct SSR code for the case where `pending` is an attribute (#16919) ... Closes #16886	3 weeks ago
github-actions[bot]	844fab7798	Version Packages (#16913) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	b5c8437151	fix: flush batches whenever an async value resolves (#16912) ... * fix: flush batches whenever an async value resolves * move some code around * unnecessary	3 weeks ago
github-actions[bot]	06bd6a8fbd	Version Packages (#16909) ... Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	78481862fb	fix: hydrate each blocks inside element correctly (#16908) ... We have an each block optimization that omits the comment when the each block is the sole child of an element. This optimization clashes with async which wants to skip ahead to the sibling closing comment. For now we therefore remove that optimization when the each block is async. In the long run we should instead optimize _all_ cases where _any_ block is the sole child of an element, in both async and sync mode, consistently. fixes #16905 fixes #16907	3 weeks ago
Paolo Ricciuti	1b1f144396	fix: add `UNKNOWN` evaluation value before breaking for `binding.initial===SnippetBlock` (#16910)	3 weeks ago
ComputerGuy	edcd4b59e3	fix: correctly transform `$derived` private fields on server (#16894) ... Closes #16889	3 weeks ago
Yuki Ishii	5d1ffcf413	fix: allow await in if block consequent and alternate (#16890) ... Closes #16885	3 weeks ago
ComputerGuy	303750a124	fix: don't replace rest props with `$$props` for excluded props (#16898) ... Closes #16895	3 weeks ago