525 Commits (e4faa7805dbdc65d720b02036369393b027419c2)

Author	SHA1	Message	Date
Paolo Ricciuti	82a645f8d0	fix: `$state.is` missing second argument on the server (#11835) ... * fix: `$state.is` missing second argument on the server * chore: update test	1 year ago
Simon H	bcb319310f	fix: prevent false positive ownership warning when reassigning state (#11812) ... When a proxy is reassigned, we call `$.proxy` again. There are cases where there's a component context set but the reassignment actually happens for variable that is ownerless within shared state or somewhere else. In that case we get false positives right now. The inverse is also true where reassigning can delete owners (because no component context exists) and result in false negatives. The fix is to pass the previous value in to copy over the owners from it. Fixes #11525	1 year ago
Dominic Gannaway	5f7bfac59a	chore: cleanup event changes (#11821) ... Takes some changes from #11810 that are only cleanup/renaming.	1 year ago
Dominic Gannaway	36b270ef3b	fix: address derived memory leak on disconnection from reactive graph (#11819) ... Fixes #11817. It turns out that we weren't fully handling the disconnection of derived signals from the reactivity graph – resulting in cases where they could leak memory because they were not being removed from their dependency reactions array. However, removing ourselves from this array meant that any future changes might mean we need to reconnect the derived to the graph again – so we have to do some additional bookkeeping to make this work. Thankfully, we already have versioning because of unowned deriveds, we can use the versions to understand if the owned derived signal is dirty after being connected to the reactivity graph again – something we couldn't do in early permutations of the signal architecture – and likely why we hadn't addressed this in the same sense.	1 year ago
Simon H	538060ebda	fix: ensure visit is called with correct state (#11798) ... Some of our `visit` calls have the wrong current state associated with it. To fix it, we need to pass the real current one. fixes #11722	1 year ago
Simon H	68263c8615	fix: make prop fallback values deeply reactive if needed (#11804) ... If a property is mutated, the assumption is that it is deeply reactive. In those cases, the fallback value should be proxified so that it also is deeply reactive. fixes #11425	1 year ago
Simon H	8c66b64e6b	feat: provide new `Component` type that represents the shape of components (#11775) ... In Svelte 3 and 4, components were classes under the hood, and the base class was `SvelteComponent`. This class was also used in language tools to properly type check the template code. In Svelte 5, components are functions. To give people a way to extend them programmatically, it would be good to expose the actual shape of components. This is why this PR introduces a new `Component` type. For backwards compatibility reasons, we can't just get rid of the old class-based types. We also need to ensure that language tools can work with both the new and old types: There are many libraries out there that provide `d.ts` files with type definitions written using the class types - these should not error. That's why there's an accompagning language tools PR (https://github.com/sveltejs/language-tools/pull/2380) that's doing the heavy lifting: Instead of generating classes, it now generates a constant and an interfaces and uses Typescript's declaration merging feature to provide both so we can declare a component export as being both a class and a function. That ensures that people can still instantiate them with `new` (which they can do if they use the `legacy.componentApi` compiler option), and it also ensure we don't need to adjust any other code generation mechanisms in language tools yet - from a language tools perspective, classes are still the norm. But through exposing the default export as being _also_ callable as a function we can in a future Svelte version, where classes/the Svelte 4 syntax are removed completely, seamlessly switch over to using functions in the code generation, too, and the `d.ts` files generated up until that point will support it because of the dual shape. This way we have both backwards and forwards compatibility.	1 year ago
Simon H	7a1326be06	fix: handle `this` parameter in TypeScript-annotated functions (#11795) ... fixes #11731	1 year ago
FoHoOV	4fef0eb08f	fix: capture the correct event names when spreading attributes (#11783) ... fixes #11777 We need to scope the `key` variable because it may be captured in a closure	1 year ago
Paolo Ricciuti	ee9d5ef850	fix: allow global next to `&` for nesting (#11784) ... Fixes #11782	1 year ago
FoHoOV	b963e53fc9	fix: parse ongotpointercapture and onlostpointercapture events correctly (#11790) ... Fixes #11789	1 year ago
Rich Harris	d1f5d5d33d	fix: only inject push/pop/$$props in SSR components when necessary (#11771)	1 year ago
Paolo Ricciuti	9084f1796b	fix: allow runelike writable as prop (#11768) ... Fixes #11742	1 year ago
Paolo Ricciuti	d856c50092	fix: `array.lastIndexOf` without second argument (#11766) ... Fixes #11756 lastIndexOf seems to be using arguments internally so passing undefined is different from not passing it	1 year ago
Paolo Ricciuti	7dacf2c4d4	fix: use svg methods for updating svg attributes too (#11755) ... Closes #11746 we were using the svg methods for every child of svg but not for svg itself	1 year ago
Rich Harris	d15fd9556f	chore: better invalid attribute message (#11754) ... * simplify code * replace error code and message * update message, update tests	1 year ago
Paolo Ricciuti	5765752d78	fix: throw on invalid attribute expressions (#11736) ... In runes mode only to prevent a breaking change solely from upgrading to Svelte 5 Closes #11734	1 year ago
Paolo Ricciuti	e73b133b66	fix: don't warn on link without href if aria-disabled (#11737) ... Also don't warn on a tag without a href attribute and link role fixes #11733	1 year ago
Rich Harris	329c10eb6c	chore: update noscript test (#11749)	1 year ago
Dominic Gannaway	fe51cde1fa	breaking: event handlers + bindings now yield effect updates (#11706) ... * breaking: delegated event handlers now yield effect updates * tweak * refactor * refactor * yield binding change events * handle input event bindings * more bindings * more bindings * more tests * more tests * address feedback * address feedback	1 year ago
Dominic Gannaway	44115840bd	chore: cleanup more tests (#11738) ... remove awaits in favor of flushSync	1 year ago
Simon H	4f9096a5a8	chore: delegate input event (#11732) ... We didn't delegate the input event back when we were also delegating `on:x` events, because it messes up the event/bindings/actions order. Since we're only doing that for `onx` event attributes now that reason is obsolete and we can start delegating it.	1 year ago
Paolo Ricciuti	77f91459b6	fix: update value like attributes in a separate template_effect (#11720) ... * fix: update value like attributes in a separate template_effect * chore: remove unnecessary commented code * chore: add test for spread values	1 year ago
Simon H	d590cd8bea	fix: ignore value attribute on select during SSR (#11724) ... The value attribute on select elements does nothing - it does not influence the initial value (in SSR that's the job of the `selected` attribute on an option element), updating it does not influence the current value either. Instead of rendering it out and then removing it on hydration (which is costly because the mutation causes work) we just don't render it in SSR. No test/changeset because no change in behavior.	1 year ago
Paolo Ricciuti	6d2f1a48b4	fix: allow comments after last selector in css (#11723) ... Fixes #11721	1 year ago
Rich Harris	0128df33da	fix: don't add scoping modifier to nesting selectors (#11713)	1 year ago
Dominic Gannaway	09addad9ae	fix: improve handling of unowned derived signal (#11712)	1 year ago
Paolo Ricciuti	f48001ac63	fix: check for invalid bindings on window and document (#11676) ... Fixes #11673	1 year ago
Paolo Ricciuti	b788b72862	fix: migrate derivations without semicolons (#11704) ... Closes #11689	1 year ago
Rich Harris	02520aea48	better tooltips in playground (#11705) ... * better tooltips in playground * update some tests that a drive-by fix broke	1 year ago
Dominic Gannaway	e6f8e95199	chore: tidy up tests to use flushSync (#11703)	1 year ago
Simon H	1784026843	fix: don't require commas between warnings in legacy mode (#11669) ... also add commas in migration closes #11666	1 year ago
Rich Harris	c29b74669d	feat: migrate `<svelte:element this="div">` (#11659)	1 year ago
Rich Harris	d288735fa8	breaking: disallow string literal values in `<svelte:element this="...">` (#11454) ... * breaking: disallow string literal values in `<svelte:element this="...">` * note breaking change * Update sites/svelte-5-preview/src/routes/docs/content/03-appendix/02-breaking-changes.md Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com> * prettier * make invalid `<svelte:element this>` a warning instead of an error (#11641) * make it a warning instead of an error * format --------- Co-authored-by: Jeremiasz Major <jrh.mjr@gmail.com>	1 year ago
Simon H	ade6b6e480	chore: add css regression test (#11658) ... closes #9207	1 year ago
Simon H	c2f75dc7ba	fix: use coarse-grained updates for derived expressions in legacy mode (#11652) ... fixes #11648 Also deduplicates the code a bit	1 year ago
Dominic Gannaway	54083fb9cc	fix: replay load and error events on load during hydration (#11642) ... * fix: replay load and error events on load during hydration * oops * fix replacement logic * make less evasive * address feedback * address feedback * address feedback * Update packages/svelte/src/internal/client/dom/elements/events.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * address feedback * Update packages/svelte/src/internal/client/dom/elements/attributes.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update packages/svelte/src/internal/client/dom/elements/attributes.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * address more feedback * address more feedback --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Dominik G	dc9b0d08c1	feat: add rootDir option and set __svelte_meta.file like in svelte4 (#11627) ... * feat: add rootDir option and set __svelte_meta.file like in svelte4 * Update packages/svelte/src/compiler/validate-options.js * update tests * centralise logic * fix * note to self * Apply suggestions from code review * lint * one dollar towards the windows backslash bugfix foundation please --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 year ago
Rich Harris	3bf68b4765	fix: make messages more consistent (#11643)	1 year ago
Dominic Gannaway	053159bf0b	fix: avoid state_referenced_locally warning within type annotations (#11638) ... * fix: avoid state_referenced_locally warning within type annotations * better fix * prettier * better fix * fix * fix * fix --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Simon H	4365562228	fix: deduplicate children prop from default slot (#10800) ... * feat: provide isSnippet type, deduplicate children prop from default slot fixes #10790 part of #9774 * fix ce bug * remove isSnippet type, adjust test * fix types * revert unrelated changes * remove changeset * enhance test * fix * fix * fix * fix, different approach without needing symbol --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Simon H	4bedd0e4fb	feat: error on imports to `svelte/internal/*` (#11632) ... * feat: error on imports to `svelte/internal/*` closes #11622 * regenerate * also error on svelte/internal	1 year ago
Dominic Gannaway	e5e7ec2404	fix: better handle img loading attribute (#11635) ... * fix: better handle img loading attribute * better fix * switch to symbol	1 year ago
Paolo Ricciuti	87a420f64d	feat: error when snippet shadows a prop (#11631) ... Closes #11603	1 year ago
Simon H	573b9f1d74	fix: adjust unknown code warning offset (#11621) ... They were the wrong way around fixes #11612	1 year ago
Dominic Gannaway	f488a6e84a	feat: add $state.is rune (#11613) ... * feat: add $state.is rune * fix type * tweak docs * may as well update the test case to match the docs --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Dominic Gannaway	1087e6fb54	chore: improve SSR invalid element error message (#11585) ... * chore: improve SSR invalid element error message * move push_element and pop_element into new dev.js file * pass location info, remove unnecessary if (DEV) block * use full filename, basename is not very helpful. also, current_component is guaranteed to not be null * current_element is guaranteed to not be null in pop_element * tweaks * remove message prefix - redundant when filenames are included * add line/column * make message more concise * reduce indirection * only print message once * update test --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Simon H	faced066bd	feat: migrate warnings (#11607) ... Also contains a changeset for the previous work because we forgot that. Also added more code mappings.	1 year ago
Simon H	2bc39b1de2	chore: better ignore code handling (#11606) ... Instead of hacking an ignores array onto each node (and possibly degrading perf a bit because the object shape is mutated) we keep track of ignores in a stack. The new approach also avoids the indirection the old one had to do because the new approach looks upwards (checking if parent is a fragment) instead of iterating the children (checking for comments in them). As a bonus unknown code warnings are now in order (line-column-wise) with the other warnings. Also fixes #11482 because text nodes of all shapes are ok	1 year ago
Rich Harris	5cb432b7bd	feat: warn on unknown warning codes in runes mode (#11549) ... Related to #11414 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 year ago