svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	6bd6f0971b	fix: ensure derived is detected as dirty correctly (#11496 ) Deriveds where under certain conditions not detected as dirty correctly. The reason is that a transitive check_dirtiness call could update the flag of a derived, even if the condition doesn't ulimately result to true. That's why the check for "is now dirty" needs to be moved out of the inner if block. Fixes #11481 This may also fix a yet undetected overfiring bug in the "is unowned" case because the previous inner "is now dirty?" check didn't take unowned into account.	2 years ago

Author

SHA1

Message

Date

Simon H

6bd6f0971b

fix: ensure derived is detected as dirty correctly (#11496 )

Deriveds where under certain conditions not detected as dirty correctly. The reason is that a transitive check_dirtiness call could update the flag of a derived, even if the condition doesn't ulimately result to true. That's why the check for "is now dirty" needs to be moved out of the inner if block.
Fixes #11481

This may also fix a yet undetected overfiring bug in the "is unowned" case because the previous inner "is now dirty?" check didn't take unowned into account.

1 Commits (c5fd24ba3964c6e88f1dbaabc2fd9505f84a099f)