* fix: keep spread non-delegated event handlers up to date
#15961 introduced a regression where non-delegated events that were spread and updated were not getting updated. This fixes that by ensuring prev is actually updated to the most recent value
* fix
* fix: avoid shadowing a variable in dynamic components
* split component name and intermediate name
---------
Co-authored-by: 7nik <kifiranet@gmail.com>
* fix: ensure sources within nested effects still register correctly
When an effect creates another effect and a proxy property is read that wasn't before, the proxy will have logic where it creates the new signal in its original reaction context. But it did not have logic to correctly handle the `reaction_sources` array which prevents effects/deriveds rerunning when state created inside themselves is read and then changed inside them: Since `reaction_sources` wasn't take the reaction context into account, false positives could occur where nested effects would not register the sources as dependencies.
Fixes#15870
* oops forgot to push this
Make sure we track statically visible dependencies and untrack indirect dependencies
Fixes#14351
---------
Co-authored-by: 7nik <kifiranet@gmail.com>
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Closes#16164
We can't set everywhere within with_parent otherwise if it's the first time we are reading a derived it could look like we are setting state in a derived (which you are not).
* Add failing test
* Add {@const} test case
* Fix the bug
* Add yet another test case
* Better fix
* Changeset
* simplify
* this appears to be unnecessary
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* remove code thatcan't be reached and would error if it could
* tidy up types, fix duplication
* this seems needless
* better naming
* tidy up
* reorder
* this code doesn't appear to do anything useful, and no tests fail without it
* unused
* WIP
* revert part of #14811. it makes no sense to show the initial value, it just makes things inconsistent with deriveds. personally i find it more confusing anyway
* explanatory comment on both sides
* make things a bit more self-explanatory
* simplify
* missing type
* only log UpdatedAt for dirty signals
* changeset
* lint
* Revert "unused"
This reverts commit a95b625800.
* complete revert
* ok it works now
* init
* improve symbol logging
* doh
* remove proxy path name when reassigned to a source
* try this
* fix
* oops
* fix
* "unown" proxy when in another source declaration
* fix
* tag proxy version
* proxy bindable props
* tag iterables used in destructuring
* add changeset, fix failing tests
* add comments, minor tweak
* lint
* somehow forgot to add support for class fields
* more class fields
* tag_source -> tag, since it applies to deriveds as well
* private class fields
* this condition is impossible
* explicit type narrowing lets us avoid coercion
* simplify
* unused
* tweak
* oops, never meant to commit that
* minor tweaks
* fix private field tagging, only get `declaration` once
* fix state declarations in constructors
* fix
* tag `svelte/reactivity`, `svelte/motion` sources in DEV
* try fixing lint
* fix intellisense formatting
* actually fix lint
* replace tag_if_necessary with conditional tagging
* avoid [[object Object]] in labels
* remove PROXY_REMOVE_PATH
* simplify a bit
* simplify
* tweak
* tweak implementation
* tweak implementation
* tweak implementation
* hoist
* tweak
* fix
* WIP (reduce number of with_parent calls, move towards possibility of combining tag and tag_proxy)
* DRY out
* tweak labels
* remove PROXY_REMOVE_PATH (#16126)
* remove PROXY_REMOVE_PATH
* simplify a bit
* simplify
* tweak
* tweak implementation
* tweak implementation
* tweak implementation
* hoist
* tweak
* fix
* WIP (reduce number of with_parent calls, move towards possibility of combining tag and tag_proxy)
* DRY out
* come on this was just lazy
* fix tests
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* Add `xmlns` attribute to HTMLAttributes type
The `xmlns` attribute is not only allowed on SVG elements, but on all HTML elements.
* move to DOMAttributes
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: use local mutable sources for props in legacy mode in case they are indirectly invalidated
* rename test
* add another test
* fix
* more conservative
* Update .changeset/orange-tips-pull.md
* skip work in runes mode
* remove comment
* revert whitespace change
* fix: transitions might render animated elements without animation styles applied for the duration of some rendering frames when they starts
* add changeset
* Apply suggestions from code review
---------
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* feat: ssr select value
* fix: adjust test output
* minor aesthetic OCD tweak - the normalizer takes care of this
* fix: handle implicit values
* chore: implicit value test
* fix: deal with spreads on select AND option
* fix: spreading
* chore: add test for cross component
* fix: test
* chore: add failing test
* fix: runtime valueless option selection
* tweak
* fix: snapshots
* fix (options are erroneously being marked as valueless
* simplify a bit (pass callback direct to valueless_option)
* tweak
* tweak ("execute the child" is the sort of thing that gets you visited by the FBI)
* lint
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: warn when using rest or identifier in custom elements without props option
* chore: update message
* tweak message
* update tests
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: make deriveds on the server lazy again
Fixes a regression introduced in #15820: deriveds need to be lazily called on the server, too, since they can close over variables only later defined
Fixes#15960
* fix: handle basic assignment of deriveds on the server
* fix: use `build_assignment_value` for deriveds assignments
* use once
* allow writing to public deriveds on server
---------
Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>
* feat: attachments `fromAction` utility
* fix: typing of the utility
Co-authored-by: Aidan Bleser <117548273+ieedan@users.noreply.github.com>
* simplify implementation - create action first, then only create update/destroy effects if necessary
* add since
* regenerate
* remove FromAction interface
* overload
* fix: use typedef instead of exported interface
* get rid of the arg0, arg1 stuff
* oops
* god i hate overloads
* defer to the reference documentation
* damn ur weird typescript
* gah
---------
Co-authored-by: Aidan Bleser <117548273+ieedan@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: avoid auto-parenthesis for special keywords only `MediaQuery`
* chore: update changeset
* chore: i has english knowledge
* fix: fix media queries with commas
* feat: State declarations in class constructors
* feat: Analysis phase
* misc
* feat: client
* improvements
* feat: It is now at least backwards compatible. though the new stuff may still be wrong
* feat: It works I think?
* final cleanup??
* tests
* test for better types
* changeset
* rename functions (the function doesn't test call-expression-ness)
* small readability tweak
* failing test
* fix
* disallow computed state fields
* tweak message to better accommodate the case in which state is declared after a regular property
* failing test
* wildly confusing to have so many things called 'class analysis' - rename the transform-phrase ones to transformers
* missed a spot
* and another
* store analysis for use during transformation
* move code to where it is used
* do the analysis upfront, it's way simpler
* skip failing test for now
* simplify
* get rid of the class
* on second thoughts
* reduce indirection
* make analysis available at transform time
* WIP
* WIP
* WIP
* fix
* remove unused stuff
* revert snapshot tests
* unused
* note to self
* fix
* unused
* unused
* remove some unused stuff
* unused
* lint, tidy up
* reuse helper
* tweak
* simplify/DRY
* unused
* tweak
* unused
* more
* tweak
* tweak
* fix proxying logic
* tweak
* tweak
* adjust message to accommodate more cases
* unskip and fix test
* fix
* move
* revert unneeded drive-by change
* fix
* fix
* update docs
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: wrap array destructuring in spread to avoid iterator edge case
* spread at `tmp` declaration
* completely rewrite destructuring handling
* only wrap in iife if necessary
* oops
* minor style tweaks
* separate visitors
* tweak
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
* fix: don't spread away `$$slots` from `$props` is it's used
* beef up test
* fix
* Update .changeset/ten-plants-carry.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Simon H
7nik
github-actions[bot]
Rich Harris
Paolo Ricciuti
Matei Trandafir
ComputerGuy
Lyu, Wei-Da
L.
Christoph Sanz
Ray Thurn Void
Hyunbin Seo
Gautier Ben Aïm
Elliott Johnson
Mateusz Kadlubowski
Matteo Battista
Ryan Atkinson