svelte

Commit Graph

Author	SHA1	Message	Date
Nguyen Tran	ed575cc927	fix: make svelte-ignore work above components (#8338 ) Fixes #8082, where svelte-ignore somehow does not pick up the reactive-component warning. The issue on this problem is that the map_children function suppresses warnings and errors while traversing AST nodes as src/compiler/compile/nodes classes. However, the reactive-component warning is called in src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts, and its warnings are not suppressed in map_children. Thus, we need to extract ignores and suppress here separately.	4 years ago
Tan Li Hau	fdc89ebb62	warn if component is expected to be reactive (#4409 )	7 years ago

Author

SHA1

Message

Date

Nguyen Tran

ed575cc927

fix: make svelte-ignore work above components (#8338 )

Fixes #8082, where svelte-ignore somehow does not pick up the reactive-component warning.

The issue on this problem is that the map_children function suppresses warnings and errors while traversing AST nodes as src/compiler/compile/nodes classes. However, the reactive-component warning is called in src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts, and its warnings are not suppressed in map_children. Thus, we need to extract ignores and suppress here separately.

Tan Li Hau

fdc89ebb62

warn if component is expected to be reactive (#4409 )

2 Commits (9425f18e52477193ea04b129ccb4a1a61a86cecf)