svelte

Commit Graph

Author	SHA1	Message	Date
Rich Harris	b19303679d	simplify test slightly, add test for reserved words	9 years ago
Rich Harris	146327e87f	fix expected error position, tweak expected message to include suggested alternative	9 years ago
asweingarten	02afdb03fa	[1083] Svelte should throw a compile time error when illegal characters are used in computed names Approach: For each property name, construct a string that defines a function and see if parsing that string with Acorn throws an exception. If it does, assemble an informative error message that states which property is invalid, the first invalid character, and the location of that character within the name. Changes to codebase: - Added new validator test "properties-computed-must-be-valid-function-names" - Added new check into src/validate/js/propValidators/computed.ts, "checkForValidIdentifiers" - this check was added to src/validate/js/utils/checkForValidIdentifiers.ts like the other checks in "computed.ts"	9 years ago

Author

SHA1

Message

Date

Rich Harris

b19303679d

simplify test slightly, add test for reserved words

Rich Harris

146327e87f

fix expected error position, tweak expected message to include suggested alternative

asweingarten

02afdb03fa

[1083] Svelte should throw a compile time error when illegal characters are used in computed names

Approach:
  For each property name, construct a string that defines a function and see if parsing that string with Acorn throws an exception.
  If it does, assemble an informative error message that states which property is invalid, the first invalid character, and the location of that character within the name.

Changes to codebase:
- Added new validator test
"properties-computed-must-be-valid-function-names"
- Added new check into src/validate/js/propValidators/computed.ts,
"checkForValidIdentifiers"
  - this check was added to
  src/validate/js/utils/checkForValidIdentifiers.ts like the other
  checks in "computed.ts"

3 Commits (7baba8bf8cb8083f1399a1b6446edc94cef0edd8)