11466 Commits (799b1096faa92a2ec0d0b635bdae7ec608a57323)

 

All Branches   

Search

Author	SHA1	Message	Date
Simon Holthausen	799b1096fa	code gold / remove obsolete code (e.g. the "outside reactivity" code is no longer needed because we now mark these deriveds clean if they show the latest value)	12 hours ago
Simon Holthausen	d654c969d3	tweak equality comparisons; keep dependencies not only for forks, and not only reactions but also deps	2 days ago
Simon Holthausen	61f58a5566	we don't need this logic anymore; switch oder of current/previous in update_derived so current batch has correct previous value	3 days ago
Simon Holthausen	08abbd3c96	fix edge case around equal values getting set	3 days ago
Simon Holthausen	d822c50b75	ensure offscreen each items always last; reschedule effects from earlier batches when unskipping	4 days ago
Simon Holthausen	11eddcce48	ensure batches don't "steal" each other's effects (can happen with certain microtask timings)	4 days ago
Simon Holthausen	18219ad1ff	make each blocks fork-aware + fixes around flatten/run seing discarded forks	5 days ago
Simon Holthausen	7018c09247	make await blocks fork-aware	6 days ago
Simon Holthausen	a6221946cf	fix	6 days ago
Simon Holthausen	5dfac3270b	simplify/consolidate fork commit	7 days ago
Simon Holthausen	9d9647dd92	eager fix	7 days ago
Simon Holthausen	de2097595e	fork fixes + simplify/consolidate	7 days ago
Simon Holthausen	1cdc1709d4	fix: robustify async reactivity system (pt2)	3 weeks ago
Simon Holthausen	e19a7530da	revert fork changes	3 weeks ago
Rich Harris	e5e2d16f17	Merge branch 'main' into async-another-try	3 weeks ago
Simon H	98e547535d	fix: flush anything pending before invoking flushSync callback function (#18878) ... no new test here but it's necessary for #18861 to work, and we might as well extract it	3 weeks ago
Simon H	da2f83343b	fix: read batch-local array on each-block commit (#18879) ... Another extraction from #18861 which I'm pretty sure you can also construct a buggy reproduction for today, but with #18861 it's strictly necessary so we don't need to come up with one now	3 weeks ago
Simon Holthausen	894f376b37	Merge branch 'main' into async-another-try	3 weeks ago
Simon Holthausen	48100417b5	simplify	3 weeks ago
Simon Holthausen	54d8c3d843	set deriveds to clean when it's latest value (avoids overfiring); save maybe_dirty deriveds in deferred batches (avoids underfiring that would otherwise happen as a result of the first fix)	3 weeks ago
Rich Harris	58297c5a73	chore: extract some minor changes from #18861 (#18866) ... doing my usual thing of extracting no-brainer changes from a giant PR to try and make it slightly less giant	3 weeks ago
Simon Holthausen	06cfc31f8d	fix jsdoc	3 weeks ago
Simon Holthausen	11b95fe1e8	we don't need the callback anymore	3 weeks ago
Simon Holthausen	08a17b9839	another fork fix	3 weeks ago
Simon Holthausen	df50aa8384	eager batches don't need to run inside forks and don't need to notify them	3 weeks ago
Simon Holthausen	7509485eca	oops	3 weeks ago
Simon Holthausen	957330c89c	feedback	3 weeks ago
Mariana Castro	38098a9311	fix: don't overwrite an unchanged spread `value` (#18864) ... Fixes #18862 When a `value` is applied through a spread (`<input {...props} />`), `set_attributes` always writes `element.value`, even if the element already has that value. Writing `value` on a number input clears any incomplete text: typing `250.` makes `input.value` `''` (the text is still visible, but `validity.badInput` is `true`). If the spread `value` then becomes `''` too, writing `''` erases what the user typed. This is what happens with SvelteKit remote forms: `fields.quantity.as('number')` coerces `''` to `undefined`, the spread `value` becomes `''`, and Svelte writes it back to the input. When `.` is typed: - Chromium clears the input in every locale, because `250.` is always incomplete input there. - WebKit/Safari clears it in locales where `.` is not the decimal separator (e.g. `fr-CH`), which is where the reporter saw it. A plain `<input type="number">` never clears. Neither does the same `value` in Svelte without a spread (`value={...}`), because `set_value` already skips writing when `element.value === value`. This PR adds the same check to the spread path. Svelte 3 had this check too (#3426, #3495); it was lost in Svelte 5. The first write still always happens. Writing `value` sets the input's dirty value flag, and without that flag a `defaultValue` applied afterwards would change the current value (covered by `form-default-value-spread`). This also likely affects sveltejs/kit#16270 (same symptom, plus a cursor jump caused by redundant writes). That issue is handled on the kit side in sveltejs/kit#16320; this PR is independent of it. The test runs in a real browser (`runtime-browser`). It types with `document.execCommand('insertText')`, which goes through Chromium's own editing, so `250.` is real incomplete input. The locale is not mocked. The test fails without this change and passes with it. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>	3 weeks ago
Tee Ming	325620ba63	fix: bypass error boundaries for hydration recovery (#18841) ... Fixes #18840 This PR rethrows the hydration error rather than catching it at the boundaries so that the svelte hydration warning can surface ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>	3 weeks ago
Simon Holthausen	87a061a73f	consolidate (maybe_)dirty_effects and dirty_deriveds	3 weeks ago
Simon Holthausen	4d8f4410f7	perf	3 weeks ago
Kunpeng Xie	803f59b171	fix: avoid reinserting dynamic elements during hydration (#18855) ... Hydrating a `<svelte:element>` currently removes and reinserts the DOM node that was already claimed from the server-rendered HTML. This can restart CSS animations and disconnect/reconnect custom elements inside it. Keep claimed elements in place while preserving insertion for client-created elements and later tag changes. Capture the hydration state before rendering children, since empty or void elements can temporarily turn hydration off. Fixes #18852. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Validation: - The real Chromium regression fails on unchanged `636eaaaa`: hydration removes all four server-rendered dynamic elements. Client mounting and server rendering pass. - The regression checks node removals and custom-element connection callbacks for ordinary, empty, void, and custom dynamic elements, then changes the tags and removes/recreates an element. - A hydration mismatch regression verifies that different client/server child branches recover while retaining the outer element and its following sibling. - `pnpm test hydration runtime-browser`: 219 passed. - Full `CI=true pnpm test`: 34 test files passed, 7,790 tests passed, 55 existing skips. The real-browser suite ran with Chromium. - `pnpm check`: passed, including build, generated type checks, and treeshakeability checks. - `pnpm lint`: passed. AI assistance: This change and its tests were prepared with OpenAI Codex. The PR description is also AI-assisted. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	3 weeks ago
Simon Holthausen	9fd77d22a5	another	3 weeks ago
Simon Holthausen	408d51b362	tuple->object	3 weeks ago
Simon Holthausen	bd0faecdaa	explanatory comment, remove obsolete deletion	3 weeks ago
Simon Holthausen	494c8b9f08	another	3 weeks ago
Simon Holthausen	3b92502f00	codegolf	3 weeks ago
Simon Holthausen	b08aeee3cf	fix more edge cases	3 weeks ago
Simon Holthausen	7005aae212	more edge case fixes	3 weeks ago
Simon Holthausen	ba4d37a4b4	belts and braces	3 weeks ago
Simon Holthausen	32f4451f2e	fix flushSync (should drain queue before calling the function)	3 weeks ago
Simon Holthausen	31524c792e	e prop for sources	3 weeks ago
Simon Holthausen	91d215664f	resolve some todos	3 weeks ago
Simon Holthausen	15ccee8e0f	cleanup	3 weeks ago
Simon Holthausen	ddffe3efe2	align	3 weeks ago
Simon Holthausen	62fafd63ab	align	3 weeks ago
Simon Holthausen	5de9201dc2	tweak	3 weeks ago
Simon Holthausen	64bd3a18f1	tweak test for new behavior	3 weeks ago
Simon Holthausen	d592d8aebd	original test obsolete, refactor into a new test	3 weeks ago
Simon Holthausen	387995cd63	remove some dead weight	3 weeks ago