svelte

Commit Graph

Author	SHA1	Message	Date
Paolo Ricciuti	90807ca18d	fix: properly hydrate dynamic css props components and remove element removal (#16118 )	5 months ago
Paolo Ricciuti	fbb6444fd8	fix: allow using typescript in `customElement.extend` option (#16001 ) Closes #15372 --------- Co-authored-by: Dominik G. <dominik.goepel@gmx.de>	6 months ago
Paolo Ricciuti	d1141a19b5	feat: functional template generation (#15538 ) Co-authored-by: Rich Harris <rich.harris@vercel.com>	6 months ago
Rich Harris	b82692af2f	feat: add `idPrefix` to `render` (#15428 ) This ensures someone like Astro can render multiple islands and the unique ids produced in them are able to be deduplicated --------- Co-authored-by: Hugos68 <hugokorteapple@gmail.com> Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	9 months ago
Dominic Gannaway	36ef59df1f	chore: improve test cases (#14984 ) * chore: improve test cases * lint	10 months ago
Simon H	88a15cd706	chore: TS fixes cleanup (#14750 ) * chore: TS fixes cleanup - move a test - revert seemginly unnecessary code changes * add another test	11 months ago
Taku Fukada	c79b909458	fix: remove 'implements' from class declaration (#14749 ) * fix: remove implements from class declaration * add a smoke test	11 months ago
Simon H	a2539cfe1f	fix: correctly set custom element props (#14508 ) fixes #14391 In #13337 the "when to set as a property" logic for custom elements was adjusted. A bug was introduced during this, and it consists of several parts, of which the latter I'm not sure what's the best solution, hence opening this to discuss. The problem is that during set_custom_element_data, get_setters is the only check done to differentiate between setting the value as a prop (has a setter) or as an attribute (doesn't have a setter). The solution is to take into account whether or not the custom element is already registered, and defer getting (and caching) its setters until then. Instead, fall back to a "an object is always set as a prop" heuristic.	11 months ago
Simon H	cfc1fb7de8	chore: provide links to documentation for errors/warnings (#14629 ) * chore: provide links to documentation for errors/warnings closes #11305 * changeset * fix most of the tests * fix mutations messing with nodes between runs * more concise * more test fixes * last one	11 months ago
Ben McCann	4c88431228	fix: upgrade to esm-env 1.2.1 to fix issues with non-Vite setups (#14470 ) * fix: upgrade to esm-env 1.2.1 to fix issues with non-Vite setups * fix (albeit with annoying warnings) * bundle with conditions to silence noise * production is probably better --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	12 months ago
Simon H	7d11fa8da2	fix: recognize all custom element prop definitions (#14084 ) We didn't account for the `$props` rune being writtin in a way that makes some props unknown, and they would only be visible through the `customElement.props` definition. This changes the iteration to account for that and also adds a note to the documentation that you need to list out the properties explicitly. fixes #13785	1 year ago
Dominic Gannaway	cdec39afac	fix: ensure custom element attribute/prop changes are in their own context (#14016 ) Fixes #13848. When we set custom element attributes/props, we should be doing so without the current effect/reaction active. Otherwise, the custom element lifecycle might attach effects/dependencies to the wrong reaction and all manner of things can incorrectly occur --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 year ago
Dominic Gannaway	0466e40680	breaking: use `<svelte-css-wrapper>` instead of `<div>` for style props (#13499 ) * breaking: use <span> instead of <div> for style props * breaking: use <span> instead of <div> for style props * use custom element * docs	1 year ago
adiGuba	9627426f7f	fix: ensure single script and scripts in loops execute properly (#13386 ) - add a comment to lone script tags to ensure there's always a parent so we can synchronously call the replace function - always call the replace function, not just on the first call fixes #13378 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 year ago
Simon H	d338e8083f	fix: simplify and robustify appending styles (#13303 ) #13225 did not fully fix the described issue: As soon as you have a child component, that child component's anchor will not be in the right ownerDocument yet, and so the logic falls down. To fix that, we would need to move the ownerDocument check into the microtask - and that map check was mainly done to avoid just that. So instead I opted to simplify the code and just remove the map checks. According to my benchmarking (https://jsbench.me/3hm17l0bxl/1) this has no impact on performance assuming that you'll have cache hits roughly half the time - and even if you'd have much more cache hits, the performance loss is microscopic. Given that the default mode is to not inject styles, this will not be common anyway, so I favor removing that map.	1 year ago
James Glenn	c229e0f80b	feat: a11y warning for `<button>` / `<a>` without aria-label and content (#13130 ) * Introduce button a11y warnings * Log changeset * Don't check for label if aria-hidden * State based flag to avoid multiple warnings firing * Update existing validators to include aria labels * false positives are okay, false negatives aren't * prefer text over aria-label in tests * remove unnecessary aria-labels * tweak message * update test * fix * simplify * various * DRY out * Apply suggestions from code review --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	1 year ago
Maxime LUCE	5210ae2610	fix: allow component to be mounted in iframe (#13225 ) * fix: allow component to be mounted in iframe * prettier * prettier * fix: allow HMR cleanup styles in iframe and custom elements * add test * avoid creating unnecessary microtasks * simplify * rename stuff * typo * lint * changeset * changeset --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	1 year ago
Paolo Ricciuti	09dff9bde2	fix: allow custom element events on slot to bubble inside custom element (#13222 ) Fixes #13162 We were going from parentNode to parentNode but if something is a slot of a custom element we should first go to the assignedSlot or else the inside of the custom element will be skipped. --------- Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>	1 year ago
Simon H	c372dd864d	fix: ensure inner script tags are properly removed (#13152 ) We have a `run_scripts` function which is invoked in case a template block contains a script tag, and that function replaces the script tags (so that they actually run). If such a script tag is first or last in the template, the replacement is not picked up by our `node.first_node/last_node` logic anymore, and so it contains a stale tag. That means on cleanup the remove logic fails. In the case of the referenced issue, it just runs past the script tag till the very end of the head, removing the just added style tag from the new page. Fixes #13086	1 year ago
Dominic Gannaway	2d37826ee1	fix: ensure $host rune correctly compiles in variable declarations (#13127 ) Fixes #13121	1 year ago
Theodor Steiner	7ae21ea97d	feat: make <svelte:option> customElement configuration's tag property optional (#12751 ) (#12754 ) * feat: make svelte:option customElement tag property optional (#12751) * tweak comment * tweak docs * tweak some more wording * Update .changeset/four-kids-flow.md --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <hello@rich-harris.dev>	1 year ago
Dominic Gannaway	ba116a1b43	fix: propagate custom element component prop changes (#12774 ) * fix: propagate custom element component prop changes * add test	1 year ago
Dominic Gannaway	d8954d7add	fix: ensure custom elements do not sync flush on mount (#12787 ) * fix: ensure Svelte4Components do not sync flush * fix: ensure Svelte4Components do not sync flush * lint * feedback * simplify test, remove redundant comments * prettier * fix test --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Dominic Gannaway	c32a91891f	fix: ensure event handlers referencing $host are not hoisted (#12775 )	1 year ago
Simon H	0f41689916	chore: unskip more tests (#12621 )	1 year ago
Dominic Gannaway	afa3128d2f	breaking: avoid flushing queued updates on mount/hydrate (#12602 ) * Revert "Revert "breaking: avoid flushing queued updates on mount/hydrate" (#1…" This reverts commit `8d139210b7`. * fix legacy wrapper * lint * docs * duplicate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	8d139210b7	Revert "breaking: avoid flushing queued updates on mount/hydrate" (#12593 ) * Revert "breaking: avoid flushing queued updates on mount/hydrate (#12587)" This reverts commit `20b879717a`. * Update packages/svelte/src/internal/client/render.js	1 year ago
Dominic Gannaway	20b879717a	breaking: avoid flushing queued updates on mount/hydrate (#12587 ) * breaking: avoid flushing queued updates on mount/hydrat * Fix tests * Update packages/svelte/src/internal/client/render.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * tweak * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Damian Stasik	84325bf89b	chore: use JSDoc type imports in more files (#12239 ) * chore: use JSDoc type imports in more files * Location_1 -> Location * merge * fix * oops --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Simon H	d959d4afbe	fix: make media bindings more robust (#12206 ) The media bindings where fragile because the "prevent rerun if update in progress"-logic was flawed: It didn't (re)set the `updating` flag correctly, because it assumed an event and a render effect would always directly follow each other, with one always being first - but that's not true. It's much more robust to instead compare the value with what's currently present in the DOM. For the very fast-firing current-time-binding a variable is used to not invoke the DOM getter as much, for the others this is not necessary. Lastly, the playback-rate-binding contained another bug where the listener was setup inside the effect and therefore reinitialized on each binding change - it needs to move into a different effect.	1 year ago
Paolo Ricciuti	6655f2c5d2	feat: better dynamic component css props (#11792 ) * feat: better dynamic component css props * chore: fix tests * chore: remove anchor from `$.component` * chore: better old test fixing * changeset --------- Co-authored-by: Rich Harris <hello@rich-harris.dev>	1 year ago
Dominic Gannaway	7714c934fe	chore: deprecate html in favour of body for render() (#11927 ) Closes #11281	1 year ago
FoHoOV	b963e53fc9	fix: parse ongotpointercapture and onlostpointercapture events correctly (#11790 ) Fixes #11789	2 years ago
Dominic Gannaway	44115840bd	chore: cleanup more tests (#11738 ) remove awaits in favor of flushSync	2 years ago
Paolo Ricciuti	34079a0ec5	fix: restore value after attribute removal during hydration (#11465 ) Fix #11457	2 years ago
Simon H	eb7e32c168	fix: collect all necessary setters of html elements (#11371 ) When spreading attributes, the setters of the element are checked. If they contain the key in question, it's set via that setter. For certain setters on certain elements this didn't work because the element prototype was not HTMLElement, rather a descendant of that (for example HTMLDivElement), which meant that only the setters of the descendant, not the superclass were taken into account. This fixes that by walking up the prototype chain until we find the Element prototype. fixes #11179	2 years ago
Rich Harris	8e17428316	chore: tidy up messages (#11327 ) * start reorganising messages * tidy up * more * more * more * alphabetise * consolidate * more * more * more * more * more * more * alphabetise * more * this is no longer needed * no longer necessary * more * more * fix * regenerate messages * more * more * tighten up rune validation * more * fix * more * tweak a11y messages * add server errors * overhaul runtime errors * regenerate messages * unused * lint * more * more * Update packages/svelte/messages/compile-errors/script.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * Update packages/svelte/messages/client-warnings/warnings.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	2 years ago
Rich Harris	476f2172b6	fix: mark `accessors` and `immutable` as deprecated (#11277 ) * fix: mark `accessors` and `immutable` as deprecated * add warnings for deprecated <svelte:options> attributes * disable accessors in runes mode * update tests * tidy up * the hell? * regenerate types * if I would get a dollar for every windows bug I fix I would be a millionaire by now * return instance _and_ props in runes mode, move flushSync into shared code, don't set accessors in runes mode * goddammit * note breaking change * fix * regenerate messages * Revert "return instance _and_ props in runes mode, move flushSync into shared code, don't set accessors in runes mode" This reverts commit `a47827e57d`. * pass instance to tests --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 years ago
Rich Harris	7b55bd4d89	chore: markdown warnings (#11302 ) * rename warnings.js to warnings-tmp.js * start porting warnings * centralise stuff * finish porting warnings * tidy up * get messages into JSDoc annotations * prettier * lint	2 years ago
Rich Harris	fd5f5bb85d	monkey-patch console.log and console.warn for all tests (#11265 ) * monkey-patch console.log and console.warn for all tests * update legacy tests * various * tests passing * tidy up * tidy up * tidier output	2 years ago
Rich Harris	42ce8d74e1	breaking: warn on self-closing non-void HTML tags (#11114 ) * warn on self-closing non-void HTML tags * fix tests * changeset * account for foreign namespace	2 years ago
Simon H	5a1c756a4e	fix: execute sole static script tag (#11095 ) - take into account that template could consist of a single script tag, for which querySelectorAll('script') would yield false negatives - add test to ensure that we don't execute script tags inside `@html` tags next to static script tags fixes #11082	2 years ago
Simon H	22494be9ec	feat: introduce `$host` rune, deprecate `createEventDispatcher` (#11059 ) closes #11022	2 years ago
Rich Harris	eaa243d2da	chore: reshuffle some code (#10967 ) * remove superfluous .d.ts file * remove main/main-client.js to index-client.js * move main/main-server.js to index-server.js * move main/public.d.ts to index.d.ts * move ambient.d.ts * fix * fix	2 years ago
Rich Harris	2079e675ea	replace skip_if_ssr and skip_if_hydrate with modes (#10956 )	2 years ago
Rich Harris	4fcedb2fb1	chore: simplify hydration (#10943 ) * WIP * unused * unused * fix head hydration * working * simplify * tighten up * css props * fix treeshaking * add a comment	2 years ago
Simon H	fff3320517	chore: custom elements validation (#10720 ) - add "missing customElement option" warning - add backwards compat support for customElement={null}	2 years ago
Simon H	767b5a8824	chore: remove obsolete test (#10679 ) Checking for expected or unexpected props in 2024 is the job TypeScript, and runtime validation has resulted in false positives previously - therefore leave this out in Svelte 5. closes #10672	2 years ago
Rich Harris	6afaf75a37	fix: synchronise element bindings (#10512 ) fixes #10511 We used the animation frame dance previously where the `$effect` timing was slightly different and did not wait on its children before rerunning. With that changed now everything false into place nicely. --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 years ago
Simon H	08978bfae8	fix: don't execute scripts inside `@html` when instantiated on the client (#10556 ) In Svelte 4, scripts inside `@html` were not executed when it was created client-side. This is because `innerHTML = ..` which was used under the hood does not execute scripts due to security reasons. This adjusts the code so the same is true for Svelte 5.	2 years ago

1 2

56 Commits (6e1c89f4487b869989b6011c124a4aea5313c3af)