svelte

Commit Graph

Author	SHA1	Message	Date
Ray Thurn Void	9e1e7139fb	fix: robustify reset calls in error boundaries (#16171 ) Fixes #16134 * Add a warning when the misuse of `reset` in an `error:boundary` causes an error to be thrown when flushing the boundary content * Prevent uncaught errors to make test fails when they are expected and are fired during template effects flush * reset should just be a noop after the first call * correctly handle errors inside boundary during reset * handle errors in the correct boundary --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 months ago
Rich Harris	2e49783afa	docs: fix code snippets (#16367 )	4 months ago
Rich Harris	0672e48223	feat: allow `await` in components (#15844 ) * tidy * tidy * yes it can, apparently * tidy up * unused * complete merge * WIP * simplify * debugging help * WIP * unused * partial merge * WIP * fix * add test * rename * fix * unused * oops * chore: merge main into async branch (#16197) * chore: merge main into async branch * adjust test * fix: make effects depend on state created inside them (#16198) * make effects depend on state created inside them * fix, add github action * disable test in async mode * make batch.#deferred private * fix settled when awaits occur inside pending boundary * tweak * change behaviour of `tick()` to be requestAnimationFrame-based * get rid of a bunch of Promise.resolve chains * more * more * fix test * disallow `flushSync()` inside effects * regenerate * handle errors in block expressions * make validate_each_keys async-aware * for unowned deriveds, throw errors lazily * rename ASYNC_ERROR -> ERROR_VALUE, and avoid conflicts with other flags now that it's used with deriveds as well as sources * invoke boundary directly * local effect pending * update test * fix * fix * fix weird bug in tests * delete old changeset that somehow got left over here * Update .changeset/eleven-weeks-dance.md * update error details * unused * simplify * tweak * tweak * tweak * tweak * tidy up * handle errors in async block expressions * tweak * groundwork for async attribute_effect * dry out * fix async directives * tidy up * initialize option values before initing select values * simplify init_select * simplify * tweak * tidy up * tweak * on second thoughts just simplify it here * tidy * handle awaits in `<slot>` * unused * tidy up * tidy up * dry out * dry out * Revert "dry out" This reverts commit `25855163bf`. * dry out * dry out * use let for block-scoped stuff * dry out * dry out * tidy up * only wrap awaits in `$.save` when necessary * oops * remove TODO comment (just checked) * oops, leftover * simplify * unused * remove logging * tweak * unused * unused * remove logging * partial fix * fix * remove unused EFFECT_HAS_DERIVED * Update packages/svelte/src/reactivity/create-subscriber.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/index-client.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/runtime.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * unused * Update packages/svelte/src/internal/client/reactivity/sources.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier * unused * fix flags * tweak * tweak * unused * fix * no idea what a 'boundary micro task' is or why it was deemed necessary but evidently it isn't * remove queue_boundary_micro_task * oops * note * tidy up * remove TODO * make method private * simplify * flesh out await_reactivity_loss warning * tweak * update test * fix * null out from_async_derived in more places * tidy up test * failing test * unused * fix test * fix * simplify. no idea what the async_mode_flag stuff is about, but it appears unnecessary * add async_derived_orphan error * regenerate * flesh out await_outside_boundary message * add some JSDoc * only update `$effect.pending()` if someone is listening, since it causes a double flush and makes debugging harder * tweak logic to make it clearer why and when we commit a batch * add a couple of comments * false -> 0 * add comment * unused * silence warning * add effect_pending_outside_reaction error * Update packages/svelte/src/compiler/types/index.d.ts Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * suspend batch, not boundary * rename from_async_derived -> current_async_derived * tweak * remove TODO - this method is only called when pending snippet exists * use error boundary for test - vitest does some weird error swallowing afaict * flush less often * restore -> activate * remove TODO * move batch-related code into batch.js * make flush_queued_root_effects a method of batch * make process_effects a method of batch * make stuff private * unused * regenerate * update test * more JSDoc * add more JSDoc * branch and block effects do not also need to be render effects * tidy up * simplify * unused * move code where it belongs * remove, for now * fix * only apply error adjustments when error escapes boundaries * remove EFFECT_IS_UPDATING * is_dirty is a better name than check_dirtiness * duplicates are rare and harmless * apparently we no longer need the merging logic? we can simplify and fix stuff by removing it * tidy * don't commit stale batches * add skipped failing test * partial merge * WIP * WIP * WIP * tweak * tidy up * dont update derived status when time-travelling * tidy up * tidy up * tag async deriveds * tweak * bail out of secondary flushes * re-run blocks on subsequent flushes * add test * fix * add tests, one failing * fix * flesh out await_waterfall message * tidy up * dry out * unused * tweak * tidy up * TODO * tweak * tidy up * remove TODO * unused export * add optimisation back * revert unneeded changes * revert * update some tests * more * more * move some code * rename * WIP * unset context synchronously * remove unused argument * Apply suggestions from code review Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * add comment * add comment * use queue_micro_task in createSubscriber * Update packages/svelte/src/compiler/phases/3-transform/client/visitors/AwaitExpression.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	4 months ago
Gautier Ben Aïm	de8094910d	fix(14815): warn when an invalid <select multiple> value is given (#14816 ) * fix(14815): warn when an invalid <select multiple> value is given * Create nervous-stingrays-travel.md	5 months ago
Simon H	98d14ece66	fix: rework binding ownership validation (#15678 ) * remove old validation * fix: rework binding ownership validation Previously we were doing stack-based retrieval of the owner, which while catching more cases was costly (performance-wise) and prone to errors (as shown by many issues over the months). This drastically simplifies the ownership validation - we now only do simple static analysis to check which props are mutated and wrap them with runtime checks to see if a binding was established. Besides making the implementation simpler and more performant, this also follows an insight we had over the months: Most people don't really know what to do with this warning when it's shown beyond very simple cases. Either it's not actionable because they don't really know how to fix it or they question if they should at all (in some cases rightfully so). Now that the warning is only shown in simple and easy-to-reason-about cases, it has a much better signal-to-noise-ratio and will hopefully guide people in the right direction early on (learn from the obvious cases to not write spaghetti code in more complex cases). closes #15532 closes #15210 closes #14893 closes #13607 closes #13139 closes #11861 * remove some now obsolete tests * fix * better warnings now that we have more info * fix * hoist * we only care about mutation, not reassignment * tidy * handle prop aliases * mutation validation is only tangentially linked to context requirement * no need for two vars, one will do * update warning, include mutation location * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	7 months ago
Rich Harris	d41801c75f	feat: warn on using `slide` transition with invalid `display` styles (#14936 ) * feat: warn on using `slide` transition with table elements * more generic * more generic	10 months ago
Rich Harris	97f3aa9151	docs: fix links in some errors/warnings (#14825 ) * fix links in some errors/warnings * fix	10 months ago
Simon H	68d266e0f8	fix: remove overzealous `reactive_declaration_non_reactive_property` warning (#14663 ) fixes #14532 This removes the `reactive_declaration_non_reactive_property` warning altogether. The first version caused many false positives at compile time. The refined runtime version (introduced in #14192) was hoped to fix this, but it turns out we now get loads of false positives at runtime.	11 months ago
Simon H	c6fca02009	docs: more details for errors/warnings on the site (#14632 ) * docs: more details for errors/warnings on the site Related to #11305 * Apply suggestions from code review Co-authored-by: Rich Harris <rich.harris@vercel.com> * fix in correct place * tab not spaces * tweaks * fix * Apply suggestions from code review * regenerate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	11 months ago
Rich Harris	4c4f18b24c	chore: fix docs (#14538 )	11 months ago
Rich Harris	fe0bd299a5	fix: proxify values when assigning using `\|\|=`, `&&=` and `??=` operators (#14273 ) * add failing test for #14268 * simplify * proxify values when using \|\|=, &&= and ??= assignment operators * proxify values assigned to private state fields * changeset * fix * fix * add warning * update test	11 months ago
Rich Harris	a5de086f95	feat: turn `reactive_declaration_non_reactive_property` into a runtime warning (#14192 ) * turn `reactive_declaration_non_reactive_property` into a runtime warning * ignore warning * Update packages/svelte/src/internal/client/reactivity/effects.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * Update packages/svelte/src/internal/client/runtime.js Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * fix * test * changeset * Update .changeset/witty-turtles-bake.md Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * add some details * check * regenerate --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	11 months ago
Conduitry	2ab70041fd	chore: mark markdown output from process-messages as generated (#13913 ) * chore: mark markdown output from process-messages as generated * regenerate	1 year ago
Richard Smith	e99e865291	docs: update links to point to new site (#13986 ) Update (some) of the links pointing to the old preview site as mentioned in #13982. This updates all the links in documentation/ and packages/svelte/messages, but doesn't touch others present in packages/svelte/ or fix the original link in that issue.	1 year ago
Paolo Ricciuti	8ff2af52d3	fix: show filename information in `legacy_recursive_reactive_block` (#13764 )	1 year ago
Dominic Gannaway	139114bdcb	fix: ensure legacy run utility does not cause cycles (#13643 ) * fix: ensure legacy run utility does not cause cycles * add warning * add warning * lint * feedback * lint * lint	1 year ago
Simon H	4578d4f25a	docs: generate pages for compiler/runtime warnings/errors (#13557 ) * docs: generate pages for compiler/runtime warnings/errors Ideally each warning has accompanying details so that it doesn't look so empty on the final site, but that can happen separately * fix * sort alphabetically, code ticks for headings * only uppercase first word * regenerate * generate codes using [!NOTE], remove any backticks and escape `<` characters * some prose preceeding the list of compiler warnings * bring over prose from Svelte 4 a11y warnings * fix * lint * remove backticks from headers, now that they are getting rendered * Revert "remove backticks from headers, now that they are getting rendered" This reverts commit `c295281848`. * back to normal headers/code blocks * fix * separate authored from generated stuff * newlines --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago

17 Commits (6534aa08e32b3c2d09c2ffb06e4ae7a18fdffa30)