svelte

Commit Graph

Author	SHA1	Message	Date
gtmnayan	783bd9899e	chore: swap mocha with vitest (#8584 ) Also swap out the require hook hacks with a less-hacky-but-still-somewhat-hacky loader for the Svelte files --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Rich Harris <richard.a.harris@gmail.com>	2 years ago
Filip Ambrosius	1333be0c6a	fix: Regression `itemscope` as `boolean_attribute` (#8414 ) Microdata are a strange set of attributes which are ONLY defined in markup, and have no relationship to the underlying Document Object Model node. As such programmatically defining an element and setting a property on it with a given Microdata attribute will not work: https://codepen.io/iambrosius/full/jOvXBBG One can read more about microdata here: https://developer.mozilla.org/en-US/docs/Web/HTML/Microdata The fix is to remove itemscope being a boolean attribute, because that opts into a transformation as a DOM property, which is wrong.	3 years ago

Author

SHA1

Message

Date

gtmnayan

783bd9899e

chore: swap mocha with vitest (#8584 )

Also swap out the require hook hacks with a less-hacky-but-still-somewhat-hacky loader for the Svelte files

---------

Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>

Filip Ambrosius

1333be0c6a

fix: Regression `itemscope` as `boolean_attribute` (#8414 )

Microdata are a strange set of attributes which are ONLY defined in markup, and have no relationship to the underlying Document Object Model node. As such programmatically defining an element and setting a property on it with a given Microdata attribute will not work:
https://codepen.io/iambrosius/full/jOvXBBG

One can read more about microdata here: https://developer.mozilla.org/en-US/docs/Web/HTML/Microdata

The fix is to remove itemscope being a boolean attribute, because that opts into a transformation as a DOM property, which is wrong.

2 Commits (5dd707d4f5565961bcc443765fbd8b0f90a6abc2)