svelte

Commit Graph

Author	SHA1	Message	Date
Dominic Gannaway	2382eb08c5	fix: improve reactive Map and Set implementations (#11827 ) Closes #11727. This PR aims to tackle issues around our reactive Map/Set implementations. Notably: - We now store the values on the backing Map/Set, allowing for much better introspection in console/dev tools - We no longer store the values inside the source signals, instead we use Symbols and booleans only as markers There's one limitation around `.has(x)` when `x` is not in the Map/Set yet - it's not fine-grained. Making it so could create too much memory pressure when e.g. iterating a big list of items with few of them being in the set (`has` returns `false` most of the time).	2 years ago

Author

SHA1

Message

Date

Dominic Gannaway

2382eb08c5

fix: improve reactive Map and Set implementations (#11827 )

Closes #11727.

This PR aims to tackle issues around our reactive Map/Set implementations. Notably:

- We now store the values on the backing Map/Set, allowing for much better introspection in console/dev tools
- We no longer store the values inside the source signals, instead we use Symbols and booleans only as markers

There's one limitation around `.has(x)` when `x` is not in the Map/Set yet - it's not fine-grained. Making it so could create too much memory pressure when e.g. iterating a big list of items with few of them being in the set (`has` returns `false` most of the time).

1 Commits (4c56ac5b8a48e536bbaf92ac1ec9b1f82005bc95)