svelte

Commit Graph

Author	SHA1	Message	Date
Rich Harris	9a09f02901	tweak messages	11 months ago
Rich Harris	ec82e9bf6a	tweak error codes to better align with existing conventions, such as they are	11 months ago
S. Elliott Johnson	f6d3894ea8	I have lost the plot	11 months ago
S. Elliott Johnson	fc84ada257	errors:	11 months ago
Rich Harris	fbef4bbd7c	remove await_outside_boundary error (#16762 )	11 months ago
S. Elliott Johnson	380f45725b	Merge branch 'elliott/effect-pending-correct-boundary' into adjust-boundary-error-message	11 months ago
S. Elliott Johnson	3c73cc703a	feat: first hydrationgaa	11 months ago
Simon H	a60995abef	fix: allow async `{@const}` in more places (#16643 ) Implemented by reusing the `async_body` function inside `Fragment.js`. Also removes the ability to reference a `{@const ...}` of an implicit child inside a boundary pending/failed snippet: - existing duplication of consts can have unintended side effects, e.g. async consts would unexpectedly called multiple times - what if a const is the reason for the failure of a boundary, but is then referenced in the failed snippet? - what if an async const is referenced in a pending snippet? deadlock - inconsistent with how it behaves for components where this already does not work Implemented via the experimental flag so the behavior change only applies there as this is a breaking change strictly speaking. Also added a compiler error for this. closes #16462	11 months ago
Rich Harris	e7e8a9c7b7	docs: remove 'thus', fix some phrasing (#16559 )	1 year ago
Anthony	a3f18351af	docs: corrections (#16550 ) * Add missing hyphen in "server-side rendering" * Fix incorrect use of "as such" * regenerate types --------- Co-authored-by: Chew Tee Ming <chew.tee.ming@nindatech.com>	1 year ago
ComputerGuy	8067841170	docs: add note about attachments to `svelte/action` docs (#16537 )	1 year ago
fkobi	1773df9484	docs: use sh instead of bash in source blocks (#16506 ) * use sh instead of bash in source blocks no bash-specific functionality is used * regenerate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
ComputerGuy	b0f9ea3ae6	fix: throw on duplicate class field declarations (#16502 ) * fix: throw on duplicate class field declarations * doh * handle assignment in constructor * fix * apply suggestion from review * fix * fix failing test	1 year ago
Ray Thurn Void	9e1e7139fb	fix: robustify reset calls in error boundaries (#16171 ) Fixes #16134 * Add a warning when the misuse of `reset` in an `error:boundary` causes an error to be thrown when flushing the boundary content * Prevent uncaught errors to make test fails when they are expected and are fired during template effects flush * reset should just be a noop after the first call * correctly handle errors inside boundary during reset * handle errors in the correct boundary --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	e5e6c0cd12	fix docs (#16409 ) * fix docs * oops * another * gah	1 year ago
Rich Harris	a67b5862f1	fix: more informative error when effects run in an infinite loop (#16405 ) * update effect_update_depth_exceeded docs * log update locations * remove dev_effect_stack stuff, it's not very helpful * tidy up * test * fix test * changeset * fix	1 year ago
Rich Harris	2e49783afa	docs: fix code snippets (#16367 )	1 year ago
Rich Harris	0672e48223	feat: allow `await` in components (#15844 ) * tidy * tidy * yes it can, apparently * tidy up * unused * complete merge * WIP * simplify * debugging help * WIP * unused * partial merge * WIP * fix * add test * rename * fix * unused * oops * chore: merge main into async branch (#16197) * chore: merge main into async branch * adjust test * fix: make effects depend on state created inside them (#16198) * make effects depend on state created inside them * fix, add github action * disable test in async mode * make batch.#deferred private * fix settled when awaits occur inside pending boundary * tweak * change behaviour of `tick()` to be requestAnimationFrame-based * get rid of a bunch of Promise.resolve chains * more * more * fix test * disallow `flushSync()` inside effects * regenerate * handle errors in block expressions * make validate_each_keys async-aware * for unowned deriveds, throw errors lazily * rename ASYNC_ERROR -> ERROR_VALUE, and avoid conflicts with other flags now that it's used with deriveds as well as sources * invoke boundary directly * local effect pending * update test * fix * fix * fix weird bug in tests * delete old changeset that somehow got left over here * Update .changeset/eleven-weeks-dance.md * update error details * unused * simplify * tweak * tweak * tweak * tweak * tidy up * handle errors in async block expressions * tweak * groundwork for async attribute_effect * dry out * fix async directives * tidy up * initialize option values before initing select values * simplify init_select * simplify * tweak * tidy up * tweak * on second thoughts just simplify it here * tidy * handle awaits in `<slot>` * unused * tidy up * tidy up * dry out * dry out * Revert "dry out" This reverts commit `25855163bf`. * dry out * dry out * use let for block-scoped stuff * dry out * dry out * tidy up * only wrap awaits in `$.save` when necessary * oops * remove TODO comment (just checked) * oops, leftover * simplify * unused * remove logging * tweak * unused * unused * remove logging * partial fix * fix * remove unused EFFECT_HAS_DERIVED * Update packages/svelte/src/reactivity/create-subscriber.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/index-client.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/runtime.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * unused * Update packages/svelte/src/internal/client/reactivity/sources.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * Update packages/svelte/src/internal/client/reactivity/deriveds.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier * unused * fix flags * tweak * tweak * unused * fix * no idea what a 'boundary micro task' is or why it was deemed necessary but evidently it isn't * remove queue_boundary_micro_task * oops * note * tidy up * remove TODO * make method private * simplify * flesh out await_reactivity_loss warning * tweak * update test * fix * null out from_async_derived in more places * tidy up test * failing test * unused * fix test * fix * simplify. no idea what the async_mode_flag stuff is about, but it appears unnecessary * add async_derived_orphan error * regenerate * flesh out await_outside_boundary message * add some JSDoc * only update `$effect.pending()` if someone is listening, since it causes a double flush and makes debugging harder * tweak logic to make it clearer why and when we commit a batch * add a couple of comments * false -> 0 * add comment * unused * silence warning * add effect_pending_outside_reaction error * Update packages/svelte/src/compiler/types/index.d.ts Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * suspend batch, not boundary * rename from_async_derived -> current_async_derived * tweak * remove TODO - this method is only called when pending snippet exists * use error boundary for test - vitest does some weird error swallowing afaict * flush less often * restore -> activate * remove TODO * move batch-related code into batch.js * make flush_queued_root_effects a method of batch * make process_effects a method of batch * make stuff private * unused * regenerate * update test * more JSDoc * add more JSDoc * branch and block effects do not also need to be render effects * tidy up * simplify * unused * move code where it belongs * remove, for now * fix * only apply error adjustments when error escapes boundaries * remove EFFECT_IS_UPDATING * is_dirty is a better name than check_dirtiness * duplicates are rare and harmless * apparently we no longer need the merging logic? we can simplify and fix stuff by removing it * tidy * don't commit stale batches * add skipped failing test * partial merge * WIP * WIP * WIP * tweak * tidy up * dont update derived status when time-travelling * tidy up * tidy up * tag async deriveds * tweak * bail out of secondary flushes * re-run blocks on subsequent flushes * add test * fix * add tests, one failing * fix * flesh out await_waterfall message * tidy up * dry out * unused * tweak * tidy up * TODO * tweak * tidy up * remove TODO * unused export * add optimisation back * revert unneeded changes * revert * update some tests * more * more * move some code * rename * WIP * unset context synchronously * remove unused argument * Apply suggestions from code review Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> * add comment * add comment * use queue_micro_task in createSubscriber * Update packages/svelte/src/compiler/phases/3-transform/client/visitors/AwaitExpression.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * prettier --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com> Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	1 year ago
Rich Harris	b673145659	feat: add `getAbortSignal()` (#16266 ) * WIP getAbortSignal * add test * regenerate * add error code * changeset * regenerate * try this * { stale: true } * fix test * lint * abort synchronously in SSR * make STALE_REACTION a `StaleReactionError extends Error` * make non-optional * Update packages/svelte/src/internal/server/abort-signal.js Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> --------- Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com>	1 year ago
Paolo Ricciuti	c4b32c2bff	fix: untrack `$inspect.with` and add check for unsafe mutation (#16209 ) Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Paolo Ricciuti	37488fa65c	fix: warn when using rest or identifier in custom elements without props option (#16003 ) * fix: warn when using rest or identifier in custom elements without props option * chore: update message * tweak message * update tests --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Gautier Ben Aïm	de8094910d	fix(14815): warn when an invalid <select multiple> value is given (#14816 ) * fix(14815): warn when an invalid <select multiple> value is given * Create nervous-stingrays-travel.md	1 year ago
7nik	c66a43940a	feat: warn on implicitly closed tags (#15932 ) * warn on implicitly closed tags * lint * changeset * separate tests for parent/sibling case * account for attributes in opening tag * tweak * update message --------- Co-authored-by: 7nik <kifiranet@gmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Elliott Johnson	d103adff9c	feat: State declarations in class constructors (#15820 ) * feat: State declarations in class constructors * feat: Analysis phase * misc * feat: client * improvements * feat: It is now at least backwards compatible. though the new stuff may still be wrong * feat: It works I think? * final cleanup?? * tests * test for better types * changeset * rename functions (the function doesn't test call-expression-ness) * small readability tweak * failing test * fix * disallow computed state fields * tweak message to better accommodate the case in which state is declared after a regular property * failing test * wildly confusing to have so many things called 'class analysis' - rename the transform-phrase ones to transformers * missed a spot * and another * store analysis for use during transformation * move code to where it is used * do the analysis upfront, it's way simpler * skip failing test for now * simplify * get rid of the class * on second thoughts * reduce indirection * make analysis available at transform time * WIP * WIP * WIP * fix * remove unused stuff * revert snapshot tests * unused * note to self * fix * unused * unused * remove some unused stuff * unused * lint, tidy up * reuse helper * tweak * simplify/DRY * unused * tweak * unused * more * tweak * tweak * fix proxying logic * tweak * tweak * adjust message to accommodate more cases * unskip and fix test * fix * move * revert unneeded drive-by change * fix * fix * update docs --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	b93a617aa8	feat: attachments (#15000 ) * parse attachments * basic attachments working * working * rename to attach * fix * restrict which symbols are recognised as attachment keys * allow cleanup to be returned directly * changeset * fix * lint * remove createAttachmentKey/isAttachmentKey * fix spreading of symbol properties onto component * types * fix * update name * reserve ability to use sequence expressions in future * Update packages/svelte/src/internal/client/dom/elements/attachments.js Co-authored-by: Leonidaz <lbarenblit@gmail.com> * actually let's do this instead * expose createAttachmentKey * make room for `@attach` docs * add docs * failing test * fix * lock down * add missing reference docs * prevent conflicts * update docs * regenerate * fix link * add Attachment interface * beef up test * regenerate * tweak types * fix --------- Co-authored-by: Leonidaz <lbarenblit@gmail.com>	1 year ago
ComputerGuy	aa041a9e65	fix: warn on bidirectional control characters, fix various issues with template expressions (#15893 ) * fix: warn on bidirectional control characters * check evaluated values as well, fix minor issue * fix failing tests * lint * fix * shrink warning code * use validator test suite rather than snapshot (which should be used sparingly as it creates more git noise) * show ranges during parsing, and warn on all occurrences rather than just the first * fix lint * move check into Text visitor so it happens in expected order * unused * add svelte-ignore test * ignore control characters following a svelte-ignore comment * tweak message * no need to test evaluations, since we are already testing the literals that they are composed of --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
7nik	d8c6afde94	fix: emit error on wrong placement of the `:global` block selector (#15794 ) Co-authored-by: 7nik <kifiranet@gmail.com>	1 year ago
Rich Harris	262b281c91	docs: add inline documentation for svelte/reactivity (#15722 ) * docs: add inline documentation for svelte/reactivity * map * set * more * dedupe * tweak * typo * Apply suggestions from code review Co-authored-by: bytecodemanipulator <bytecodemanipulator@gmail.com> --------- Co-authored-by: bytecodemanipulator <bytecodemanipulator@gmail.com>	1 year ago
Elliott Johnson	e079ac92b8	fix: Throw on unrendered snippets in `dev` (#15766 )	1 year ago
Simon H	a051f96ed6	fix: relax `:global` selector list validation (#15762 ) We have to allow `:global x, :global y` selector lists because CSS preprocessors might generate that from `:global { x, y {...} }`	1 year ago
Rich Harris	95a020acea	fix: update `state_referenced_locally` message (#15733 ) * fix: update state_referenced_locally message * changeset * update message	1 year ago
ComputerGuy	ec1d85c89e	fix: add snippet argument validation in dev (#15521 ) * init * fix * make `Payload` a class * doh * lint * tweak changeset * fix * only export things that should be available on $ * tweak message * fix --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	c23f15134e	chore: remove stack-based module boundaries (#15711 )	1 year ago
Simon H	98d14ece66	fix: rework binding ownership validation (#15678 ) * remove old validation * fix: rework binding ownership validation Previously we were doing stack-based retrieval of the owner, which while catching more cases was costly (performance-wise) and prone to errors (as shown by many issues over the months). This drastically simplifies the ownership validation - we now only do simple static analysis to check which props are mutated and wrap them with runtime checks to see if a binding was established. Besides making the implementation simpler and more performant, this also follows an insight we had over the months: Most people don't really know what to do with this warning when it's shown beyond very simple cases. Either it's not actionable because they don't really know how to fix it or they question if they should at all (in some cases rightfully so). Now that the warning is only shown in simple and easy-to-reason-about cases, it has a much better signal-to-noise-ratio and will hopefully guide people in the right direction early on (learn from the obvious cases to not write spaghetti code in more complex cases). closes #15532 closes #15210 closes #14893 closes #13607 closes #13139 closes #11861 * remove some now obsolete tests * fix * better warnings now that we have more info * fix * hoist * we only care about mutation, not reassignment * tidy * handle prop aliases * mutation validation is only tangentially linked to context requirement * no need for two vars, one will do * update warning, include mutation location * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	3682371fb6	chore: doc fix (#15651 )	1 year ago
Paolo Ricciuti	3080c1334e	fix: prevent state runes from being called with spread (#15585 ) * fix: prevent state runes from being called with spread * prevent spread arguments for all runes except $inspect --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Rich Harris	ef98ccae8b	doh	1 year ago
Rich Harris	441108b8ff	fix docs	1 year ago
Rich Harris	842a7c6995	docs: update state_unsafe_mutation message (#15539 ) * docs: update state_unsafe_mutation message * regenerate * fix example	1 year ago
Rich Harris	6915c12b58	feat: allow state created in deriveds/effects to be written/read locally without self-invalidation (#15553 ) * move parent property onto Signal * don't self-invalidate when updating a source create inside current reaction * lazily create deep state with parent reaction * no need to push_derived_source with mutable_state, as it never coexists with $.derived * reduce indirection * remove state_unsafe_local_read error * changeset * tests * fix test * inelegant fix * remove arg * tweak * some progress * more * tidy up * parent -> p * tmp * alternative approach * tidy up * reduce diff size * more * update comment	1 year ago
Simon H	aaeda65f2f	docs: add docs on state_unsafe_mutation error (#14932 ) closes #14752	1 year ago
Paolo Ricciuti	474c588067	fix: disallow `bind:group` to snippet parameters (#15401 )	1 year ago
adiGuba	85f83ec435	feat: $props.id(), a SSR-safe ID generation (#15185 ) * first impl of $$uid * fix * $props.id() * fix errors * rename $.create_uid() into $.props_id() * fix message * relax const requirement, validate assignments instead * oops * simplify * non-constants should be lowercased * ditto * start at 1 * add docs * changeset * add test * add docs * doc : add code example * fix type reported by bennymi --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 year ago
Paolo Ricciuti	99fdc3f0ab	docs: update error message for `const_tag_invalid_placement` (#15003 )	2 years ago
Simon H	a2565efa37	docs: tweak "invalid assignment" compiler error message (#14955 ) * docs: tweak "invalid assignment" compiler error message fixes #14702 * tweak wording --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 years ago
Rich Harris	d41801c75f	feat: warn on using `slide` transition with invalid `display` styles (#14936 ) * feat: warn on using `slide` transition with table elements * more generic * more generic	2 years ago
Caique Torres	48e3db21c1	fix: default values in object destructuring (#14554 ) * fix: enhance string/expression length check and fix closing character issues * docs: add documentation for unterminated_string_constant error * test: add tests for object destructuring with default values in "each" blocks * Update .changeset/clean-planets-rush.md * refactor: clean up unnecessary comments and whitespace * fix: resolve formatting issues * simplify * tweak * regenerate --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 years ago
Rich Harris	97f3aa9151	docs: fix links in some errors/warnings (#14825 ) * fix links in some errors/warnings * fix	2 years ago
Rich Harris	bfa0b34663	add self-closing-tags info (#14758 ) * add self-closing-tags info * regenerate	2 years ago
Dominic Gannaway	5483495c8d	feat: add $inspect.trace rune (#14290 ) * feat: add $trace rune WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP WIP * lint * fix * fix * fix * fix * fix * fix * fix * more tweaks * lint * improve label for derived cached * improve label for derived cached * lint * better stacks * complete redesign * fixes * dead code * dead code * improve change detection * rename rune * lint * lint * fix bug * tweaks * Update packages/svelte/src/internal/client/dev/tracing.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update packages/svelte/src/internal/client/dev/tracing.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update packages/svelte/src/internal/client/dev/tracing.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * Update packages/svelte/src/internal/client/dev/tracing.js Co-authored-by: Rich Harris <rich.harris@vercel.com> * todos * add test + some docs * changeset * update messages * address feedback * address feedback * limit to first statement of function * remove unreachable trace_rune_duplicate error * tweak message * remove the expression statement, not the expression * revert * make label optional * relax restriction on label - no longer necessary with new design * update errors * newline * tweak * add some docs * fix playground * fix playground * tweak message when function runs outside an effect * unused * tweak * handle async functions * fail on generators * regenerate, update docs * better labelling --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 years ago

1 2

78 Commits (3ec461baad451654db6d518734aeeb7b366f7c2e)