svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	5d82573dcd	fix: properly assign trailing comments (#12471 ) * fix: properly assign trailing comments Trailing comments were added even if they started before the node end, which violates the definition of trailing comments. This fixes that, with the consequence that some comments no longer show up in the AST at all. Previously they were stuffed _somewhere_, but arguably at the wrong positions. For example the last comment in a function body got assigned as a trailing comma for the body, which is wrong, because the body ends _after_ the comma. The special case is comments at the end of an expression tag - they are added even if there are multiple, and they are added regardless of whether they are separated by newlines or not. This ensures the expression tag end is calculated correctly. Fixes #12466 * support multiple trailing comments after last statement in a body * simplify, handle object and array expressions	1 year ago

Author

SHA1

Message

Date

Simon H

5d82573dcd

fix: properly assign trailing comments (#12471 )

* fix: properly assign trailing comments

Trailing comments were added even if they started before the node end, which violates the definition of trailing comments.
This fixes that, with the consequence that some comments no longer show up in the AST at all. Previously they were stuffed _somewhere_, but arguably at the wrong positions. For example the last comment in a function body got assigned as a trailing comma for the body, which is wrong, because the body ends _after_ the comma.
The special case is comments at the end of an expression tag - they are added even if there are multiple, and they are added regardless of whether they are separated by newlines or not. This ensures the expression tag end is calculated correctly.

Fixes #12466

* support multiple trailing comments after last statement in a body

* simplify, handle object and array expressions

1 Commits (25316580465304ff461fe10f6ccad8bb91bbfa41)