svelte

Commit Graph

Author	SHA1	Message	Date
Gautier Ben Aïm	9414eaa41b	fix: prevent crash on async custom element attributes (#18661 ) attributes setter logic wasn't async-aware --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
Yuichiro Yamashita	248a2e1db4	fix: transform expressions inside labeled statements during server compilation (#18617 ) close: #18615	3 weeks ago
subotac	c0987c09f8	fix: remove stale capture listeners from spread attributes (#18618 ) Fixes #18608. When `set_attributes` normalized removed spread attributes, it also copied its internal `$$` listener bookkeeping keys into `next` with a `null` value. This cleared the stored callback before event cleanup, so removing a capture handler passed `null` to `removeEventListener` and left the listener attached. Skip internal `$$` keys during missing-attribute normalization. The updated runtime-runes sample verifies replacing and then removing a spread capture handler in both client and hydration modes. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	4 weeks ago
Yuuki Oohara	a224dd5867	fix: give effect teardowns the value from before the first write in a flush (#18620 ) Fixes #18619 Make sure to not override old values with newer values that are part of the same flush --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	4 weeks ago
svelte-triage-bot[bot]	221dcae8ca	fix: preserve comment placement for server derived reads (#18641 ) Fixes https://github.com/sveltejs/svelte/issues/18607. For server output, `build_getter` reused a derived binding's declaration identifier as the generated call callee. Esrap therefore associated leading declaration comments with an earlier reference, potentially emitting them immediately after `return` and triggering automatic semicolon insertion. The getter returned `undefined` instead of the derived value. Fix it by avoiding the double-transform. --------- Co-authored-by: svelte-triage-bot[bot] <316883489+svelte-triage-bot[bot]@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	4 weeks ago
paoloricciuti	dd148ebb74	Merge branch 'main' into svelte-custom-renderer	4 weeks ago
남정욱	7725f77cca	fix: apply CSS custom properties with falsy values on components (#18634 )	4 weeks ago
Yuichiro Yamashita	135f4439c3	fix: increment private state fields through a non-`this` receiver (#18622 )	4 weeks ago
github-actions[bot]	20b341f100	Version Packages (#18628 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.9 ### Patch Changes - fix: skip controlled each fast path while another batch is pending ([#18625](https://github.com/sveltejs/svelte/pull/18625)) - fix: better whitespace handling inside printer ([#18638](https://github.com/sveltejs/svelte/pull/18638)) - fix: don't duplicate comments in attributes ([#18636](https://github.com/sveltejs/svelte/pull/18636)) - fix: preserve CSS comments in the AST printer ([#18637](https://github.com/sveltejs/svelte/pull/18637)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 weeks ago
Simon H	ee6dff80ca	fix: better whitespace handling inside printer (#18638 ) - preserve whitespace around elements if it leads to a line break - preserve whitespace for whitespace-sensitive elements (pre, textarea, title) Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 weeks ago
Simon H	a1d5035d17	fix: preserve CSS comments in the AST printer (#18637 ) Adds a new `comments` array to the stylesheet node which CSS comments are added to. Is subsequently used in `print` to see them in the output. Alternative to #18475	4 weeks ago
Simon H	3ed9db4ba7	fix: don't duplicate comments in attributes (#18636 ) An attribute with a comment would be printed again atop the following attribute because we didn't take that case into account.	4 weeks ago
Sankalp Thakur	26786e9298	fix: skip controlled each fast path while another batch is pending (#18625 ) Fixes #18610 ### Problem In async mode, a controlled keyed `{#each}` throws `TypeError: Cannot read properties of undefined (reading 'e')` when its collection becomes empty while an earlier batch is still pending on the same block. The fast path in `pause_effects` cleared `state.items` and then called `destroy_effects`, which walks pending batch keys and reads `state.items.get(key).e`. Those EachItems are still needed for the pending batch (preserved offscreen), so clearing the map makes the dereference throw and aborts the commit mid-flight. ### Fix Only take the controlled-each fast path when `state.pending.size === 0`, so pending batches keep their items until they commit or discard.	1 month ago
paoloricciuti	c22f2fa603	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	1 month ago
github-actions[bot]	44a7813730	Version Packages (#18572 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.8 ### Patch Changes - fix: call `onerror` and provide a working `reset` when hydrating a failed boundary ([#18556](https://github.com/sveltejs/svelte/pull/18556)) - fix: preserve select selection when spread attributes omit value ([#18561](https://github.com/sveltejs/svelte/pull/18561)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Elliott Johnson	23bc246a99	chore: Supply chain hardening (#18253 ) `svelte` Supply-chain hardening pass. ## Changes - Bump `packageManager` from `pnpm@10.4.0` to `pnpm@10.33.4` with `+sha512` integrity suffix. - Add to `pnpm-workspace.yaml`: - `minimumReleaseAge: 1440` - `minimumReleaseAgeExclude: ['@sveltejs/*', svelte, esrap, devalue]` - `blockExoticSubdeps: true` - Remove `pkg.pr.new.yml` workflow in favor of `pkg.svelte.dev` - Pin all third-party GitHub Actions to full SHA with `# vX.Y.Z` comments across `ci.yml`, `autofix.yml`, `release.yml`, `ecosystem-ci-trigger.yml` - Upgrade `pnpm/action-setup` references in `ci.yml`, `autofix.yml`, `release.yml` from a SHA that was incorrectly labeled `# v4` (actually `v5.0.0` / `v4.4.0`) to the current `v6.0.8` SHA so the version label matches reality.	2 months ago
Nic Polumeyv	3dde011d3a	fix: call `onerror` and provide a working `reset` when hydrating a failed boundary (#18556 ) Fixes #18555 A boundary that failed during SSR hydrates via `#hydrate_failed_content`, which never calls `onerror` and passes the `failed` snippet a no-op `reset`. Both came in with #17672, whose docs say `onerror` "will be called upon hydration with the deserialized error object". Once hydrated as failed, the boundary can never leave that state. Downstream this is what keeps SvelteKit's `+error.svelte` mounted after navigating away from a server-rendered error page (sveltejs/kit#16345). This extracts the reset/onerror machinery from `#handle_error` into `#create_reset` and uses it in the hydration path too. `onerror` is invoked in a microtask because it may mutate state, which is disallowed while hydrating. `#handle_error` already invokes it asynchronously, so the timing matches the error path. The tests flip a `recovered` flag before calling `reset`, since the child would otherwise throw again. That is the intended retry pattern, and the same one kit uses when it resets route boundaries on navigation. Verified against kit end to end, hydrating a server-rendered error page and navigating away now tears it down with no kit changes needed.	2 months ago
Floze	2bace308e3	fix: preserve select selection with spread attributes (#18561 ) Fixes #18557 A `<select>` with spread attributes initializes the option mutation observer even when those attributes never provide a `value`. In that case the element has no internal `__value`, but the observer previously treated the missing property as an explicit `undefined` value and deselected every option after an option was added or removed. Only reapply the programmatic selection when `__value` is actually present. This preserves the browser's current selection for spreads without a value while keeping the existing behavior for bindings, including an explicitly stored `undefined` value. A runtime-legacy regression fixture covers both adding and removing an option in client and hydration modes. ### Before submitting - [x] References the existing issue - [x] Uses a `fix:` title - [x] Includes a regression test - [x] Includes a patch changeset for `svelte` ### Test plan - [x] `FILTER=select-spread-preserve-selection pnpm test runtime-legacy --maxWorkers=1` (2 tests passed: client and hydrate) - [x] `git diff --check` - [ ] Full `pnpm test` was not run because the shared host was under resource pressure and broad test processes were explicitly avoided - [ ] `pnpm lint` and `pnpm check` were not run for the same reason - [ ] Targeted repository Prettier check was attempted, but could not start because `prettier-plugin-svelte` required the ungenerated `packages/svelte/compiler/index.js`; no broad build or dependency reinstall was run ### AI disclosure AI-assisted: the implementation, regression test, and pull request text were prepared with OpenAI Codex and reviewed by the contributor. Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>	2 months ago
paoloricciuti	216f258068	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
github-actions[bot]	b29d7002ec	Version Packages (#18560 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.7 ### Patch Changes - chore: provide `indent` option for `print` ([#18474](https://github.com/sveltejs/svelte/pull/18474)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Rich Harris	d9e40d17cf	docs: update link on hooks page (#18564 ) this docs page updated recently and broke everything	2 months ago
Manuel	b791cac54e	chore: provide `indent` option for `print` (#18474 ) Relevant for https://github.com/sveltejs/cli/pull/1138. This is basically just an option from `esrap` that we pass through. That will allow tools like `sv migrate` to provide a guessed indent based on the other file contents and therefore allow us to produce way smaller diffs. Since we are just passing an option, there is no need for a test here. Technically a `feat:` but i dont think this is relevant enough. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	2 months ago
github-actions[bot]	4a6a85b5f1	Version Packages (#18552 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.6 ### Patch Changes - perf: skip unnecessary blocker analysis when compiling components without top-level await ([#18548](https://github.com/sveltejs/svelte/pull/18548)) - fix: rerun derived that had an abort controller on reconnection ([#18551](https://github.com/sveltejs/svelte/pull/18551)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
Joe Schafer	d0dbe1a480	perf: skip quadratic blocker analysis when no top-level await (#18548 ) Skip function reference tracing in `calculate_blockers` when a component has no top-level `await`. Blockers only represent dependencies on top-level async statements. Without a top-level `await`, no binding can have a blocker, so tracing every top-level function cannot affect the generated output. In large components with many functions and transitive assignments, that unnecessary work can become quadratic.	2 months ago
Simon H	22e0adb75a	fix: rerun derived that had an abort controller on reconnection (#18551 ) Follow-up to #18400 - we need to mark a derived with an abort signal that is frozen as dirty so it is guaranteed to rerun when it reconnects/is re-requested. Else you could return a stale value, or worse, you returned a promise from the derived which you aborted, and it's now in the rejected state until you update one of its dependencies.	2 months ago
github-actions[bot]	602a873b6b	Version Packages (#18497 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.5 ### Patch Changes - chore: drop dead code that make TSGO fail ([#18496](https://github.com/sveltejs/svelte/pull/18496)) - fix: don't (re)connect deriveds when read inside branch/root effects ([#18527](https://github.com/sveltejs/svelte/pull/18527)) - fix: skip unnecessary derived effect in earlier batch ([#18525](https://github.com/sveltejs/svelte/pull/18525)) - fix: avoid declaration tag warning in event handlers ([#18500](https://github.com/sveltejs/svelte/pull/18500)) - fix: abort deriveds own AbortSignal when it disconnects ([#18400](https://github.com/sveltejs/svelte/pull/18400)) - fix: ensure `$state.eager()` is correctly transormed for SSR output ([#18530](https://github.com/sveltejs/svelte/pull/18530)) - fix: correctly transform declaration tags during SSR ([#18492](https://github.com/sveltejs/svelte/pull/18492)) - fix: transform computed keys in keyed `{#each}` destructuring patterns ([#18521](https://github.com/sveltejs/svelte/pull/18521)) - fix: chain preprocessor sourcemaps with an empty `sources[0]` instead of dropping them ([#18518](https://github.com/sveltejs/svelte/pull/18518)) - fix: clear previous_task reference after abort in Tween to prevent memory leak on interrupted tweens ([#18541](https://github.com/sveltejs/svelte/pull/18541)) - fix: don't treat declaration tags as parts inside each blocks ([#18507](https://github.com/sveltejs/svelte/pull/18507)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 months ago
paoloricciuti	2311e1757d	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
adiGuba	a4fd67e361	fix: $state.eager() is sometimes incorrect in SSR (#18530 ) Fix #18529 A simple fix : `context.visit()` was missing on the argument of `$state.eager()`, so the generated code can be incorrect in some case :	2 months ago
prashantg-pixi	199ffebca3	fix: clear previous_task reference after abort in Tween (#18541 ) avoids memory leaks	2 months ago
Simon H	edeef1f9f7	chore: add some failing tests (#18528 ) During my explorations I collected these new tests which are currently failing. Two of them work on the incremental-batches branch, all of them (adjusted for new behavior) pass on my uncommitted entangle batches branch, and all of them also pass on another uncommitted experimental branch of overlaying deriveds which will likely not land.	2 months ago
Fedor Nezhivoi	a91b068786	fix: abort deriveds own AbortSignal when it disconnects (#18400 ) Fixes https://github.com/sveltejs/svelte/issues/18301 --------- Co-authored-by: Fedor Nezhivoi <f.nezhivoi@corp.vk.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 months ago
Simon H	4da9f74cd9	chore: bench compare report as HTML (#18543 ) Creates a `results.html` file which is much better to look at compared to the terminal output.	2 months ago
Simon H	af6f1d309b	chore: run every benchmark in its own process (#18542 ) While benchmarking it became apparent that when running the full `pnpm bench:compare` suite results could be wildly different compared to only comparing single benchmarks. The reason (most likely) is that the heap/GC/JIT state from one benchmark contaminates the others. Therefore this adjusts the runners such that each benchmark entry is run in its own forked process, not just each branch. This should give better, more stable results. Also a little fix to compare results by name; I made the mistake of adding a new benchmark to main which wasn't present on other branches yet, which made the results really confusing.	2 months ago
paoloricciuti	ce6e71c695	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
Thribhuvan	b4d1583ae2	fix: transform computed keys in keyed each block destructuring patterns (#18521 ) fixes #18519	2 months ago
Simon H	8e4f26552c	chore: changeset (#18527 ) for #18517	2 months ago
Rabindra Kumar Meher	08a9e9e7e4	fix: prevent derived connection leak in untracked contexts (#18517 ) Fixes #18501. Problem is that is_updating_effect was also set to true for branch/root effects which are not reactive --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 months ago
JY Wey	bfbb026f2f	fix: skip unnecessary derived effect in earlier batch (#18525 ) fixes #18438 Currently the `mark` method inside `#merge` for `earlier_batch` will schedule effect for undirty derived. Add the condition for derived to prevent unnecessary effect be scheduled. ``` if ((flags & DERIVED) !== 0) { mark(/** @type {Derived} */ (reaction)); } ```	2 months ago
Simon H	c2b7642263	chore: add benchmarks (#18523 ) Add two kairo variants to better measure of `#traverse` / block effects perf	2 months ago
Ivan	5edd8b0602	fix: chain preprocessor sourcemaps with an empty sources[0] (#18518 ) ## Summary Fixes #18491 — the compiler discards an upstream plugin's sourcemap when it's generated without a `source` option (e.g. `new MagicString(code).generateMap()`), producing wrong devtools/stack-trace positions. ### Root cause `compile()` already supports composing an incoming sourcemap into its output via `options.sourcemap` (`merge_with_preprocessor_map` → `apply_preprocessor_sourcemap` → `combine_sourcemaps` in `packages/svelte/src/compiler/utils/mapped_code.js`). This is the same mechanism `preprocess()` uses internally, and it's the documented contract for tools that transform a `.svelte` file before compiling it (see `CompileOptions.sourcemap`'s doc comment). `combine_sourcemaps` composes maps by matching `sourcefile === filename` (the basename of the file being compiled). A sourcemap produced by `new MagicString(code).generateMap()` without a `source` option — which is exactly what the reporter's Vite plugin does — has `sources: ['']`. That empty string never equals `filename`, so `remapping()` treats the node as a leaf (the "original" file) instead of a branch to keep chaining through, and the whole incoming map is silently dropped. The result: every position that flows through that segment resolves to `{ source: null, line: null, column: null }`, which is what produces the wrong/missing devtools mapping described in the issue. Vite itself already has to handle this exact ambiguity: in `pluginContainer.ts`'s `_getCombinedSourcemap`, an empty `sources[0]` from a MagicString-based transform is patched to refer to the file being transformed before Vite uses it internally. This PR applies the same normalization on svelte's side, so the contract holds regardless of whether the caller happens to pass a `source` option to `generateMap()`. ### Fix In `apply_preprocessor_sourcemap`, normalize an incoming map's `sources: ['']` (or `[null]`/`[undefined]`) to `[filename]` before calling `combine_sourcemaps`, so the chain-matching step can actually find it.	2 months ago
Paolo Ricciuti	41642b70ee	fix: avoid declaration tag warning in event handlers (#18500 ) Closes #18493 Co-authored-by: justjavac <justjavac@gmail.com>	2 months ago
paoloricciuti	0c226fcf4e	Merge remote-tracking branch 'origin/main' into svelte-custom-renderer	2 months ago
Paolo Ricciuti	8fb7ceeba5	fix: don't treat declaration tags as parts inside each blocks (#18507 ) Closes #18506 Declaration tags in the scope of an each block were considered "parts" and transformed to use their value instead of the signal itself. We can safely check on the `kind` of the binding since a `kind` of `state`, `state_raw` or `derived` in the each scope needs to be a declaration tag (and it's a stable reference so we can use them directly)	2 months ago
Paolo Ricciuti	33304b4b15	Merge branch 'main' into svelte-custom-renderer	2 months ago
Paolo Ricciuti	b1cadd1eae	chore: drop dead code that make TSGO fail (#18496 )	2 months ago
Paolo Ricciuti	b9e03714eb	fix: correctly transform declaration tags during SSR (#18492 ) Closes #18490	2 months ago
paoloricciuti	39887f5ace	fix: update snapshot	2 months ago
Paolo Ricciuti	7c5b06657c	Merge branch 'main' into svelte-custom-renderer	2 months ago
github-actions[bot]	eae50dfd1c	Version Packages (#18435 ) This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.56.4 ### Patch Changes - fix: include wrapping parentheses in `{@const}` declarator `end` position ([#18436](https://github.com/sveltejs/svelte/pull/18436)) - fix: always unset reactivity context after restoring it ([#18453](https://github.com/sveltejs/svelte/pull/18453)) - fix: don't notify `searchParams` subscribers when the URL changes without affecting the search string ([#18425](https://github.com/sveltejs/svelte/pull/18425)) - fix: strip `?` from optional parameters in `<script lang="ts">` so generated JavaScript is valid ([#18448](https://github.com/sveltejs/svelte/pull/18448)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 months ago
Simon H	36ae0622a8	fix: always unset reactivity context after restoring it (#18453 ) When calling `save`, we restore the context after the promise resolves. But we do not unset it after the subsequent synchronous execution. That means that until `unset_context` runs in `async_derived` we will not have the correct (nulled) context. That causes problems if the `save` isn't the last promise contributing to the `async_derived`, because it means the context is not properly unset until the promise _after_ the `save` within the `async_derived` settles. This can cause all sorts of mixups, including a wrong mutation error. fixes #18441	3 months ago

1 2 3 4 5 ...

11556 Commits (1e5dc328cd7fe081f3a23cf015d6c8725ca287a8) All Branches Search

11556 Commits (1e5dc328cd7fe081f3a23cf015d6c8725ca287a8)

All Branches